From: Hanjun Guo <guohanjun@huawei.com>
To: Alex Kogan <alex.kogan@oracle.com>, <linux@armlinux.org.uk>,
<peterz@infradead.org>, <mingo@redhat.com>, <will.deacon@arm.com>,
<arnd@arndb.de>, <longman@redhat.com>,
<linux-arch@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
<bp@alien8.de>, <hpa@zytor.com>, <x86@kernel.org>
Cc: <dave.dice@oracle.com>, <rahul.x.yadav@oracle.com>,
<steven.sistare@oracle.com>, <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock
Date: Thu, 4 Apr 2019 10:02:30 +0800 [thread overview]
Message-ID: <5ac2fb0e-744b-3bb5-133a-ac684e061d17@huawei.com> (raw)
In-Reply-To: <20190329152006.110370-4-alex.kogan@oracle.com>
Hi Alex,
On 2019/3/29 23:20, Alex Kogan wrote:
> +
> +static __always_inline void cna_init_node(struct mcs_spinlock *node, int cpuid,
> + u32 tail)
> +{
> + if (decode_numa_node(node->node_and_count) == -1)
> + store_numa_node(node, numa_cpu_node(cpuid));
How about using cpu_to_node() here and #include <linux/topology.h> in this
file, then the code can be reused for other architectures such as ARM64?
Thanks
Hanjun
next prev parent reply other threads:[~2019-04-04 2:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 15:20 [PATCH v2 0/5] Add NUMA-awareness to qspinlock Alex Kogan
2019-03-29 15:20 ` [PATCH v2 1/5] locking/qspinlock: Make arch_mcs_spin_unlock_contended more generic Alex Kogan
2019-03-29 15:20 ` [PATCH v2 2/5] locking/qspinlock: Refactor the qspinlock slow path Alex Kogan
2019-03-29 15:20 ` [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock Alex Kogan
2019-04-01 9:06 ` Peter Zijlstra
2019-04-01 9:33 ` Peter Zijlstra
2019-04-03 15:53 ` Alex Kogan
2019-04-03 16:10 ` Peter Zijlstra
2019-04-01 9:21 ` Peter Zijlstra
2019-04-01 14:36 ` Waiman Long
2019-04-02 9:43 ` Peter Zijlstra
2019-04-03 15:39 ` Alex Kogan
2019-04-03 15:48 ` Waiman Long
2019-04-03 16:01 ` Peter Zijlstra
2019-04-04 5:05 ` Juergen Gross
2019-04-04 9:38 ` Peter Zijlstra
2019-04-04 18:03 ` Waiman Long
2019-06-04 23:21 ` Alex Kogan
2019-06-05 20:40 ` Peter Zijlstra
2019-06-06 15:21 ` Alex Kogan
2019-06-06 15:32 ` Waiman Long
2019-06-06 15:42 ` Waiman Long
2019-04-03 16:33 ` Waiman Long
2019-04-03 17:16 ` Peter Zijlstra
2019-04-03 17:40 ` Waiman Long
2019-04-04 2:02 ` Hanjun Guo [this message]
2019-04-04 3:14 ` Alex Kogan
2019-06-11 4:22 ` liwei (GF)
2019-06-12 4:38 ` Alex Kogan
2019-06-12 15:05 ` Waiman Long
2019-03-29 15:20 ` [PATCH v2 4/5] locking/qspinlock: Introduce starvation avoidance into CNA Alex Kogan
2019-04-02 10:37 ` Peter Zijlstra
2019-04-03 17:06 ` Alex Kogan
2019-03-29 15:20 ` [PATCH v2 5/5] locking/qspinlock: Introduce the shuffle reduction optimization " Alex Kogan
2019-04-01 9:09 ` [PATCH v2 0/5] Add NUMA-awareness to qspinlock Peter Zijlstra
2019-04-03 17:13 ` Alex Kogan
2019-07-03 11:58 ` Jan Glauber
2019-07-12 8:12 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ac2fb0e-744b-3bb5-133a-ac684e061d17@huawei.com \
--to=guohanjun@huawei.com \
--cc=alex.kogan@oracle.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.dice@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rahul.x.yadav@oracle.com \
--cc=steven.sistare@oracle.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).