* [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC
@ 2022-02-27 21:32 Lad Prabhakar
2022-02-28 9:46 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Lad Prabhakar @ 2022-02-27 21:32 UTC (permalink / raw)
To: Geert Uytterhoeven, Wolfgang Grandegger, Marc Kleine-Budde,
David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Fabrizio Castro, linux-can, netdev,
devicetree
Cc: Lad Prabhakar, linux-kernel, Prabhakar, Biju Das
Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
the RZ/G2L SoC. No driver changes are required as generic compatible
string "renesas,rzg2l-canfd" will be used as a fallback.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
---
DTSI changes [0] have been posted as part of separate series.
[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
.../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 91a3554ca950..f98c53dc1894 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -33,6 +33,7 @@ properties:
- items:
- enum:
- renesas,r9a07g044-canfd # RZ/G2{L,LC}
+ - renesas,r9a07g054-canfd # RZ/V2L
- const: renesas,rzg2l-canfd # RZ/G2L family
- const: renesas,r8a779a0-canfd # R-Car V3U
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC
2022-02-27 21:32 [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC Lad Prabhakar
@ 2022-02-28 9:46 ` Krzysztof Kozlowski
2022-03-01 8:16 ` Geert Uytterhoeven
2022-03-01 15:33 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-28 9:46 UTC (permalink / raw)
To: Lad Prabhakar, Geert Uytterhoeven, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Jakub Kicinski, Rob Herring,
Fabrizio Castro, linux-can, netdev, devicetree
Cc: linux-kernel, Prabhakar, Biju Das
On 27/02/2022 22:32, Lad Prabhakar wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> DTSI changes [0] have been posted as part of separate series.
>
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
> .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC
2022-02-27 21:32 [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC Lad Prabhakar
2022-02-28 9:46 ` Krzysztof Kozlowski
@ 2022-03-01 8:16 ` Geert Uytterhoeven
2022-03-01 15:33 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-03-01 8:16 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski, Rob Herring, Krzysztof Kozlowski,
Fabrizio Castro, linux-can, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Prabhakar, Biju Das
Hi Prabhakar,
On Sun, Feb 27, 2022 at 10:33 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -33,6 +33,7 @@ properties:
> - items:
> - enum:
> - renesas,r9a07g044-canfd # RZ/G2{L,LC}
> + - renesas,r9a07g054-canfd # RZ/V2L
> - const: renesas,rzg2l-canfd # RZ/G2L family
The last comment looks a bit strange, unless you consider RZ/V2L to be
part of the RZ/G2L family, so perhaps drop it?
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC
2022-02-27 21:32 [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC Lad Prabhakar
2022-02-28 9:46 ` Krzysztof Kozlowski
2022-03-01 8:16 ` Geert Uytterhoeven
@ 2022-03-01 15:33 ` Rob Herring
2022-03-02 13:57 ` Lad, Prabhakar
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-03-01 15:33 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Geert Uytterhoeven, Wolfgang Grandegger, Marc Kleine-Budde,
David S. Miller, Jakub Kicinski, Krzysztof Kozlowski,
Fabrizio Castro, linux-can, netdev, devicetree, linux-kernel,
Prabhakar, Biju Das
On Sun, Feb 27, 2022 at 09:32:50PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> DTSI changes [0] have been posted as part of separate series.
>
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
> .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 1 +
> 1 file changed, 1 insertion(+)
The patch wouldn't apply, but I don't see the problem other than the
sha hashes are not from a known base. Please send patches against a
known rcX (rc1 is preferred) unless you have some other dependency. And
document that dependency.
Anyways, it is applied manually now.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC
2022-03-01 15:33 ` Rob Herring
@ 2022-03-02 13:57 ` Lad, Prabhakar
0 siblings, 0 replies; 5+ messages in thread
From: Lad, Prabhakar @ 2022-03-02 13:57 UTC (permalink / raw)
To: Rob Herring
Cc: Lad Prabhakar, Geert Uytterhoeven, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Jakub Kicinski,
Krzysztof Kozlowski, Fabrizio Castro, linux-can, netdev,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Biju Das
Hi Rob,
On Tue, Mar 1, 2022 at 3:34 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Feb 27, 2022 at 09:32:50PM +0000, Lad Prabhakar wrote:
> > Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> > the RZ/G2L SoC. No driver changes are required as generic compatible
> > string "renesas,rzg2l-canfd" will be used as a fallback.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > DTSI changes [0] have been posted as part of separate series.
> >
> > [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> > 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> > ---
> > .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> The patch wouldn't apply, but I don't see the problem other than the
> sha hashes are not from a known base. Please send patches against a
> known rcX (rc1 is preferred) unless you have some other dependency. And
> document that dependency.
>
Sorry about that, I missed mentioning the depadancy patch [0].
> Anyways, it is applied manually now.
>
Thanks.
[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220209163806.18618-5-uli+renesas@fpond.eu/
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-02 13:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-27 21:32 [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC Lad Prabhakar
2022-02-28 9:46 ` Krzysztof Kozlowski
2022-03-01 8:16 ` Geert Uytterhoeven
2022-03-01 15:33 ` Rob Herring
2022-03-02 13:57 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).