[PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[Lad Prabhakar]

Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
the RZ/G2L SoC. No driver changes are required as generic compatible
string "renesas,rzg2l-canfd" will be used as a fallback.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
---
DTSI changes [0] have been posted as part of separate series.

[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 91a3554ca950..f98c53dc1894 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -33,6 +33,7 @@ properties:
       - items:
           - enum:
               - renesas,r9a07g044-canfd    # RZ/G2{L,LC}
+              - renesas,r9a07g054-canfd    # RZ/V2L
           - const: renesas,rzg2l-canfd     # RZ/G2L family
 
       - const: renesas,r8a779a0-canfd      # R-Car V3U
-- 
2.17.1

Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[Krzysztof Kozlowski]

On 27/02/2022 22:32, Lad Prabhakar wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> DTSI changes [0] have been posted as part of separate series.
> 
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml          | 1 +
>  1 file changed, 1 insertion(+)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[Geert Uytterhoeven]

Hi Prabhakar,

On Sun, Feb 27, 2022 at 10:33 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -33,6 +33,7 @@ properties:
>        - items:
>            - enum:
>                - renesas,r9a07g044-canfd    # RZ/G2{L,LC}
> +              - renesas,r9a07g054-canfd    # RZ/V2L
>            - const: renesas,rzg2l-canfd     # RZ/G2L family

The last comment looks a bit strange, unless you consider RZ/V2L to be
part of the RZ/G2L family, so perhaps drop it?

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[Rob Herring]

On Sun, Feb 27, 2022 at 09:32:50PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> the RZ/G2L SoC. No driver changes are required as generic compatible
> string "renesas,rzg2l-canfd" will be used as a fallback.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> DTSI changes [0] have been posted as part of separate series.
> 
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml          | 1 +
>  1 file changed, 1 insertion(+)

The patch wouldn't apply, but I don't see the problem other than the 
sha hashes are not from a known base. Please send patches against a 
known rcX (rc1 is preferred) unless you have some other dependency. And 
document that dependency.

Anyways, it is applied manually now.

Rob

Re: [PATCH] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/V2L SoC

[Lad, Prabhakar]

Hi Rob,

On Tue, Mar 1, 2022 at 3:34 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Feb 27, 2022 at 09:32:50PM +0000, Lad Prabhakar wrote:
> > Document RZ/V2L CANFD bindings. RZ/V2L CANFD is identical to one found on
> > the RZ/G2L SoC. No driver changes are required as generic compatible
> > string "renesas,rzg2l-canfd" will be used as a fallback.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > DTSI changes [0] have been posted as part of separate series.
> >
> > [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> > 20220227203744.18355-4-prabhakar.mahadev-lad.rj@bp.renesas.com/
> > ---
> >  .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml          | 1 +
> >  1 file changed, 1 insertion(+)
>
> The patch wouldn't apply, but I don't see the problem other than the
> sha hashes are not from a known base. Please send patches against a
> known rcX (rc1 is preferred) unless you have some other dependency. And
> document that dependency.
>
Sorry about that, I missed mentioning the depadancy patch [0].

> Anyways, it is applied manually now.
>
Thanks.

[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220209163806.18618-5-uli+renesas@fpond.eu/

Cheers,
Prabhakar