From: Arnd Bergmann <arnd@arndb.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Lee Jones <lee.jones@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Aaron Lu <aaron.lu@intel.com>,
Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH v3 02/15] Driver core: Unified device properties interface for platform firmware
Date: Thu, 02 Oct 2014 09:46:29 +0200 [thread overview]
Message-ID: <6092163.dWXI6rWTCu@wuerfel> (raw)
In-Reply-To: <4390403.PNxQqnBDGX@vostro.rjw.lan>
On Thursday 02 October 2014 00:09:44 Rafael J. Wysocki wrote:
> On Wednesday, October 01, 2014 09:47:40 AM Arnd Bergmann wrote:
> > On Wednesday 01 October 2014 04:10:03 Rafael J. Wysocki wrote:
> > I still have my reservations against the child accessors, and would
> > like to hear what other people think. Passing a void pointer rather
> > than struct fw_dev_node has both advantages and disadvantages, and
> > I won't complain about either one if enough other people on the DT
> > side would like to see the addition of the child functions.
>
> I actually would rather like to know if the people on the DT side have any
> problems with the child functions.
Sure, any kind of feedback would be helpful really.
> Because, suppose that they wouldn't like those functions at all. What are we
> supposed to do, then, honestly? Add the whole DT vs ACPI logic to the leds-gpio
> and gpio_keys_polled drivers? But these drivers have no reason whatsoever
> to include that. Zero.
>
> So suggestions welcome.
>
> [BTW, In principle we also could use something like
>
> typedef union dev_node {
> struct acpi_device *acpi_node;
> struct device_node *of_node;
> } dev_node_t;
>
> instead of the (void *) for more type safety. It still is useful to pass the
> parent pointer along with that, though.]
Yes, I'm not worried about the implementation details.
> > > Finally, device_for_each_child_node() is added for iterating over
> > > the children of the device description object associated with a
> > > given device.
> > >
> > > The interface covers both ACPI and Device Trees.
> > >
> > > This change set includes material from Mika Westerberg and Aaron Lu.
> > >
> >
> > Regarding device_for_each_child_node(), the syntax is inconsistent
> > with what we normally use, which can probably be changed. All of the
> > DT for_each_* helpers are macros that are used like
> >
> > struct device *dev = ...;
> > void *child; /* iterator */
> >
> > device_for_each_child_node(dev, child) {
> > u32 something;
> > device_child_property_read_u32(dev, child, "propname", &something);
> >
> > do_something(dev, something);
> > }
> >
> > If we get a consensus on having the child interfaces, I'd rather see
> > them done this way than with a callback pointer, for consistency
> > reasons.
>
> That certainly is doable, although the resulting macro would generate a rather
> large chunk of code each time it is used.
#define device_for_each_child_node(dev, child) \
for (child = device_get_next_child_node(dev, NULL), child, \
child = device_get_next_child_node(dev, child))
void *device_get_next_child_node(struct device *dev, void *child)
{
if (IS_ENABLED(CONFIG_OF) && dev->of_node)
return of_get_next_child(dev->of_node, child);
else if (IS_ENABLED(CONFIG_ACPI) && ...)
return acpi_get_next_child(dev, child);
return NULL;
}
Not any more code than what we have today for the DT-only case, and it's
really just a function call in a loop.
Arnd
next prev parent reply other threads:[~2014-10-02 7:46 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:52 [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 01/16] ACPI: Add support for device specific properties Mika Westerberg
2014-10-06 13:50 ` Grant Likely
2014-10-06 14:32 ` Mika Westerberg
2014-10-06 16:25 ` Darren Hart
2014-09-16 11:52 ` [RFC PATCH v2 02/16] Driver core: Unified device properties interface for platform firmware Mika Westerberg
2014-09-17 18:28 ` Greg Kroah-Hartman
2014-09-16 11:52 ` [RFC PATCH v2 03/16] ACPI: Allow drivers to match using Device Tree compatible property Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 04/16] ACPI: Document ACPI device specific properties Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 05/16] mfd: Add ACPI support Mika Westerberg
2014-09-16 21:54 ` Lee Jones
2014-09-24 12:00 ` Lee Jones
2014-09-16 11:52 ` [RFC PATCH v2 06/16] gpio / ACPI: Add support for _DSD device properties Mika Westerberg
2014-09-23 15:27 ` Linus Walleij
2014-09-16 11:52 ` [RFC PATCH v2 07/16] gpio: Add support for unified device properties interface Mika Westerberg
2014-09-23 15:25 ` Linus Walleij
2014-09-23 15:45 ` Arnd Bergmann
2014-09-23 15:52 ` Mika Westerberg
2014-09-23 16:17 ` Dmitry Torokhov
2014-09-23 20:31 ` Rafael J. Wysocki
2014-09-23 16:25 ` Rafael J. Wysocki
2014-09-23 16:26 ` Arnd Bergmann
2014-09-23 20:47 ` Rafael J. Wysocki
2014-09-24 7:55 ` Arnd Bergmann
2014-09-24 14:08 ` Rafael J. Wysocki
2014-09-23 21:15 ` Darren Hart
2014-09-24 9:12 ` Arnd Bergmann
2014-09-24 9:38 ` Mika Westerberg
2014-09-24 14:11 ` Rafael J. Wysocki
2014-09-26 3:21 ` Darren Hart
2014-09-26 8:36 ` Arnd Bergmann
2014-09-26 14:42 ` Rafael J. Wysocki
2014-10-07 13:37 ` Linus Walleij
2014-10-07 15:37 ` Andy Shevchenko
2014-10-07 23:57 ` Rafael J. Wysocki
2014-09-16 11:52 ` [RFC PATCH v2 08/16] gpio: sch: Consolidate core and resume banks Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 09/16] leds: leds-gpio: Add support for GPIO descriptors Mika Westerberg
2014-09-19 8:18 ` Alexandre Courbot
2014-09-24 7:55 ` Linus Walleij
2014-09-24 9:42 ` Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 10/16] leds: leds-gpio: Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 11/16] leds: leds-gpio: Add ACPI probing support Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 12/16] input: gpio_keys_polled - Add support for GPIO descriptors Mika Westerberg
2014-09-19 8:22 ` Alexandre Courbot
2014-09-24 8:02 ` Linus Walleij
2014-09-16 11:52 ` [RFC PATCH v2 13/16] input: gpio_keys_polled - Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 14/16] input: gpio_keys_polled - Add ACPI probing support Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 15/16] misc: at25: Make use of device property API Mika Westerberg
2014-09-16 11:52 ` [RFC PATCH v2 16/16] misc: at25: Add ACPI probing support Mika Westerberg
2014-09-21 0:26 ` [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support Rafael J. Wysocki
2014-09-24 8:34 ` Lee Jones
2014-09-24 9:45 ` Mika Westerberg
2014-09-22 23:29 ` Bryan Wu
2014-10-01 2:08 ` [PATCH v3 00/15] " Rafael J. Wysocki
2014-10-01 2:08 ` [PATCH v3 01/15] ACPI: Add support for device specific properties Rafael J. Wysocki
2014-10-01 7:38 ` Arnd Bergmann
2014-10-01 2:10 ` [PATCH v3 02/15] Driver core: Unified device properties interface for platform firmware Rafael J. Wysocki
2014-10-01 7:47 ` Arnd Bergmann
2014-10-01 22:09 ` Rafael J. Wysocki
2014-10-01 23:01 ` Rafael J. Wysocki
2014-10-02 7:46 ` Arnd Bergmann [this message]
2014-10-02 16:50 ` Rafael J. Wysocki
2014-10-02 0:03 ` Greg Kroah-Hartman
2014-10-01 2:10 ` [PATCH v3 03/15] ACPI: Allow drivers to match using Device Tree compatible property Rafael J. Wysocki
2014-10-01 7:48 ` Arnd Bergmann
2014-10-03 13:43 ` Mark Rutland
2014-10-03 17:59 ` Dmitry Torokhov
2014-10-04 0:02 ` Rafael J. Wysocki
2014-10-01 2:11 ` [PATCH v3 04/15] ACPI: Document ACPI device specific properties Rafael J. Wysocki
2014-10-01 7:59 ` Arnd Bergmann
2014-10-02 10:41 ` Mika Westerberg
2014-10-02 11:51 ` Arnd Bergmann
2014-10-02 12:15 ` Mika Westerberg
2014-10-02 12:46 ` Arnd Bergmann
2014-10-02 13:36 ` Mika Westerberg
2014-10-02 14:29 ` Arnd Bergmann
2014-10-02 14:38 ` Mika Westerberg
2014-10-02 14:55 ` Arnd Bergmann
2014-10-03 13:56 ` Mark Rutland
2014-10-03 15:02 ` Arnd Bergmann
2014-10-03 23:58 ` Rafael J. Wysocki
2014-10-04 10:56 ` Arnd Bergmann
2014-10-05 21:40 ` Rafael J. Wysocki
2014-10-03 2:03 ` Rafael J. Wysocki
2014-10-03 8:12 ` Mika Westerberg
2014-10-03 13:58 ` Mark Rutland
2014-10-03 14:38 ` Rafael J. Wysocki
2014-10-03 14:35 ` Mark Rutland
2014-10-04 0:13 ` Rafael J. Wysocki
2014-10-04 10:59 ` Arnd Bergmann
2014-10-05 22:26 ` Rafael J. Wysocki
2014-10-03 13:48 ` Mark Rutland
2014-10-04 0:16 ` Rafael J. Wysocki
2014-10-01 2:12 ` [PATCH v3 05/15] gpio / ACPI: Add support for _DSD device properties Rafael J. Wysocki
2014-10-01 8:03 ` Arnd Bergmann
2014-10-05 10:36 ` Alexandre Courbot
2014-10-05 21:20 ` Rafael J. Wysocki
2014-10-01 2:14 ` [PATCH v3 06/15] gpio: Support for unified device properties interface Rafael J. Wysocki
2014-10-01 2:15 ` [PATCH v3 07/15] gpio: sch: Consolidate core and resume banks Rafael J. Wysocki
2014-10-01 2:15 ` [PATCH v3 08/15] leds: leds-gpio: Add support for GPIO descriptors Rafael J. Wysocki
2014-10-01 8:05 ` Arnd Bergmann
2014-10-01 2:16 ` [PATCH v3 09/15] leds: leds-gpio: Make use of device property API Rafael J. Wysocki
2014-10-03 14:07 ` Mark Rutland
2014-10-04 0:18 ` Rafael J. Wysocki
2014-10-01 2:17 ` [PATCH v3 10/15] leds: leds-gpio: Add ACPI probing support Rafael J. Wysocki
2014-10-01 8:13 ` Arnd Bergmann
2014-10-01 9:13 ` Mika Westerberg
2014-10-01 10:01 ` Arnd Bergmann
2014-10-01 11:59 ` Mika Westerberg
2014-10-01 13:52 ` Arnd Bergmann
2014-10-01 14:04 ` Mika Westerberg
2014-10-01 14:14 ` Arnd Bergmann
2014-10-02 9:55 ` Mika Westerberg
2014-10-02 10:44 ` Arnd Bergmann
2014-10-01 16:30 ` Dmitry Torokhov
2014-10-01 18:11 ` Darren Hart
2014-10-01 18:21 ` Dmitry Torokhov
2014-10-01 18:22 ` Arnd Bergmann
2014-10-01 2:17 ` [PATCH v3 11/15] input: gpio_keys_polled - Add support for GPIO descriptors Rafael J. Wysocki
2014-10-01 8:13 ` Arnd Bergmann
2014-10-01 2:20 ` [PATCH v3 12/15] input: gpio_keys_polled - Make use of device property API Rafael J. Wysocki
2014-10-01 2:20 ` [PATCH v3 13/15] input: gpio_keys_polled - Add ACPI probing support Rafael J. Wysocki
2014-10-01 7:48 ` Dmitry Torokhov
2014-10-01 9:15 ` Mika Westerberg
2014-10-01 16:28 ` Dmitry Torokhov
2014-10-02 9:53 ` Mika Westerberg
2014-10-01 2:21 ` [PATCH v3 14/15] misc: at25: Make use of device property API Rafael J. Wysocki
2014-10-01 8:14 ` Arnd Bergmann
2014-10-01 2:22 ` [PATCH v3 15/15] misc: at25: Add ACPI probing support Rafael J. Wysocki
2014-10-01 8:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6092163.dWXI6rWTCu@wuerfel \
--to=arnd@arndb.de \
--cc=aaron.lu@intel.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).