From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <pavel@ucw.cz>, <robh+dt@kernel.org>,
<sven.schwermer@disruptive-technologies.com>,
<krzysztof.kozlowski+dt@linaro.org>, <johan+linaro@kernel.org>,
<marijn.suijten@somainline.org>, <bjorn.andersson@linaro.org>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sha@pengutronix.de>
Subject: Re: [RESEND PATCH v3 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs
Date: Fri, 7 Oct 2022 14:03:37 +0200 [thread overview]
Message-ID: <60fcb1ba-f5d4-deaf-d251-7d8c127c353b@traphandler.com> (raw)
In-Reply-To: <CAHp75VePiAs_qz2fxAheoGbq4wk39x5uoVUKZdbN254RDevgsQ@mail.gmail.com>
On 07/10/2022 10:53, Andy Shevchenko wrote:
> On Fri, Oct 7, 2022 at 9:34 AM Jean-Jacques Hiblot
> <jjhiblot@traphandler.com> wrote:
>> On 17/09/2022 10:37, Andy Shevchenko wrote:
>>> On Sat, Sep 17, 2022 at 11:14 AM Jean-Jacques Hiblot
>>> <jjhiblot@traphandler.com> wrote:
> ...
>
>>>> + led_cdev = devm_of_led_get(dev, count);
>>> Why _of_ variant? Please, make this OF independent since it's
>>> pretending to cover not only OF-based systems.
>> This is not OF independent. It could be, but that will wait until
>> someone needs it. I don't know much about ACPI and have no hardware to
>> test it on.
>>
>> I'll add the missing dependency on OF in the Kconfig.
> No, please consider getting rid of OF-centric API usage.
The trouble is that the OF-agnostic API for leds doesn't exist yet and I
don't really want to add it without any way to test it.
>
> ...
>
> I'm not sure why you left a lot of context in the reply without
> commenting or replying to it.
>
next prev parent reply other threads:[~2022-10-07 12:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 8:13 [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2022-09-17 8:13 ` [RESEND PATCH v3 1/4] leds: class: simplify the implementation of devm_of_led_get() Jean-Jacques Hiblot
2022-09-17 8:23 ` Andy Shevchenko
2022-09-17 8:13 ` [RESEND PATCH v3 2/4] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2022-09-17 8:40 ` Andy Shevchenko
2022-10-07 6:29 ` Jean-Jacques Hiblot
2022-09-18 11:25 ` Jacek Anaszewski
2022-09-18 13:19 ` Jacek Anaszewski
2022-09-17 8:13 ` [RESEND PATCH v3 3/4] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2022-09-17 8:13 ` [RESEND PATCH v3 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2022-09-17 8:37 ` Andy Shevchenko
2022-10-07 6:34 ` Jean-Jacques Hiblot
2022-10-07 8:53 ` Andy Shevchenko
2022-10-07 12:03 ` Jean-Jacques Hiblot [this message]
2022-10-07 13:14 ` Andy Shevchenko
2022-09-18 14:54 ` Jacek Anaszewski
2022-10-07 6:46 ` Jean-Jacques Hiblot
2022-09-17 8:25 ` [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60fcb1ba-f5d4-deaf-d251-7d8c127c353b@traphandler.com \
--to=jjhiblot@traphandler.com \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sha@pengutronix.de \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).