From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: pavel@ucw.cz, robh+dt@kernel.org,
sven.schwermer@disruptive-technologies.com,
krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org,
marijn.suijten@somainline.org, bjorn.andersson@linaro.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sha@pengutronix.de
Subject: Re: [RESEND PATCH v3 2/4] leds: class: store the color index in struct led_classdev
Date: Sat, 17 Sep 2022 11:40:12 +0300 [thread overview]
Message-ID: <CAHp75VdpizVEuWeOpzgizbYRy74b2c7Egx7Qwna=by6rW5Zo1Q@mail.gmail.com> (raw)
In-Reply-To: <20220917081339.3354075-3-jjhiblot@traphandler.com>
On Sat, Sep 17, 2022 at 11:14 AM Jean-Jacques Hiblot
<jjhiblot@traphandler.com> wrote:
>
> This information might be useful for more than only deriving the led's
...
> + if (fwnode_property_present(init_data->fwnode, "color"))
> + fwnode_property_read_u32(init_data->fwnode, "color",
> + &led_cdev->color);
Is it already described in the schema?
...
> unsigned int brightness;
> unsigned int max_brightness;
> + unsigned int color;
The above two are exposed via sysfs, do you need to expose a new one
as well? (Just a question, I am not taking any side here, want to hear
explanation of the either choice)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-17 8:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 8:13 [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2022-09-17 8:13 ` [RESEND PATCH v3 1/4] leds: class: simplify the implementation of devm_of_led_get() Jean-Jacques Hiblot
2022-09-17 8:23 ` Andy Shevchenko
2022-09-17 8:13 ` [RESEND PATCH v3 2/4] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2022-09-17 8:40 ` Andy Shevchenko [this message]
2022-10-07 6:29 ` Jean-Jacques Hiblot
2022-09-18 11:25 ` Jacek Anaszewski
2022-09-18 13:19 ` Jacek Anaszewski
2022-09-17 8:13 ` [RESEND PATCH v3 3/4] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2022-09-17 8:13 ` [RESEND PATCH v3 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2022-09-17 8:37 ` Andy Shevchenko
2022-10-07 6:34 ` Jean-Jacques Hiblot
2022-10-07 8:53 ` Andy Shevchenko
2022-10-07 12:03 ` Jean-Jacques Hiblot
2022-10-07 13:14 ` Andy Shevchenko
2022-09-18 14:54 ` Jacek Anaszewski
2022-10-07 6:46 ` Jean-Jacques Hiblot
2022-09-17 8:25 ` [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdpizVEuWeOpzgizbYRy74b2c7Egx7Qwna=by6rW5Zo1Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jjhiblot@traphandler.com \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sha@pengutronix.de \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).