Re: [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of monochromatic LEDs

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: pavel@ucw.cz, robh+dt@kernel.org,
	sven.schwermer@disruptive-technologies.com,
	krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org,
	marijn.suijten@somainline.org, bjorn.andersson@linaro.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sha@pengutronix.de
Subject: Re: [RESEND PATCH v3 0/4] Add a multicolor LED driver for groups of monochromatic LEDs
Date: Sat, 17 Sep 2022 11:25:05 +0300	[thread overview]
Message-ID: <CAHp75VcpgVyAmzZ4hRXgUKN9vjbO-5yaJS0V28ZfSwJ7qwqxkg@mail.gmail.com> (raw)
In-Reply-To: <20220917081339.3354075-1-jjhiblot@traphandler.com>

On Sat, Sep 17, 2022 at 11:14 AM Jean-Jacques Hiblot
<jjhiblot@traphandler.com> wrote:
>
> Hi,
>
> Resending this series with only a minor modification in the binding
> example after the comments from Sascha Hauer.

I would suggest to Cc a new version (if required a new version) to
Lee. It was a discussion about advancing the LED subsystem patch queue
with his help.

> Original v3 message:
>
> Some HW design implement multicolor LEDs with several monochromatic LEDs.
> Grouping the monochromatic LEDs allows to configure them in sync and use
> the triggers.
> The PWM multicolor LED driver implements such grouping but only for
> PWM-based LEDs. As this feature is also desirable for the other types of
> LEDs, this series implements it for any kind of LED device.
>
> changes v2->v3, only minor changes:
>  - rephrased the Kconfig descritpion
>  - make the sysfs interface of underlying LEDs read-only only if the probe
>    is successful.
>  - sanitize the header files
>  - removed the useless call to dev_set_drvdata()
>  - use dev_fwnode() to get the fwnode to the device.
>
> changes v1->v2:
>  - Followed Rob Herrings's suggestion to make the dt binding much simpler.
>  - Added a patch to store the color property of a LED in its class
>    structure (struct led_classdev).
>
> Jean-Jacques Hiblot (4):
>   leds: class: simplify the implementation of devm_of_led_get()
>   leds: class: store the color index in struct led_classdev
>   dt-bindings: leds: Add binding for a multicolor group of LEDs
>   leds: Add a multicolor LED driver to group monochromatic LEDs
>
>  .../bindings/leds/leds-group-multicolor.yaml  |  64 ++++++++
>  drivers/leds/led-class.c                      |  27 ++--
>  drivers/leds/rgb/Kconfig                      |   6 +
>  drivers/leds/rgb/Makefile                     |   1 +
>  drivers/leds/rgb/leds-group-multicolor.c      | 153 ++++++++++++++++++
>  include/linux/leds.h                          |   1 +
>  6 files changed, 238 insertions(+), 14 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
>  create mode 100644 drivers/leds/rgb/leds-group-multicolor.c
>
> --
> 2.25.1
>

-- 
With Best Regards,
Andy Shevchenko