[PATCH] dmaengine: at_hdmac: remove unused function

[PATCH] dmaengine: at_hdmac: remove unused function

[Olof Johansson]

commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
refactored some code which resulted in an unused function in the at_hdmac
driver:

drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
    not used [-Wunused-function]

Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---

Dan,

Looks like you fixed up the DesignWare driver for the same issue but
this needs it to.

 drivers/dma/at_hdmac_regs.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index f31d647acdfa..2787aba60c6b 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
 {
 	return &chan->dev->device;
 }
-static struct device *chan2parent(struct dma_chan *chan)
-{
-	return chan->dev->device.parent;
-}
 
 #if defined(VERBOSE_DEBUG)
 static void vdbg_dump_regs(struct at_dma_chan *atchan)
-- 
1.8.4.1.601.g02b3b1d

Re: [PATCH] dmaengine: at_hdmac: remove unused function

[Nicolas Ferre]

On 26/11/2013 19:43, Olof Johansson :
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
>
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
>      not used [-Wunused-function]
>
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Indeed,

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks Olof for having taken care of this.

Bye,

> ---
>
> Dan,
>
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
>
>   drivers/dma/at_hdmac_regs.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
>   {
>   	return &chan->dev->device;
>   }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> -	return chan->dev->device.parent;
> -}
>
>   #if defined(VERBOSE_DEBUG)
>   static void vdbg_dump_regs(struct at_dma_chan *atchan)
>


-- 
Nicolas Ferre

Re: [PATCH] dmaengine: at_hdmac: remove unused function

[Bartlomiej Zolnierkiewicz]

Hi Olof,

On Tuesday, November 26, 2013 10:43:35 AM Olof Johansson wrote:
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
> 
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
>     not used [-Wunused-function]
> 
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Thanks for catching and fixing this.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> 
> Dan,
> 
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
> 
>  drivers/dma/at_hdmac_regs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
>  {
>  	return &chan->dev->device;
>  }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> -	return chan->dev->device.parent;
> -}
>  
>  #if defined(VERBOSE_DEBUG)
>  static void vdbg_dump_regs(struct at_dma_chan *atchan)

Re: [PATCH] dmaengine: at_hdmac: remove unused function

[Vinod Koul]

On Tue, Nov 26, 2013 at 10:43:35AM -0800, Olof Johansson wrote:
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
> 
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
>     not used [-Wunused-function]
> 
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Vinod Koul <vinod.koul@Intel.com>

> ---
> 
> Dan,
> 
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
> 
>  drivers/dma/at_hdmac_regs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
>  {
>  	return &chan->dev->device;
>  }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> -	return chan->dev->device.parent;
> -}
>  
>  #if defined(VERBOSE_DEBUG)
>  static void vdbg_dump_regs(struct at_dma_chan *atchan)
> -- 
> 1.8.4.1.601.g02b3b1d
> 
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--