From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sm8250: remove address cells from dsi nodes
Date: Mon, 28 Mar 2022 17:54:07 +0200 [thread overview]
Message-ID: <6325adb9-82f7-e1c0-6293-d91b23362f25@linaro.org> (raw)
In-Reply-To: <20220328143035.519909-7-vkoul@kernel.org>
On 28/03/2022 16:30, Vinod Koul wrote:
> The child of dsi nodes do not have unit address, this causes warnings:
>
> arch/arm64/boot/dts/qcom/sm8250.dtsi:3249.22-3301.6:
> Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae94000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> arch/arm64/boot/dts/qcom/sm8250.dtsi:3322.22-3374.6:
> Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae96000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> So remove #address-cells/#size-cells for dsi nodes.
I think this needs different fix and my review was not correct. MIPI DSI
is a bus, so it can have children with unit addresses.
This DTSI (and several others) should have address/size cells, so
downstream could add easily children (e.g. panel nodes).
However I don't know how to combine it with "ports" not having unit address.
Maybe Rob has some ideas?
Best regards,
Krzysztof
prev parent reply other threads:[~2022-03-28 15:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 14:30 [PATCH 0/6] arm64: dts: qcom: Get rid of some warnings Vinod Koul
2022-03-28 14:30 ` [PATCH 1/6] arm64: dts: qcom: sm8450: rename interconnect nodes Vinod Koul
2022-03-28 15:07 ` Krzysztof Kozlowski
2022-03-28 17:11 ` Vinod Koul
2022-03-28 14:30 ` [PATCH 2/6] arm64: dts: qcom: sm8350: move qup-opp-tables out of soc node Vinod Koul
2022-03-28 15:08 ` Krzysztof Kozlowski
2022-03-28 14:30 ` [PATCH 3/6] arm64: dts: qcom: sm8250: move qup-opp-table " Vinod Koul
2022-03-28 15:08 ` Krzysztof Kozlowski
2022-03-28 14:30 ` [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc Vinod Koul
2022-03-28 15:14 ` Krzysztof Kozlowski
2022-03-28 17:14 ` Vinod Koul
2022-03-28 17:16 ` Krzysztof Kozlowski
2022-04-09 0:25 ` Bjorn Andersson
2022-03-28 14:30 ` [PATCH 5/6] arm64: dts: qcom: sm8250: move wcd938x node out of soc node Vinod Koul
2022-03-28 15:21 ` Krzysztof Kozlowski
2022-03-28 17:13 ` Vinod Koul
2022-03-29 8:44 ` Srinivas Kandagatla
2022-03-28 14:30 ` [PATCH 6/6] arm64: dts: qcom: sm8250: remove address cells from dsi nodes Vinod Koul
2022-03-28 15:31 ` Krzysztof Kozlowski
2022-03-28 15:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6325adb9-82f7-e1c0-6293-d91b23362f25@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).