linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8450: rename interconnect nodes
Date: Mon, 28 Mar 2022 22:41:18 +0530	[thread overview]
Message-ID: <YkHsNtF8oGqE0g2i@matsya> (raw)
In-Reply-To: <784aa271-5c95-3675-07e1-25b495d9eb80@linaro.org>

On 28-03-22, 17:07, Krzysztof Kozlowski wrote:
> On 28/03/2022 16:30, Vinod Koul wrote:
> > clk-virt and mc-virt interconnect nodes were named interconnect@0 and
> > interconnect@1. That is incorrect as we don't have unit addresses 0/1
> > for these node.
> > 
> > This causes warning:
> > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
> > 	Warning (unit_address_vs_reg): /interconnect@0:
> > 	node has a unit name, but no reg or ranges property
> > arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4:
> > 	Warning (unit_address_vs_reg): /interconnect@1:
> > 	node has a unit name, but no reg or ranges property
> > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
> > 	Warning (unique_unit_address_if_enabled): /interconnect@0:
> > 	duplicate unit-address (also used in node /soc@0)
> > 
> > Rename the nodes to interconnect-0 and interconnect-1 to fix the
> > warning.
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> The DT schema will still need to be fixed because it expects 'reg' address.

Yes will update that as well..

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks

-- 
~Vinod

  reply	other threads:[~2022-03-28 17:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 14:30 [PATCH 0/6] arm64: dts: qcom: Get rid of some warnings Vinod Koul
2022-03-28 14:30 ` [PATCH 1/6] arm64: dts: qcom: sm8450: rename interconnect nodes Vinod Koul
2022-03-28 15:07   ` Krzysztof Kozlowski
2022-03-28 17:11     ` Vinod Koul [this message]
2022-03-28 14:30 ` [PATCH 2/6] arm64: dts: qcom: sm8350: move qup-opp-tables out of soc node Vinod Koul
2022-03-28 15:08   ` Krzysztof Kozlowski
2022-03-28 14:30 ` [PATCH 3/6] arm64: dts: qcom: sm8250: move qup-opp-table " Vinod Koul
2022-03-28 15:08   ` Krzysztof Kozlowski
2022-03-28 14:30 ` [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc Vinod Koul
2022-03-28 15:14   ` Krzysztof Kozlowski
2022-03-28 17:14     ` Vinod Koul
2022-03-28 17:16       ` Krzysztof Kozlowski
2022-04-09  0:25       ` Bjorn Andersson
2022-03-28 14:30 ` [PATCH 5/6] arm64: dts: qcom: sm8250: move wcd938x node out of soc node Vinod Koul
2022-03-28 15:21   ` Krzysztof Kozlowski
2022-03-28 17:13     ` Vinod Koul
2022-03-29  8:44       ` Srinivas Kandagatla
2022-03-28 14:30 ` [PATCH 6/6] arm64: dts: qcom: sm8250: remove address cells from dsi nodes Vinod Koul
2022-03-28 15:31   ` Krzysztof Kozlowski
2022-03-28 15:54   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkHsNtF8oGqE0g2i@matsya \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).