From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Mastan.Katragadda@amd.com,
Arungopal.kondaveeti@amd.com, mario.limonciello@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 6/9] ASoC: amd: ps: add pm ops support for SoundWire dma driver
Date: Tue, 23 May 2023 10:03:15 -0500 [thread overview]
Message-ID: <64948d51-dc5d-adb7-4929-74a827a004a2@linux.intel.com> (raw)
In-Reply-To: <f69b31e4-79f0-b7f5-097b-0e11699867b9@amd.com>
>>> @@ -464,16 +488,79 @@ static int acp63_sdw_platform_probe(struct platform_device *pdev)
>>> status = devm_snd_soc_register_component(&pdev->dev,
>>> &acp63_sdw_component,
>>> NULL, 0);
>>> - if (status)
>>> + if (status) {
>>> dev_err(&pdev->dev, "Fail to register sdw dma component\n");
>>> + return status;
>>> + }
>>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
>>> + pm_runtime_use_autosuspend(&pdev->dev);
>>> + pm_runtime_enable(&pdev->dev);
>>> + pm_runtime_allow(&pdev->dev);
>> Can you remind me why you need the pm_runtime_allow()? I can't recall
>> where the _forbid() is done.
> We have used pm_runtime_allow() to allow the device immediately
> enter runtime suspend state. Yes you are correct. If we use pm_runtime_allow(),
> then in remove sequence we should use pm_runtime_forbid call.
>> Also is there not a pm_runtime_set_active() missing?
>
>
> We will change the sequence as mentioned below.
>
> in probe sequence , we will use
>
> pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_mark_last_busy(&pdev->dev);
> pm_runtime_set_active(&pdev->dev);
> pm_runtime_enable(&pdev->dev);
>
> In remove sequence
>
> pm_runtime_disable(&pdev->dev);
sounds about right.
>>
>>> + return 0;
>>> +}
>>>
>>> - return status;
>>> +static int acp63_sdw_platform_remove(struct platform_device *pdev)
>>> +{
>>> + pm_runtime_disable(&pdev->dev);
>>> + return 0;
>>> }
>>>
>>> +static int __maybe_unused acp63_sdw_pcm_resume(struct device *dev)
>>> +{
>>> + struct sdw_dma_dev_data *sdw_data;
>>> + struct acp_sdw_dma_stream *stream;
>>> + struct snd_pcm_runtime *runtime;
>>> + u32 period_bytes, buf_size, water_mark_size_reg;
>>> + int ret;
>>> + int index;
>>> +
>>> + sdw_data = dev_get_drvdata(dev);
>>> + for (index = 0; index < ACP63_SDW0_DMA_MAX_STREAMS; index++) {
>>> + if (sdw_data->sdw0_dma_stream[index] &&
>>> + sdw_data->sdw0_dma_stream[index]->runtime) {
>>> + water_mark_size_reg = sdw0_dma_ring_buf_reg[index].water_mark_size_reg;
>>> + runtime = sdw_data->sdw0_dma_stream[index]->runtime;
>>> + stream = runtime->private_data;
>>> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
>>> + buf_size = frames_to_bytes(runtime, runtime->buffer_size);
>>> + acp63_config_dma(stream, sdw_data->acp_base, index);
>>> + ret = acp63_configure_sdw_ringbuffer(sdw_data->acp_base, index,
>>> + buf_size, ACP_SDW0);
>>> + if (ret)
>>> + return ret;
>>> + writel(period_bytes, sdw_data->acp_base + water_mark_size_reg);
>>> + }
>>> + }
>>> + for (index = 0; index < ACP63_SDW1_DMA_MAX_STREAMS; index++) {
>>> + if (sdw_data->sdw1_dma_stream[index] &&
>>> + sdw_data->sdw1_dma_stream[index]->runtime) {
>>> + water_mark_size_reg = sdw1_dma_ring_buf_reg[index].water_mark_size_reg;
>>> + runtime = sdw_data->sdw1_dma_stream[index]->runtime;
>>> + stream = runtime->private_data;
>>> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
>>> + buf_size = frames_to_bytes(runtime, runtime->buffer_size);
>>> + acp63_config_dma(stream, sdw_data->acp_base, index);
>>> + ret = acp63_configure_sdw_ringbuffer(sdw_data->acp_base, index,
>>> + buf_size, ACP_SDW1);
>>> + if (ret)
>>> + return ret;
>>> + writel(period_bytes, sdw_data->acp_base + water_mark_size_reg);
>>> + }
>>> + }
>> Isn't this set of configurations something that needs to be done already
>> somewhere else, i.e. could there be a common helper?
> In hw_params() callback, we are setting period_bytes and buf_size from
> params structure. We are extracting same variables from runtime structures
> in resume() callback.
> We can implement a helper function to further simplify above logic
> instead of having two separate loops.
ok
next prev parent reply other threads:[~2023-05-23 18:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230522133122.166841-1-Vijendar.Mukunda@amd.com>
2023-05-22 13:31 ` [PATCH V2 1/9] ASoC: amd: ps: create platform devices based on acp config Vijendar Mukunda
2023-05-22 16:16 ` Pierre-Louis Bossart
2023-05-23 6:25 ` Mukunda,Vijendar
2023-05-23 14:29 ` Pierre-Louis Bossart
2023-05-24 7:02 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 2/9] ASoC: amd: ps: handle SoundWire interrupts in acp pci driver Vijendar Mukunda
2023-05-22 16:26 ` Pierre-Louis Bossart
2023-05-23 6:49 ` Mukunda,Vijendar
2023-05-23 14:34 ` Pierre-Louis Bossart
2023-05-24 7:01 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 3/9] ASoC: amd: ps: add SoundWire dma driver Vijendar Mukunda
2023-05-22 16:34 ` Pierre-Louis Bossart
2023-05-23 7:11 ` Mukunda,Vijendar
2023-05-23 14:48 ` Pierre-Louis Bossart
2023-05-24 11:37 ` Mukunda,Vijendar
2023-05-25 11:43 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 4/9] ASoC: amd: ps: add SoundWire dma driver dma ops Vijendar Mukunda
2023-05-22 16:39 ` Pierre-Louis Bossart
2023-05-23 5:41 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 5/9] ASoC: amd: ps: add support for SoundWire DMA interrupts Vijendar Mukunda
2023-05-22 18:12 ` Pierre-Louis Bossart
2023-05-23 7:36 ` Mukunda,Vijendar
2023-05-23 15:00 ` Pierre-Louis Bossart
2023-05-24 7:45 ` Mukunda,Vijendar
2023-05-31 7:28 ` Mukunda,Vijendar
2023-05-31 13:53 ` Pierre-Louis Bossart
2023-06-05 11:24 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 6/9] ASoC: amd: ps: add pm ops support for SoundWire dma driver Vijendar Mukunda
2023-05-22 18:20 ` Pierre-Louis Bossart
2023-05-23 10:53 ` Mukunda,Vijendar
2023-05-23 15:03 ` Pierre-Louis Bossart [this message]
2023-05-22 13:31 ` [PATCH V2 7/9] ASoC: amd: ps: enable SoundWire dma driver build Vijendar Mukunda
2023-05-22 13:31 ` [PATCH V2 8/9] ASoC: amd: update comments in Kconfig file Vijendar Mukunda
2023-05-22 13:31 ` [PATCH V2 9/9] ASoC: amd: ps: Add SoundWire specific checks in pci driver in pm ops Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64948d51-dc5d-adb7-4929-74a827a004a2@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Arungopal.kondaveeti@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).