From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Mastan.Katragadda@amd.com,
Arungopal.kondaveeti@amd.com, mario.limonciello@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/9] ASoC: amd: ps: create platform devices based on acp config
Date: Tue, 23 May 2023 09:29:34 -0500 [thread overview]
Message-ID: <dd93f315-79ef-5108-0cae-fbfafafb9a12@linux.intel.com> (raw)
In-Reply-To: <a9723614-2ee8-279c-8a95-28535ca47709@amd.com>
>>> +static int get_acp63_device_config(u32 config, struct pci_dev *pci, struct acp63_dev_data *acp_data)
>>> {
>>> struct acpi_device *dmic_dev;
>>> + struct acpi_device *sdw_dev;
>>> const union acpi_object *obj;
>>> bool is_dmic_dev = false;
>> useless init
> We are checking is_dmic_dev & is_sdw_dev flags in same code.
> Either we need to explicitly update value as false when no ACP PDM
> /SoundWire manager instances not found.
please discard my comment, I read this sideways
>>
>>> + bool is_sdw_dev = false;
>> and useless init as well...
same here.
>>
>>> + int ret;
>>>
>>> dmic_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP63_DMIC_ADDR, 0);
>>> if (dmic_dev) {
>>> + /* is_dmic_dev flag will be set when ACP PDM controller device exists */
>>> if (!acpi_dev_get_property(dmic_dev, "acp-audio-device-type",
>>> ACPI_TYPE_INTEGER, &obj) &&
>>> obj->integer.value == ACP_DMIC_DEV)
>>> is_dmic_dev = true;
>>> }
>>>
>>> + sdw_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP63_SDW_ADDR, 0);
>>> + if (sdw_dev) {
>>> + acp_data->sdw_fw_node = acpi_fwnode_handle(sdw_dev);
>>> + ret = sdw_amd_scan_controller(&pci->dev);
>>> + /* is_sdw_dev flag will be set when SoundWire Manager device exists */
>>> + if (!ret)
>>> + is_sdw_dev = true;
>> sdw_amd_scan_controller() can return -EINVAL, how is this handled?
>> Shouldn't you stop execution and return here in the < 0 case?
> As per our design, ACP PCI driver probe should be successful, even
> there are no ACP PDM or Soundwire Manager instance configuration
> related platform devices.
>
> The ACP PCI driver is multi-use and that even if SoundWire manager
> instances or PDM controller is not found, it will still be used to set the
> hardware to proper low power states. i.e ACP should enter D3 state
> after successful execution of probe sequence.
Ah ok, maybe a reworded comment would make sense then, e.g.
"continue probe and discard errors if SoundWire Manager is not described
in ACPI tables"
Same for DMIC above
next prev parent reply other threads:[~2023-05-23 18:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230522133122.166841-1-Vijendar.Mukunda@amd.com>
2023-05-22 13:31 ` [PATCH V2 1/9] ASoC: amd: ps: create platform devices based on acp config Vijendar Mukunda
2023-05-22 16:16 ` Pierre-Louis Bossart
2023-05-23 6:25 ` Mukunda,Vijendar
2023-05-23 14:29 ` Pierre-Louis Bossart [this message]
2023-05-24 7:02 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 2/9] ASoC: amd: ps: handle SoundWire interrupts in acp pci driver Vijendar Mukunda
2023-05-22 16:26 ` Pierre-Louis Bossart
2023-05-23 6:49 ` Mukunda,Vijendar
2023-05-23 14:34 ` Pierre-Louis Bossart
2023-05-24 7:01 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 3/9] ASoC: amd: ps: add SoundWire dma driver Vijendar Mukunda
2023-05-22 16:34 ` Pierre-Louis Bossart
2023-05-23 7:11 ` Mukunda,Vijendar
2023-05-23 14:48 ` Pierre-Louis Bossart
2023-05-24 11:37 ` Mukunda,Vijendar
2023-05-25 11:43 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 4/9] ASoC: amd: ps: add SoundWire dma driver dma ops Vijendar Mukunda
2023-05-22 16:39 ` Pierre-Louis Bossart
2023-05-23 5:41 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 5/9] ASoC: amd: ps: add support for SoundWire DMA interrupts Vijendar Mukunda
2023-05-22 18:12 ` Pierre-Louis Bossart
2023-05-23 7:36 ` Mukunda,Vijendar
2023-05-23 15:00 ` Pierre-Louis Bossart
2023-05-24 7:45 ` Mukunda,Vijendar
2023-05-31 7:28 ` Mukunda,Vijendar
2023-05-31 13:53 ` Pierre-Louis Bossart
2023-06-05 11:24 ` Mukunda,Vijendar
2023-05-22 13:31 ` [PATCH V2 6/9] ASoC: amd: ps: add pm ops support for SoundWire dma driver Vijendar Mukunda
2023-05-22 18:20 ` Pierre-Louis Bossart
2023-05-23 10:53 ` Mukunda,Vijendar
2023-05-23 15:03 ` Pierre-Louis Bossart
2023-05-22 13:31 ` [PATCH V2 7/9] ASoC: amd: ps: enable SoundWire dma driver build Vijendar Mukunda
2023-05-22 13:31 ` [PATCH V2 8/9] ASoC: amd: update comments in Kconfig file Vijendar Mukunda
2023-05-22 13:31 ` [PATCH V2 9/9] ASoC: amd: ps: Add SoundWire specific checks in pci driver in pm ops Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd93f315-79ef-5108-0cae-fbfafafb9a12@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Arungopal.kondaveeti@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).