* [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static
@ 2016-09-06 8:11 Baoyou Xie
2016-09-06 9:20 ` Arnd Bergmann
2016-09-06 22:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-06 8:11 UTC (permalink / raw)
To: skhare, pv-drivers; +Cc: netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index c68fe49..fc68dd4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1639,7 +1639,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
}
}
-void
+static void
vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
{
int i;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static
2016-09-06 8:11 [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static Baoyou Xie
@ 2016-09-06 9:20 ` Arnd Bergmann
2016-09-06 22:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-09-06 9:20 UTC (permalink / raw)
To: Baoyou Xie; +Cc: skhare, pv-drivers, netdev, linux-kernel, xie.baoyou
On Tuesday, September 6, 2016 4:11:59 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static
2016-09-06 8:11 [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static Baoyou Xie
2016-09-06 9:20 ` Arnd Bergmann
@ 2016-09-06 22:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-09-06 22:59 UTC (permalink / raw)
To: baoyou.xie; +Cc: skhare, pv-drivers, netdev, linux-kernel, arnd, xie.baoyou
From: Baoyou Xie <baoyou.xie@linaro.org>
Date: Tue, 6 Sep 2016 16:11:59 +0800
> We get 1 warning when building kernel with W=1:
> drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
This doesn't apply cleanly to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-06 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 8:11 [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static Baoyou Xie
2016-09-06 9:20 ` Arnd Bergmann
2016-09-06 22:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).