* Can we just remove the sw_lpm_support from current xhci driver?
@ 2018-10-15 9:35 Zengtao (B)
2018-10-15 12:11 ` Mathias Nyman
0 siblings, 1 reply; 3+ messages in thread
From: Zengtao (B) @ 2018-10-15 9:35 UTC (permalink / raw)
To: mathias.nyman, Greg KH; +Cc: linux-kernel, linux-usb
Hi:
I am recently reading the LPM related code in xhci driver, and I find
that the xhci->sw_lpm_support is not really used, but I am not sure
whether we should remove it or not?
Any ideas, Thanks.
Regards
Zengtao
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can we just remove the sw_lpm_support from current xhci driver?
2018-10-15 9:35 Can we just remove the sw_lpm_support from current xhci driver? Zengtao (B)
@ 2018-10-15 12:11 ` Mathias Nyman
2018-10-16 3:23 ` Zengtao (B)
0 siblings, 1 reply; 3+ messages in thread
From: Mathias Nyman @ 2018-10-15 12:11 UTC (permalink / raw)
To: Zengtao (B), Greg KH; +Cc: linux-kernel, linux-usb
On 15.10.2018 12:35, Zengtao (B) wrote:
> Hi:
>
> I am recently reading the LPM related code in xhci driver, and I find
> that the xhci->sw_lpm_support is not really used, but I am not sure
> whether we should remove it or not?
>
> Any ideas, Thanks.
I think it was used to prevent LPM in pre-0.96 xHC controllers.
Now driver only supports HW LPM for 1.0 and later controllers, so xhci->sw_lpm_support
doesn't really do anything.
You can send a patch removing it
Thanks
-Mathias
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: Can we just remove the sw_lpm_support from current xhci driver?
2018-10-15 12:11 ` Mathias Nyman
@ 2018-10-16 3:23 ` Zengtao (B)
0 siblings, 0 replies; 3+ messages in thread
From: Zengtao (B) @ 2018-10-16 3:23 UTC (permalink / raw)
To: Mathias Nyman, Greg KH; +Cc: linux-kernel, linux-usb
Hi Mathias:
>-----Original Message-----
>From: Mathias Nyman [mailto:mathias.nyman@intel.com]
>Sent: Monday, October 15, 2018 8:11 PM
>To: Zengtao (B) <prime.zeng@hisilicon.com>; Greg KH
><gregkh@linuxfoundation.org>
>Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
>Subject: Re: Can we just remove the sw_lpm_support from current xhci
>driver?
>
>On 15.10.2018 12:35, Zengtao (B) wrote:
>> Hi:
>>
>> I am recently reading the LPM related code in xhci driver, and I find
>> that the xhci->sw_lpm_support is not really used, but I am not sure
>> whether we should remove it or not?
>>
>> Any ideas, Thanks.
>
>I think it was used to prevent LPM in pre-0.96 xHC controllers.
>Now driver only supports HW LPM for 1.0 and later controllers, so
>xhci->sw_lpm_support doesn't really do anything.
>
>You can send a patch removing it
>
Ok, I will send a patch to do it, thanks.
>Thanks
>-Mathias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-16 3:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 9:35 Can we just remove the sw_lpm_support from current xhci driver? Zengtao (B)
2018-10-15 12:11 ` Mathias Nyman
2018-10-16 3:23 ` Zengtao (B)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).