From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bhaumik Vasav Bhatt <bbhatt@codeaurora.org>,
Hemant Kumar <hemantk@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] bus: mhi: core: Handle syserr during power_up
Date: Wed, 22 Apr 2020 14:16:02 -0600 [thread overview]
Message-ID: <6a1c95f1-d7f5-2073-9262-415473986633@codeaurora.org> (raw)
In-Reply-To: <20200421060835.GD4327@Mani-XPS-13-9360>
On 4/21/2020 12:08 AM, Manivannan Sadhasivam wrote:
> On Mon, Apr 13, 2020 at 08:01:36AM -0600, Jeffrey Hugo wrote:
>> On 4/13/2020 7:34 AM, Manivannan Sadhasivam wrote:
>>> On Fri, Apr 10, 2020 at 03:39:57PM -0600, Jeffrey Hugo wrote:
>>>> On 4/10/2020 2:37 PM, Bhaumik Vasav Bhatt wrote:
>>>>> Hi Jeff,
>>>>>
>>>>> We will always have the mhi_intvec_handler registered and trigger your
>>>>> wake_up state event when you write MHI RESET. BHI INTVEC IRQ using
>>>>> mhi_cntrl->irq[0] is _not_ unregistered once you enter AMSS EE.
>>>>
>>>> I understand it is not unregistered. However mhi_cntrl->irq[0] may be
>>>> reserved for BHI, and thus only exercised by PBL EE. Where as,
>>>> mhi_cntrl->irq[1..N] may be only exercised by AMSS EE. mhi_intvec_handler is
>>>> not called in response to mhi_cntrl->irq[1..N].
>>>>
>>>> Additionally, I re-reviewed the MHI spec, and I don't see where the spec
>>>> requires the device to issue an interrupt upon completion of the RESET
>>>> request.
>>>>
>>>> Under section 3.5, step 11 states -
>>>>
>>>> "The host must poll for the value of the RESET bit to detect the completion
>>>> of the reset procedure by the device (RESET is set to 0)."
>>>>
>>>
>>> If this is the scenario then we need to change all of the wait_event_timeout()
>>> implementation for MHI RESET in current stack to polling.
>>>
>>> Or the interrupt generation is not defined in spec (sheet) but part of the
>>> existing implementation?
>>
>> It probably could be considered part of the existing implementation, but I'd
>> like to hear from Hemant/Bhaumik. Wherever we end up, I'd like to have the
>> spec match.
>
> Hemant/Bhaumik, can you please share your thoughts?
Sorry. Hemant, Bhaumik, and I have had a few calls discussing this. We
are trying to come to a consensus on the expectation of the device
behavior, so that we can propose the best solution. Probably a few more
days yet while we await for a bit of clarification.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-04-22 20:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 16:50 [PATCH v2 0/5] Misc MHI fixes Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 1/5] bus: mhi: core: Handle syserr during power_up Jeffrey Hugo
2020-04-10 0:55 ` Hemant Kumar
2020-04-10 15:03 ` Jeffrey Hugo
2020-04-10 20:37 ` Bhaumik Vasav Bhatt
2020-04-10 21:39 ` Jeffrey Hugo
2020-04-13 13:34 ` Manivannan Sadhasivam
2020-04-13 14:01 ` Jeffrey Hugo
2020-04-21 6:08 ` Manivannan Sadhasivam
2020-04-22 20:16 ` Jeffrey Hugo [this message]
2020-04-07 16:50 ` [PATCH v2 2/5] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails Jeffrey Hugo
2020-04-08 1:34 ` hemantk
2020-04-08 16:19 ` Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 3/5] bus: mhi: core: Remove link_status() callback Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 4/5] bus: mhi: core: Offload register accesses to the controller Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 5/5] bus: mhi: core: Fix typo in comment Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1c95f1-d7f5-2073-9262-415473986633@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).