From: hemantk@codeaurora.org
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH v2 2/5] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails
Date: Tue, 07 Apr 2020 18:34:05 -0700 [thread overview]
Message-ID: <7249d9608f41e4528c87c2b1c464d615@codeaurora.org> (raw)
In-Reply-To: <1586278230-29565-3-git-send-email-jhugo@codeaurora.org>
On 2020-04-07 09:50, Jeffrey Hugo wrote:
> Powerdown is necessary if mhi_sync_power_up fails due to a timeout, to
> clean up the resources. Otherwise a BUG could be triggered when
> attempting to clean up MSIs because the IRQ is still active from a
> request_irq().
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> drivers/bus/mhi/core/pm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index 3285c9e..fbffc6b 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -922,7 +922,11 @@ int mhi_sync_power_up(struct mhi_controller
> *mhi_cntrl)
> MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state),
> msecs_to_jiffies(mhi_cntrl->timeout_ms));
>
> - return (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
> + ret = (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
Does it make sense to return -ETIMEDOUT instead of -EIO if device fails
to move to mission mode?
Controller can use this info as mhi_async_power_up() would not return
-ETIMEDOUT.
> + if (ret)
> + mhi_power_down(mhi_cntrl, false);
> +
> + return ret;
> }
> EXPORT_SYMBOL(mhi_sync_power_up);
next prev parent reply other threads:[~2020-04-08 1:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 16:50 [PATCH v2 0/5] Misc MHI fixes Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 1/5] bus: mhi: core: Handle syserr during power_up Jeffrey Hugo
2020-04-10 0:55 ` Hemant Kumar
2020-04-10 15:03 ` Jeffrey Hugo
2020-04-10 20:37 ` Bhaumik Vasav Bhatt
2020-04-10 21:39 ` Jeffrey Hugo
2020-04-13 13:34 ` Manivannan Sadhasivam
2020-04-13 14:01 ` Jeffrey Hugo
2020-04-21 6:08 ` Manivannan Sadhasivam
2020-04-22 20:16 ` Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 2/5] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails Jeffrey Hugo
2020-04-08 1:34 ` hemantk [this message]
2020-04-08 16:19 ` Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 3/5] bus: mhi: core: Remove link_status() callback Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 4/5] bus: mhi: core: Offload register accesses to the controller Jeffrey Hugo
2020-04-07 16:50 ` [PATCH v2 5/5] bus: mhi: core: Fix typo in comment Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7249d9608f41e4528c87c2b1c464d615@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).