* [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211
@ 2020-09-03 14:28 Dafna Hirschfeld
2020-09-04 8:02 ` Enric Balletbo i Serra
0 siblings, 1 reply; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-09-03 14:28 UTC (permalink / raw)
To: linux-kernel, linux-mediatek, linux-arm-kernel, devicetree,
matthias.bgg, robh+dt
Cc: enric.balletbo, kernel, dafna3, Dafna Hirschfeld
According to the datasheet the allowed modes for the da9211
regulator are sync and auto mode. This should be changed in the
devicetree. This also fix an error message
'BUCKA: invalid regulator-allowed-modes element 0'
since value 0 is invalid.
Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 1fe5dac24ba1..1a51879d5c6f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -5,6 +5,7 @@
#include <dt-bindings/input/input.h>
#include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/regulator/dlg,da9211-regulator.h>
#include <dt-bindings/gpio/gpio.h>
#include "mt8173.dtsi"
@@ -293,7 +294,8 @@
regulator-max-microamp = <4400000>;
regulator-ramp-delay = <10000>;
regulator-always-on;
- regulator-allowed-modes = <0 1>;
+ regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
+ DA9211_BUCK_MODE_AUTO>;
};
da9211_vgpu_reg: BUCKB {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211
2020-09-03 14:28 [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211 Dafna Hirschfeld
@ 2020-09-04 8:02 ` Enric Balletbo i Serra
2020-09-09 9:54 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-04 8:02 UTC (permalink / raw)
To: Dafna Hirschfeld, linux-kernel, linux-mediatek, linux-arm-kernel,
devicetree, matthias.bgg, robh+dt
Cc: kernel, dafna3
Hi Dafna,
Thank you to work on this.
On 3/9/20 16:28, Dafna Hirschfeld wrote:
> According to the datasheet the allowed modes for the da9211
> regulator are sync and auto mode. This should be changed in the
> devicetree. This also fix an error message
> 'BUCKA: invalid regulator-allowed-modes element 0'
> since value 0 is invalid.
>
> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Double checked the regulator supported modes and I can confirm that this patch
gets rid of the error message, so:
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 1fe5dac24ba1..1a51879d5c6f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/regulator/dlg,da9211-regulator.h>
> #include <dt-bindings/gpio/gpio.h>
> #include "mt8173.dtsi"
>
> @@ -293,7 +294,8 @@
> regulator-max-microamp = <4400000>;
> regulator-ramp-delay = <10000>;
> regulator-always-on;
> - regulator-allowed-modes = <0 1>;
> + regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
> + DA9211_BUCK_MODE_AUTO>;
> };
>
> da9211_vgpu_reg: BUCKB {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211
2020-09-04 8:02 ` Enric Balletbo i Serra
@ 2020-09-09 9:54 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2020-09-09 9:54 UTC (permalink / raw)
To: Enric Balletbo i Serra, Dafna Hirschfeld, linux-kernel,
linux-mediatek, linux-arm-kernel, devicetree, robh+dt
Cc: kernel, dafna3
On 04/09/2020 10:02, Enric Balletbo i Serra wrote:
> Hi Dafna,
>
> Thank you to work on this.
>
> On 3/9/20 16:28, Dafna Hirschfeld wrote:
>> According to the datasheet the allowed modes for the da9211
>> regulator are sync and auto mode. This should be changed in the
>> devicetree. This also fix an error message
>> 'BUCKA: invalid regulator-allowed-modes element 0'
>> since value 0 is invalid.
>>
>> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>
> Double checked the regulator supported modes and I can confirm that this patch
> gets rid of the error message, so:
>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
Applied to v5.9-next/dts64
Thanks!
>> ---
>> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> index 1fe5dac24ba1..1a51879d5c6f 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> @@ -5,6 +5,7 @@
>>
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/input/linux-event-codes.h>
>> +#include <dt-bindings/regulator/dlg,da9211-regulator.h>
>> #include <dt-bindings/gpio/gpio.h>
>> #include "mt8173.dtsi"
>>
>> @@ -293,7 +294,8 @@
>> regulator-max-microamp = <4400000>;
>> regulator-ramp-delay = <10000>;
>> regulator-always-on;
>> - regulator-allowed-modes = <0 1>;
>> + regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
>> + DA9211_BUCK_MODE_AUTO>;
>> };
>>
>> da9211_vgpu_reg: BUCKB {
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 14:28 [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211 Dafna Hirschfeld
2020-09-04 8:02 ` Enric Balletbo i Serra
2020-09-09 9:54 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).