* [PATCH v2] Enable ADC support for Colibri VF61 modules
@ 2014-09-19 11:26 Sanchayan Maity
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
0 siblings, 1 reply; 5+ messages in thread
From: Sanchayan Maity @ 2014-09-19 11:26 UTC (permalink / raw)
To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Sanchayan Maity
Changes since v1:
Sorted the nodes alphabetically
Initial discussion over here
[1]: https://lkml.org/lkml/2014/9/19/145
Sanchayan Maity (1):
ARM: dts: vf610-colibri: Add ADC support
arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
2014-09-19 11:26 [PATCH v2] Enable ADC support for Colibri VF61 modules Sanchayan Maity
@ 2014-09-19 11:26 ` Sanchayan Maity
2014-09-19 16:22 ` Stefan Agner
2014-09-26 2:07 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Sanchayan Maity @ 2014-09-19 11:26 UTC (permalink / raw)
To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Sanchayan Maity
Enable ADC support for Colibri VF61 modules
Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
---
arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
index 0cd8343..6fd099e 100644
--- a/arch/arm/boot/dts/vf610-colibri.dtsi
+++ b/arch/arm/boot/dts/vf610-colibri.dtsi
@@ -27,6 +27,16 @@
};
+&adc0 {
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&adc1 {
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&esdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_esdhc1>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
@ 2014-09-19 16:22 ` Stefan Agner
2014-09-26 2:07 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Agner @ 2014-09-19 16:22 UTC (permalink / raw)
To: Sanchayan Maity; +Cc: shawn.guo, linux, linux-arm-kernel, linux-kernel
Am 2014-09-19 13:26, schrieb Sanchayan Maity:
> Enable ADC support for Colibri VF61 modules
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi
> b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 0cd8343..6fd099e 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -27,6 +27,16 @@
>
> };
>
> +&adc0 {
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> +&adc1 {
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> &esdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1>;
Acked-By: Stefan Agner <stefan@agner.ch>
--
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
2014-09-19 16:22 ` Stefan Agner
@ 2014-09-26 2:07 ` Shawn Guo
2014-09-26 9:44 ` Sanchayan Maity
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2014-09-26 2:07 UTC (permalink / raw)
To: Sanchayan Maity; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote:
> Enable ADC support for Colibri VF61 modules
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 0cd8343..6fd099e 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -27,6 +27,16 @@
>
> };
>
> +&adc0 {
> + pinctrl-names = "default";
Sorry for missing it, but I would expect properties pinctrl-names and
pinctrl-0 appear as a couple. Should we drop property pinctrl-names
here?
Shawn
> + status = "okay";
> +};
> +
> +&adc1 {
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> &esdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1>;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
2014-09-26 2:07 ` Shawn Guo
@ 2014-09-26 9:44 ` Sanchayan Maity
0 siblings, 0 replies; 5+ messages in thread
From: Sanchayan Maity @ 2014-09-26 9:44 UTC (permalink / raw)
To: Shawn Guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Friday 26 September 2014 07:37 AM, Shawn Guo wrote:
> On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote:
>> Enable ADC support for Colibri VF61 modules
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..6fd099e 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -27,6 +27,16 @@
>>
>> };
>>
>> +&adc0 {
>> + pinctrl-names = "default";
>
> Sorry for missing it, but I would expect properties pinctrl-names and
> pinctrl-0 appear as a couple. Should we drop property pinctrl-names
> here?
>
> Shawn
We can actually drop this here. Vybrid has dedicated pads for 4 ADC channels.
Since we are using only these dedicated ADC channels, no pin multiplexing
is required. So we can drop the pinctrl-names property. Will clean and
send out a v3 patch. Thanks for pointing this out.
- Sanchayan
>
>> + status = "okay";
>> +};
>> +
>> +&adc1 {
>> + pinctrl-names = "default";
>> + status = "okay";
>> +};
>> +
>> &esdhc1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_esdhc1>;
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-26 9:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-19 11:26 [PATCH v2] Enable ADC support for Colibri VF61 modules Sanchayan Maity
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
2014-09-19 16:22 ` Stefan Agner
2014-09-26 2:07 ` Shawn Guo
2014-09-26 9:44 ` Sanchayan Maity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).