linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joshua Kinard <kumba@gentoo.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paul.burton@mips.com>,
	James Hogan <jhogan@kernel.org>,
	"open list:MIPS" <linux-mips@linux-mips.org>
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug
Date: Fri, 30 Nov 2018 20:52:25 -0500	[thread overview]
Message-ID: <7468f626-13c0-a53f-bf02-675c7218dd06@gentoo.org> (raw)
In-Reply-To: <20181130192737.15053-2-jarkko.sakkinen@linux.intel.com>

On 11/30/2018 2:27 PM, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
>  arch/mips/pci/ops-bridge.c      | 24 ++++++++++++------------
>  arch/mips/sgi-ip22/ip22-setup.c |  2 +-
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/mips/pci/ops-bridge.c b/arch/mips/pci/ops-bridge.c
> index a1d2c4ae0d1b..c755c4c92fa9 100644
> --- a/arch/mips/pci/ops-bridge.c
> +++ b/arch/mips/pci/ops-bridge.c
> @@ -56,7 +56,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -76,7 +76,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -85,7 +85,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  	}
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -118,7 +118,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -139,7 +139,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -148,7 +148,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  	}
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	bridge->b_pci_cfg = (busno << 16) | (slot << 11);
> @@ -189,7 +189,7 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -213,14 +213,14 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to touch the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
>  		return PCIBIOS_SUCCESSFUL;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -257,7 +257,7 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -281,14 +281,14 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to touch the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
>  		return PCIBIOS_SUCCESSFUL;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];

[snip]

NAK'ed to all of the proposed changes to ops-bridge.c.  The SGI IOC3 chip is an
abomination out of some dark, Lovecraftian nightmare, and the code comment is,
truthfully, being somewhat nice in its description of things.  They need to
remain as-is as a warning to future generations of how not to design
multifunction/multidevice chipsets.

-- 
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
rsa6144/5C63F4E3F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us.  And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic

  parent reply	other threads:[~2018-12-01  1:52 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com>
2018-11-30 19:27 ` [PATCH RFC 01/15] MIPS: replace **** with a hug Jarkko Sakkinen
2018-11-30 19:57   ` Jarkko Sakkinen
2018-11-30 21:06     ` Nikolay Borisov
2018-11-30 21:50       ` Jarkko Sakkinen
2018-11-30 22:11         ` Nikolay Borisov
2018-11-30 21:13   ` Al Viro
2018-11-30 21:28     ` Randy Dunlap
2018-12-01  1:52   ` Joshua Kinard [this message]
2018-12-01  4:58   ` Mike Galbraith
2018-11-30 19:27 ` [PATCH RFC 02/15] Documentation: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 03/15] drm/nouveau: " Jarkko Sakkinen
2018-11-30 20:13   ` Diego Viola
2018-11-30 21:26     ` Jarkko Sakkinen
2018-11-30 22:03       ` Diego Viola
2018-11-30 19:27 ` [PATCH RFC 04/15] m68k: " Jarkko Sakkinen
2018-11-30 19:44   ` John Paul Adrian Glaubitz
2018-11-30 20:59     ` Jarkko Sakkinen
2018-11-30 21:59       ` Jiri Kosina
2018-11-30 19:27 ` [PATCH RFC 05/15] parisc: " Jarkko Sakkinen
2018-11-30 22:48   ` Dennis Clarke
2018-11-30 23:03     ` Jarkko Sakkinen
2018-11-30 23:05   ` Diego Viola
2018-11-30 19:27 ` [PATCH RFC 06/15] cpufreq: " Jarkko Sakkinen
2018-12-03  9:08   ` Rafael J. Wysocki
2018-11-30 19:27 ` [PATCH RFC 07/15] ide: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 08/15] media: " Jarkko Sakkinen
2018-12-01  8:01   ` Tomasz Figa
2018-11-30 19:27 ` [PATCH RFC 09/15] mtd: " Jarkko Sakkinen
2018-11-30 19:39   ` Boris Brezillon
2018-11-30 20:56     ` Jarkko Sakkinen
2018-12-01 10:31   ` Richard Weinberger
2018-11-30 19:27 ` [PATCH RFC 10/15] net/sunhme: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 11/15] scsi: " Jarkko Sakkinen
2018-11-30 20:21   ` James Bottomley
2018-11-30 21:30     ` Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 12/15] inotify: " Jarkko Sakkinen
2018-12-01  6:40   ` Amir Goldstein
2018-12-05  9:49     ` Jan Kara
2018-11-30 19:27 ` [PATCH RFC 13/15] irq: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 14/15] lib: " Jarkko Sakkinen
2018-11-30 19:41   ` Steven Rostedt
2018-11-30 19:46     ` Jonathan Corbet
2018-11-30 19:49       ` Jiri Kosina
2018-11-30 20:59     ` Jarkko Sakkinen
2018-12-02  3:24       ` Sergey Senozhatsky
2018-12-02 21:34   ` Tobin C. Harding
2018-11-30 19:27 ` [PATCH RFC 15/15] net: " Jarkko Sakkinen
2018-12-03 10:15   ` Phil Sutter
2018-11-30 19:40 ` [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Kees Cook
2018-11-30 19:48   ` Fwd: " Kees Cook
2018-11-30 20:42     ` Aaro Koskinen
2018-11-30 19:56   ` Davidlohr Bueso
2018-11-30 20:12     ` Jens Axboe
2018-11-30 20:34       ` Michael Schmitz
2018-11-30 20:35       ` David Miller
     [not found]         ` <2007856.n5V9iKLVsV@eth7>
2018-11-30 20:42           ` David Miller
     [not found]             ` <2269948.6tYQeUj9R1@eth7>
2018-11-30 20:53               ` Steven Rostedt
2018-11-30 20:43           ` Steven Rostedt
2018-12-01  4:08           ` Jarkko Sakkinen
2018-11-30 21:42         ` Jarkko Sakkinen
2018-11-30 21:47           ` David Miller
2018-11-30 21:53             ` Jens Axboe
2018-11-30 20:34     ` David Miller
2018-11-30 20:55     ` Jarkko Sakkinen
2018-11-30 21:01       ` James Bottomley
2018-11-30 21:44         ` Jarkko Sakkinen
2018-11-30 21:48           ` David Miller
2018-11-30 21:54             ` Jarkko Sakkinen
2018-11-30 22:04               ` James Bottomley
2018-11-30 21:57           ` James Bottomley
2018-11-30 22:12             ` Jarkko Sakkinen
2018-11-30 22:14               ` Jonathan Corbet
2018-11-30 22:26                 ` Jarkko Sakkinen
2018-11-30 22:29                   ` Jarkko Sakkinen
2018-11-30 22:30                   ` James Bottomley
2018-11-30 22:40                     ` Jarkko Sakkinen
2018-11-30 23:28                       ` Jarkko Sakkinen
2018-12-01  8:20                 ` Geert Uytterhoeven
2018-12-07 13:39                   ` Eric Curtin
2018-11-30 22:26               ` James Bottomley
2018-11-30 21:02       ` Steven Rostedt
2018-11-30 21:04       ` Jonathan Corbet
2018-11-30 19:57   ` Geert Uytterhoeven
2018-11-30 21:09     ` Jarkko Sakkinen
2018-11-30 20:09   ` John Paul Adrian Glaubitz
2018-11-30 21:32     ` Jarkko Sakkinen
2018-11-30 20:31   ` Matthias Brugger
2018-11-30 21:34     ` Jarkko Sakkinen
2018-11-30 21:07   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7468f626-13c0-a53f-bf02-675c7218dd06@gentoo.org \
    --to=kumba@gentoo.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).