linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dennis Clarke <dclarke@blastwave.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-parisc@vger.kernel.org,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH RFC 05/15] parisc: replace **** with a hug
Date: Fri, 30 Nov 2018 17:48:33 -0500	[thread overview]
Message-ID: <cc2c08ea-2d9b-4aac-ba98-e7cec57a9cce@blastwave.org> (raw)
In-Reply-To: <20181130192737.15053-6-jarkko.sakkinen@linux.intel.com>

On 11/30/18 2:27 PM, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
> 

To be honest the source has been full of sh!t and other expressions
for a long long time now. I am sure we all know this and it would
take a pile of effort to clean^H^H^H^Hsanitize and ruin the flavour and
ambiance of the whole damn thing.  Everyone knows this :


c $ find . -type f | xargs grep -ic " shit " | grep -v ":0$" | awk 
'BEGIN{FS=":";print "\nshitlist"}{print $2 " " $1}' | sort -n

shitlist
1 ./linux-4.20-rc4/arch/powerpc/kernel/eeh_driver.c
1 ./linux-4.20-rc4/arch/sparc/kernel/pcic.c
1 ./linux-4.20-rc4/arch/sparc/mm/srmmu.c
1 ./linux-4.20-rc4/drivers/ata/sata_via.c
1 ./linux-4.20-rc4/drivers/infiniband/hw/qib/qib_file_ops.c
1 ./linux-4.20-rc4/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
1 ./linux-4.20-rc4/drivers/net/ethernet/sun/sunhme.c
1 ./linux-4.20-rc4/drivers/net/wan/z85230.c
1 ./linux-4.20-rc4/drivers/net/wireless/intel/iwlegacy/3945-mac.c
1 ./linux-4.20-rc4/net/ipv4/tcp_input.c
1 ./linux-4.20-rc4/sound/pci/ac97/ac97_patch.c
1 ./linux-4.20-rc4/sound/pci/cs46xx/dsp_spos_scb_lib.c
c $

c $ find . -type f | xargs grep -ic " piss " | grep -v ":0$" | awk 
'BEGIN{FS=":";print "\npisspot"}{print $2 " " $1}' | sort -n

pisspot
1 ./linux-4.20-rc4/Documentation/process/submitting-patches.rst
1 ./linux-4.20-rc4/Documentation/translations/ja_JP/SubmittingPatches
1 ./linux-4.20-rc4/Documentation/translations/zh_CN/SubmittingPatches
c $

c $ grep -in " piss " 
./linux-4.20-rc4/Documentation/process/submitting-patches.rst
817:Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer".


c $ find . -type f | xargs grep -ic " fuck " | grep -v ":0$" | awk 
'BEGIN{FS=":";print "\nfucked"}{print $2 " " $1}' | sort -n

fucked
1 ./linux-4.20-rc4/Documentation/kernel-hacking/locking.rst
1 ./linux-4.20-rc4/arch/m68k/include/asm/sun3ints.h
1 ./linux-4.20-rc4/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc
1 ./linux-4.20-rc4/drivers/media/i2c/bt819.c
1 ./linux-4.20-rc4/drivers/net/ethernet/sun/sunhme.c
c $


c $ find . -type f | xargs grep -ic " fucked " | grep -v ":0$" | awk 
'BEGIN{FS=":";print "\nreally fucked"}{print $2 " " $1}' | sort -n

really fucked
1 ./linux-4.20-rc4/drivers/cpufreq/powernow-k7.c
1 ./linux-4.20-rc4/drivers/ide/cmd640.c
1 ./linux-4.20-rc4/fs/notify/inotify/inotify_user.c
1 ./linux-4.20-rc4/lib/vsprintf.c
12 ./linux-4.20-rc4/arch/mips/pci/ops-bridge.c
c $

The finest example of colorful comments is arch/mips/pci/ops-bridge.c:


     54          addr = 
&bridge->b_type0_cfg_dev[slot].f[fn].c[PCI_VENDOR_ID];
     55          if (get_dbe(cf, (u32 *) addr))
     56                  return PCIBIOS_DEVICE_NOT_FOUND;
     57
     58          /*
     59           * IOC3 is fucking fucked beyond belief ...  Don't even 
give the
     60           * generic PCI code a chance to look at it for real ...
     61           */
     62          if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 
<< 16)))
     63                  goto oh_my_gawd;
     64
.
.
.
     76  oh_my_gawd:
     77
     78          /*
     79           * IOC3 is fucking fucked beyond belief ...  Don't even 
give the
     80           * generic PCI code a chance to look at the wrong register.
     81           */
     82          if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
     83                  *value = emulate_ioc3_cfg(where, size);
     84                  return PCIBIOS_SUCCESSFUL;
     85          }
     86
     87          /*
     88           * IOC3 is fucking fucked beyond belief ...  Don't try 
to access
     89           * anything but 32-bit words ...
     90           */
     91          addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
     92


Ah yes .. I remember the days when IBM bought Lotus and no one could
have a beer in the office anymore.  Everyone that was good walked out.
Let's not do that.

Dennis Clarke


  reply	other threads:[~2018-11-30 22:55 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com>
2018-11-30 19:27 ` [PATCH RFC 01/15] MIPS: replace **** with a hug Jarkko Sakkinen
2018-11-30 19:57   ` Jarkko Sakkinen
2018-11-30 21:06     ` Nikolay Borisov
2018-11-30 21:50       ` Jarkko Sakkinen
2018-11-30 22:11         ` Nikolay Borisov
2018-11-30 21:13   ` Al Viro
2018-11-30 21:28     ` Randy Dunlap
2018-12-01  1:52   ` Joshua Kinard
2018-12-01  4:58   ` Mike Galbraith
2018-11-30 19:27 ` [PATCH RFC 02/15] Documentation: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 03/15] drm/nouveau: " Jarkko Sakkinen
2018-11-30 20:13   ` Diego Viola
2018-11-30 21:26     ` Jarkko Sakkinen
2018-11-30 22:03       ` Diego Viola
2018-11-30 19:27 ` [PATCH RFC 04/15] m68k: " Jarkko Sakkinen
2018-11-30 19:44   ` John Paul Adrian Glaubitz
2018-11-30 20:59     ` Jarkko Sakkinen
2018-11-30 21:59       ` Jiri Kosina
2018-11-30 19:27 ` [PATCH RFC 05/15] parisc: " Jarkko Sakkinen
2018-11-30 22:48   ` Dennis Clarke [this message]
2018-11-30 23:03     ` Jarkko Sakkinen
2018-11-30 23:05   ` Diego Viola
2018-11-30 19:27 ` [PATCH RFC 06/15] cpufreq: " Jarkko Sakkinen
2018-12-03  9:08   ` Rafael J. Wysocki
2018-11-30 19:27 ` [PATCH RFC 07/15] ide: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 08/15] media: " Jarkko Sakkinen
2018-12-01  8:01   ` Tomasz Figa
2018-11-30 19:27 ` [PATCH RFC 09/15] mtd: " Jarkko Sakkinen
2018-11-30 19:39   ` Boris Brezillon
2018-11-30 20:56     ` Jarkko Sakkinen
2018-12-01 10:31   ` Richard Weinberger
2018-11-30 19:27 ` [PATCH RFC 10/15] net/sunhme: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 11/15] scsi: " Jarkko Sakkinen
2018-11-30 20:21   ` James Bottomley
2018-11-30 21:30     ` Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 12/15] inotify: " Jarkko Sakkinen
2018-12-01  6:40   ` Amir Goldstein
2018-12-05  9:49     ` Jan Kara
2018-11-30 19:27 ` [PATCH RFC 13/15] irq: " Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 14/15] lib: " Jarkko Sakkinen
2018-11-30 19:41   ` Steven Rostedt
2018-11-30 19:46     ` Jonathan Corbet
2018-11-30 19:49       ` Jiri Kosina
2018-11-30 20:59     ` Jarkko Sakkinen
2018-12-02  3:24       ` Sergey Senozhatsky
2018-12-02 21:34   ` Tobin C. Harding
2018-11-30 19:27 ` [PATCH RFC 15/15] net: " Jarkko Sakkinen
2018-12-03 10:15   ` Phil Sutter
2018-11-30 19:40 ` [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Kees Cook
2018-11-30 19:48   ` Fwd: " Kees Cook
2018-11-30 20:42     ` Aaro Koskinen
2018-11-30 19:56   ` Davidlohr Bueso
2018-11-30 20:12     ` Jens Axboe
2018-11-30 20:34       ` Michael Schmitz
2018-11-30 20:35       ` David Miller
     [not found]         ` <2007856.n5V9iKLVsV@eth7>
2018-11-30 20:42           ` David Miller
     [not found]             ` <2269948.6tYQeUj9R1@eth7>
2018-11-30 20:53               ` Steven Rostedt
2018-11-30 20:43           ` Steven Rostedt
2018-12-01  4:08           ` Jarkko Sakkinen
2018-11-30 21:42         ` Jarkko Sakkinen
2018-11-30 21:47           ` David Miller
2018-11-30 21:53             ` Jens Axboe
2018-11-30 20:34     ` David Miller
2018-11-30 20:55     ` Jarkko Sakkinen
2018-11-30 21:01       ` James Bottomley
2018-11-30 21:44         ` Jarkko Sakkinen
2018-11-30 21:48           ` David Miller
2018-11-30 21:54             ` Jarkko Sakkinen
2018-11-30 22:04               ` James Bottomley
2018-11-30 21:57           ` James Bottomley
2018-11-30 22:12             ` Jarkko Sakkinen
2018-11-30 22:14               ` Jonathan Corbet
2018-11-30 22:26                 ` Jarkko Sakkinen
2018-11-30 22:29                   ` Jarkko Sakkinen
2018-11-30 22:30                   ` James Bottomley
2018-11-30 22:40                     ` Jarkko Sakkinen
2018-11-30 23:28                       ` Jarkko Sakkinen
2018-12-01  8:20                 ` Geert Uytterhoeven
2018-12-07 13:39                   ` Eric Curtin
2018-11-30 22:26               ` James Bottomley
2018-11-30 21:02       ` Steven Rostedt
2018-11-30 21:04       ` Jonathan Corbet
2018-11-30 19:57   ` Geert Uytterhoeven
2018-11-30 21:09     ` Jarkko Sakkinen
2018-11-30 20:09   ` John Paul Adrian Glaubitz
2018-11-30 21:32     ` Jarkko Sakkinen
2018-11-30 20:31   ` Matthias Brugger
2018-11-30 21:34     ` Jarkko Sakkinen
2018-11-30 21:07   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc2c08ea-2d9b-4aac-ba98-e7cec57a9cce@blastwave.org \
    --to=dclarke@blastwave.org \
    --cc=akpm@linux-foundation.org \
    --cc=deller@gmx.de \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jejb@parisc-linux.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).