linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec
@ 2019-02-20 22:11 Nick Crews
  2019-02-20 23:09 ` Randy Dunlap
  0 siblings, 1 reply; 8+ messages in thread
From: Nick Crews @ 2019-02-20 22:11 UTC (permalink / raw)
  To: bleung, enric.balletbo; +Cc: linux-kernel, dlaurie, ncrews, rdunlap, sfr

In the initial version of the Wilco EC Driver, the
dependency order was wrong. It before was possible to
select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
other way around.

Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
Signed-off-by: Nick Crews <ncrews@chromium.org>
---
 drivers/platform/chrome/Kconfig          | 2 +-
 drivers/platform/chrome/wilco_ec/Kconfig | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 462eb9dfa4f2..b69561050868 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -95,7 +95,7 @@ config CROS_EC_LPC
 
 config CROS_EC_LPC_MEC
 	bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
-	depends on CROS_EC_LPC || WILCO_EC
+	depends on CROS_EC_LPC
 	default n
 	help
 	  If you say Y here, a variant LPC protocol for the Microchip EC
diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
index 20945a301ec6..c6bc4e8f3062 100644
--- a/drivers/platform/chrome/wilco_ec/Kconfig
+++ b/drivers/platform/chrome/wilco_ec/Kconfig
@@ -1,7 +1,6 @@
 config WILCO_EC
 	tristate "ChromeOS Wilco Embedded Controller"
-	depends on ACPI && X86
-	select CROS_EC_LPC_MEC
+	depends on ACPI && X86 && CROS_EC_LPC_MEC
 	help
 	  If you say Y here, you get support for talking to the ChromeOS
 	  Wilco EC over an eSPI bus. This uses a simple byte-level protocol


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-02-25 13:56 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 22:11 [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec Nick Crews
2019-02-20 23:09 ` Randy Dunlap
2019-02-21  7:57   ` Enric Balletbo i Serra
2019-02-22 16:50     ` Randy Dunlap
2019-02-25 10:11       ` Enric Balletbo i Serra
2019-02-25 10:22         ` Cheng-yi Chiang
2019-02-25 12:23           ` Enric Balletbo i Serra
2019-02-25 13:56             ` Cheng-yi Chiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).