From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: saiprakash.ranjan@codeaurora.org
Cc: mathieu.poirier@linaro.org, bjorn.andersson@linaro.org,
leo.yan@linaro.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, agross@kernel.org, david.brown@linaro.org,
mark.rutland@arm.com, swboyd@chromium.org, rnayak@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] coresight: etm4x: Add support for Qualcomm SC7180 SoC
Date: Mon, 23 Mar 2020 11:39:39 +0000 [thread overview]
Message-ID: <788554ee-1b78-9651-9a95-843b8725f502@arm.com> (raw)
In-Reply-To: <4924d6c9495d412d9ecb3e1a50ea6ca8@codeaurora.org>
On 03/23/2020 11:32 AM, Sai Prakash Ranjan wrote:
> Hi Suzuki,
>
> On 2020-03-23 15:25, Suzuki K Poulose wrote:
>> On 03/20/2020 07:44 AM, Sai Prakash Ranjan wrote:
>>> Add ETM Peripheral IDs for Qualcomm SC7180 SoC. It has
>>> 2 big CPU cores based on Cortex-A76 and 6 LITTLE CPU
>>> cores based on Cortex-A55.
>>>
>>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>>> ---
>>> drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
>>> b/drivers/hwtracing/coresight/coresight-etm4x.c
>>> index a90d757f7043..a153a65c4c5b 100644
>>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
>>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
>>> @@ -1556,6 +1556,8 @@ static const struct amba_id etm4_ids[] = {
>>> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
>>> CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385
>>> Cortex-A55 */
>>> CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385
>>> Cortex-A75 */
>>> + CS_AMBA_ID(0x000bb805), /* Qualcomm Kryo 4XX
>>> Cortex-A55 */
>>> + CS_AMBA_ID(0x000bb804), /* Qualcomm Kryo 4XX
>>> Cortex-A76 */
>>
>> Does the DEVARCH indicate that it is an ETMv4 ? (It should !) Please
>> could we enforce the UCI_ID check for these components ? The
>> moment you add CTI components to your board this could conflict with
>> them unless we check the UCI_ID for ETMv4.
>>
>
> Yes I got these IDs through devarch and it does indicate that it is
> ETMv4.2.
>
> devname=7040000.etm dev->type=0x13 devarch=0x47724a13
> devname=7140000.etm dev->type=0x13 devarch=0x47724a13
> devname=7240000.etm dev->type=0x13 devarch=0x47724a13
> devname=7340000.etm dev->type=0x13 devarch=0x47724a13
> devname=7440000.etm dev->type=0x13 devarch=0x47724a13
> devname=7540000.etm dev->type=0x13 devarch=0x47724a13
> devname=7640000.etm dev->type=0x13 devarch=0x47724a13
> devname=7740000.etm dev->type=0x13 devarch=0x47724a13
>
> I will add the UCI_ID as you suggested in next version.
If you do have access to the Kryo 385 variants, please fix
them as well.
Cheers
Suzuki
next prev parent reply other threads:[~2020-03-23 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:44 [PATCH 0/2] Add coresight support for QCOM SC7180 SoC Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 1/2] coresight: etm4x: Add support for Qualcomm " Sai Prakash Ranjan
2020-03-21 22:08 ` Stephen Boyd
2020-03-23 9:55 ` Suzuki K Poulose
2020-03-23 11:32 ` Sai Prakash Ranjan
2020-03-23 11:39 ` Suzuki K Poulose [this message]
2020-03-23 13:17 ` Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support Sai Prakash Ranjan
2020-03-21 22:10 ` Stephen Boyd
2020-03-23 7:37 ` Sai Prakash Ranjan
2020-04-09 7:19 ` Stephen Boyd
2020-04-09 7:54 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=788554ee-1b78-9651-9a95-843b8725f502@arm.com \
--to=suzuki.poulose@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).