From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
devicetree@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support
Date: Mon, 23 Mar 2020 13:07:55 +0530 [thread overview]
Message-ID: <de3d226dbd7b00f9c4b7cd6c86db97e0@codeaurora.org> (raw)
In-Reply-To: <158482865109.125146.10520179077419628836@swboyd.mtv.corp.google.com>
On 2020-03-22 03:40, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2020-03-20 00:44:29)
>> Add coresight components found on Qualcomm SC7180 SoC.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Tested-by: Stephen Boyd <swboyd@chromium.org>
>
> One nit below.
>
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 507
>> +++++++++++++++++++++++++++
>> 1 file changed, 507 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 998f101ad623..d8fe960d6ace 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -1294,6 +1294,513 @@
>> };
>> };
>>
>> + stm@6002000 {
>> + compatible = "arm,coresight-stm",
>> "arm,primecell";
>> + reg = <0 0x06002000 0 0x1000>,
>> + <0 0x16280000 0 0x180000>;
>> + reg-names = "stm-base", "stm-stimulus-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + stm_out: endpoint {
>> + remote-endpoint =
>> + <&funnel0_in7>;
>
> Given that this is DT I'd say we just put this remote-endpoint all on
> one line. Makes it more readable and I don't think we really care about
> the line length in these cases. We're nested pretty deep because it's a
> graph binding.
>
Thanks for the review and test, I will make this change.
-Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-03-23 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:44 [PATCH 0/2] Add coresight support for QCOM SC7180 SoC Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 1/2] coresight: etm4x: Add support for Qualcomm " Sai Prakash Ranjan
2020-03-21 22:08 ` Stephen Boyd
2020-03-23 9:55 ` Suzuki K Poulose
2020-03-23 11:32 ` Sai Prakash Ranjan
2020-03-23 11:39 ` Suzuki K Poulose
2020-03-23 13:17 ` Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support Sai Prakash Ranjan
2020-03-21 22:10 ` Stephen Boyd
2020-03-23 7:37 ` Sai Prakash Ranjan [this message]
2020-04-09 7:19 ` Stephen Boyd
2020-04-09 7:54 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de3d226dbd7b00f9c4b7cd6c86db97e0@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).