From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: saiprakash.ranjan@codeaurora.org, mathieu.poirier@linaro.org,
bjorn.andersson@linaro.org, leo.yan@linaro.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
agross@kernel.org, david.brown@linaro.org, mark.rutland@arm.com
Cc: swboyd@chromium.org, rnayak@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] coresight: etm4x: Add support for Qualcomm SC7180 SoC
Date: Mon, 23 Mar 2020 09:55:38 +0000 [thread overview]
Message-ID: <edf1bab3-411a-ff7a-b4ca-78a8ab00c72b@arm.com> (raw)
In-Reply-To: <07a6b272c6e71e0e480f0dd0bffaf3138c0ab4c2.1584689229.git.saiprakash.ranjan@codeaurora.org>
On 03/20/2020 07:44 AM, Sai Prakash Ranjan wrote:
> Add ETM Peripheral IDs for Qualcomm SC7180 SoC. It has
> 2 big CPU cores based on Cortex-A76 and 6 LITTLE CPU
> cores based on Cortex-A55.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index a90d757f7043..a153a65c4c5b 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1556,6 +1556,8 @@ static const struct amba_id etm4_ids[] = {
> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
> CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */
> + CS_AMBA_ID(0x000bb805), /* Qualcomm Kryo 4XX Cortex-A55 */
> + CS_AMBA_ID(0x000bb804), /* Qualcomm Kryo 4XX Cortex-A76 */
Does the DEVARCH indicate that it is an ETMv4 ? (It should !) Please
could we enforce the UCI_ID check for these components ? The
moment you add CTI components to your board this could conflict with
them unless we check the UCI_ID for ETMv4.
Suzuki
next prev parent reply other threads:[~2020-03-23 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:44 [PATCH 0/2] Add coresight support for QCOM SC7180 SoC Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 1/2] coresight: etm4x: Add support for Qualcomm " Sai Prakash Ranjan
2020-03-21 22:08 ` Stephen Boyd
2020-03-23 9:55 ` Suzuki K Poulose [this message]
2020-03-23 11:32 ` Sai Prakash Ranjan
2020-03-23 11:39 ` Suzuki K Poulose
2020-03-23 13:17 ` Sai Prakash Ranjan
2020-03-20 7:44 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support Sai Prakash Ranjan
2020-03-21 22:10 ` Stephen Boyd
2020-03-23 7:37 ` Sai Prakash Ranjan
2020-04-09 7:19 ` Stephen Boyd
2020-04-09 7:54 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edf1bab3-411a-ff7a-b4ca-78a8ab00c72b@arm.com \
--to=suzuki.poulose@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).