[PATCH v2 0/3] Support XDPE112

[PATCH v2 0/3] Support XDPE112

[Marcello Sylvester Bauer]

Add support for Infineon Multi-phase XDPE112 family regulator. The main
difference to the XDPE122 family is it uses a different format for
voltage out. Add the required logic to the existing  xdpe12284 driver
accordingly.

Changes in v2:
- Rebase on current hwmon-next branch

Marcello Sylvester Bauer (3):
  dt-bindings: trivial-devices: Add xdpe11280
  hwmon (xdpe12284): Add support for xdpe11280
  hwmon (xdpe12284): Add regulator support

 .../devicetree/bindings/trivial-devices.yaml  |  2 ++
 Documentation/hwmon/xdpe12284.rst             | 10 +++++--
 drivers/hwmon/pmbus/Kconfig                   |  6 ++++
 drivers/hwmon/pmbus/xdpe12284.c               | 28 ++++++++++++++++++-
 4 files changed, 42 insertions(+), 4 deletions(-)

-- 
2.34.1

[PATCH v2 1/3] dt-bindings: trivial-devices: Add xdpe11280

[Marcello Sylvester Bauer]

Add Infineon Multi-phase Digital Controller XDPE11280.

Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 091792ba993e..8a42aea3b8a6 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -137,6 +137,8 @@ properties:
           - infineon,slb9645tt
             # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
           - infineon,tlv493d-a1b6
+            # Infineon Multi-phase Digital VR Controller xdpe11280
+          - infineon,xdpe11280
             # Infineon Multi-phase Digital VR Controller xdpe12254
           - infineon,xdpe12254
             # Infineon Multi-phase Digital VR Controller xdpe12284
-- 
2.34.1

[PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Marcello Sylvester Bauer]

Add support for another family of Infineon Multi-phase controllers.
The xdpe11280 uses linear instead of vid data format for VOUT.
Add the required logic to detect VOUT_MODE during identification,
and set the format accordingly.

Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
 Documentation/hwmon/xdpe12284.rst | 10 +++++++---
 drivers/hwmon/pmbus/xdpe12284.c   | 17 ++++++++++++++++-
 2 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/Documentation/hwmon/xdpe12284.rst b/Documentation/hwmon/xdpe12284.rst
index 67d1f87808e5..e9a5a19b0c3d 100644
--- a/Documentation/hwmon/xdpe12284.rst
+++ b/Documentation/hwmon/xdpe12284.rst
@@ -5,6 +5,10 @@ Kernel driver xdpe122
 
 Supported chips:
 
+  * Infineon XDPE11280
+
+    Prefix: 'xdpe11280'
+
   * Infineon XDPE12254
 
     Prefix: 'xdpe12254'
@@ -20,9 +24,9 @@ Authors:
 Description
 -----------
 
-This driver implements support for Infineon Multi-phase XDPE122 family
-dual loop voltage regulators.
-The family includes XDPE12284 and XDPE12254 devices.
+This driver implements support for Infineon Multi-phase XDPE112 and XDPE122
+family dual loop voltage regulators.
+These families include XDPE11280, XDPE12284 and XDPE12254 devices.
 The devices from this family complaint with:
 
 - Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9 rev 1.3 DC-DC
diff --git a/drivers/hwmon/pmbus/xdpe12284.c b/drivers/hwmon/pmbus/xdpe12284.c
index b07da06a40c9..ec947c697670 100644
--- a/drivers/hwmon/pmbus/xdpe12284.c
+++ b/drivers/hwmon/pmbus/xdpe12284.c
@@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
 	s32 mantissa;
 	int ret;
 
+	if (info->format[PSC_VOLTAGE_OUT] == linear)
+		return -ENODATA;
+
 	switch (reg) {
 	case PMBUS_VOUT_OV_FAULT_LIMIT:
 	case PMBUS_VOUT_UV_FAULT_LIMIT:
@@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
 static int xdpe122_identify(struct i2c_client *client,
 			    struct pmbus_driver_info *info)
 {
-	u8 vout_params;
+	u8 vout_mode, vout_params;
 	int i, ret;
 
+	ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
+	if (ret < 0)
+		return ret;
+
+	vout_mode = ret >> 5;
+	if (vout_mode == 0) {
+		info->format[PSC_VOLTAGE_OUT] = linear;
+		return 0;
+	}
+
 	for (i = 0; i < XDPE122_PAGE_NUM; i++) {
 		/* Read the register with VOUT scaling value.*/
 		ret = pmbus_read_byte_data(client, i, PMBUS_VOUT_MODE);
@@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client *client)
 }
 
 static const struct i2c_device_id xdpe122_id[] = {
+	{"xdpe11280", 0},
 	{"xdpe12254", 0},
 	{"xdpe12284", 0},
 	{}
@@ -148,6 +162,7 @@ static const struct i2c_device_id xdpe122_id[] = {
 MODULE_DEVICE_TABLE(i2c, xdpe122_id);
 
 static const struct of_device_id __maybe_unused xdpe122_of_match[] = {
+	{.compatible = "infineon,xdpe11280"},
 	{.compatible = "infineon,xdpe12254"},
 	{.compatible = "infineon,xdpe12284"},
 	{}
-- 
2.34.1

[PATCH v2 3/3] hwmon (xdpe12284): Add regulator support

[Marcello Sylvester Bauer]

Add simple on/off regulator support for xdpe12284 and
other pmbus parts supported by the xdpe12284 driver.

Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
 drivers/hwmon/pmbus/Kconfig     |  6 ++++++
 drivers/hwmon/pmbus/xdpe12284.c | 11 +++++++++++
 2 files changed, 17 insertions(+)

diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index c96f7b7338bd..e0e9b67bf3eb 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -394,6 +394,12 @@ config SENSORS_XDPE122
 	  This driver can also be built as a module. If so, the module will
 	  be called xdpe12284.
 
+config SENSORS_XDPE122_REGULATOR
+	bool "Regulator support for XDPE122 and compatibles"
+	depends on SENSORS_XDPE122 && REGULATOR
+	help
+	  Uses the xdpe12284 or compatible as regulator.
+
 config SENSORS_ZL6100
 	tristate "Intersil ZL6100 and compatibles"
 	help
diff --git a/drivers/hwmon/pmbus/xdpe12284.c b/drivers/hwmon/pmbus/xdpe12284.c
index ec947c697670..c58776ef0311 100644
--- a/drivers/hwmon/pmbus/xdpe12284.c
+++ b/drivers/hwmon/pmbus/xdpe12284.c
@@ -10,6 +10,8 @@
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/regulator/driver.h>
+
 #include "pmbus.h"
 
 #define XDPE122_PROT_VR12_5MV		0x01 /* VR12.0 mode, 5-mV DAC */
@@ -120,6 +122,11 @@ static int xdpe122_identify(struct i2c_client *client,
 	return 0;
 }
 
+static const struct regulator_desc xdpe122_reg_desc[] = {
+	PMBUS_REGULATOR("vout", 0),
+	PMBUS_REGULATOR("vout", 1),
+};
+
 static struct pmbus_driver_info xdpe122_info = {
 	.pages = XDPE122_PAGE_NUM,
 	.format[PSC_VOLTAGE_IN] = linear,
@@ -138,6 +145,10 @@ static struct pmbus_driver_info xdpe122_info = {
 		PMBUS_HAVE_POUT | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT,
 	.identify = xdpe122_identify,
 	.read_word_data = xdpe122_read_word_data,
+#if IS_ENABLED(CONFIG_SENSORS_XDPE122_REGULATOR)
+	.num_regulators = 2,
+	.reg_desc = xdpe122_reg_desc,
+#endif
 };
 
 static int xdpe122_probe(struct i2c_client *client)
-- 
2.34.1

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Guenter Roeck]

On 2/17/22 06:41, Marcello Sylvester Bauer wrote:
> Add support for another family of Infineon Multi-phase controllers.
> The xdpe11280 uses linear instead of vid data format for VOUT.
> Add the required logic to detect VOUT_MODE during identification,
> and set the format accordingly.
> 
This talks about the chip, but ...

> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> ---
>   Documentation/hwmon/xdpe12284.rst | 10 +++++++---
>   drivers/hwmon/pmbus/xdpe12284.c   | 17 ++++++++++++++++-
>   2 files changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/hwmon/xdpe12284.rst b/Documentation/hwmon/xdpe12284.rst
> index 67d1f87808e5..e9a5a19b0c3d 100644
> --- a/Documentation/hwmon/xdpe12284.rst
> +++ b/Documentation/hwmon/xdpe12284.rst
> @@ -5,6 +5,10 @@ Kernel driver xdpe122
>   
>   Supported chips:
>   
> +  * Infineon XDPE11280
> +
> +    Prefix: 'xdpe11280'
> +
>     * Infineon XDPE12254
>   
>       Prefix: 'xdpe12254'
> @@ -20,9 +24,9 @@ Authors:
>   Description
>   -----------
>   
> -This driver implements support for Infineon Multi-phase XDPE122 family
> -dual loop voltage regulators.
> -The family includes XDPE12284 and XDPE12254 devices.
> +This driver implements support for Infineon Multi-phase XDPE112 and XDPE122
> +family dual loop voltage regulators.
> +These families include XDPE11280, XDPE12284 and XDPE12254 devices.
>   The devices from this family complaint with:

Hmm, s/complaint/compliant/.

Anyway, is it still correct that the XDPE11280 is compliant with the
Intel specifications ? The datasheet isn't public, so I can not check myself
what the chip actually supports.

>   
>   - Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9 rev 1.3 DC-DC
> diff --git a/drivers/hwmon/pmbus/xdpe12284.c b/drivers/hwmon/pmbus/xdpe12284.c
> index b07da06a40c9..ec947c697670 100644
> --- a/drivers/hwmon/pmbus/xdpe12284.c
> +++ b/drivers/hwmon/pmbus/xdpe12284.c
> @@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
>   	s32 mantissa;
>   	int ret;
>   
> +	if (info->format[PSC_VOLTAGE_OUT] == linear)
> +		return -ENODATA;
> +
>   	switch (reg) {
>   	case PMBUS_VOUT_OV_FAULT_LIMIT:
>   	case PMBUS_VOUT_UV_FAULT_LIMIT:
> @@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct i2c_client *client, int page,
>   static int xdpe122_identify(struct i2c_client *client,
>   			    struct pmbus_driver_info *info)
>   {
> -	u8 vout_params;
> +	u8 vout_mode, vout_params;
>   	int i, ret;
>   
> +	ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
> +	if (ret < 0)
> +		return ret;
> +
> +	vout_mode = ret >> 5;
> +	if (vout_mode == 0) {
> +		info->format[PSC_VOLTAGE_OUT] = linear;
> +		return 0;
> +	}

.... the code above is not chip dependent but this code checks the
mode register on page 0. At the very least this is confusing.

What the driver should do instead is to check the chip type during
probe and make the necessary changes there, ie set the output format
for xdpe11280 to linear and drop the pointers to the .identify
and .read_word_data.

Guenter

> +
>   	for (i = 0; i < XDPE122_PAGE_NUM; i++) {
>   		/* Read the register with VOUT scaling value.*/
>   		ret = pmbus_read_byte_data(client, i, PMBUS_VOUT_MODE);
> @@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client *client)
>   }
>   
>   static const struct i2c_device_id xdpe122_id[] = {
> +	{"xdpe11280", 0},
>   	{"xdpe12254", 0},
>   	{"xdpe12284", 0},
>   	{}
> @@ -148,6 +162,7 @@ static const struct i2c_device_id xdpe122_id[] = {
>   MODULE_DEVICE_TABLE(i2c, xdpe122_id);
>   
>   static const struct of_device_id __maybe_unused xdpe122_of_match[] = {
> +	{.compatible = "infineon,xdpe11280"},
>   	{.compatible = "infineon,xdpe12254"},
>   	{.compatible = "infineon,xdpe12284"},
>   	{}

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[sylv]

On Thu, 2022-02-17 at 07:20 -0800, Guenter Roeck wrote:
> On 2/17/22 06:41, Marcello Sylvester Bauer wrote:
> > Add support for another family of Infineon Multi-phase controllers.
> > The xdpe11280 uses linear instead of vid data format for VOUT.
> > Add the required logic to detect VOUT_MODE during identification,
> > and set the format accordingly.
> > 
> This talks about the chip, but ...

Oh, sure. I should be more clear that it is a chip of a different
family.

> 
> > Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> > ---
> >   Documentation/hwmon/xdpe12284.rst | 10 +++++++---
> >   drivers/hwmon/pmbus/xdpe12284.c   | 17 ++++++++++++++++-
> >   2 files changed, 23 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/xdpe12284.rst
> > b/Documentation/hwmon/xdpe12284.rst
> > index 67d1f87808e5..e9a5a19b0c3d 100644
> > --- a/Documentation/hwmon/xdpe12284.rst
> > +++ b/Documentation/hwmon/xdpe12284.rst
> > @@ -5,6 +5,10 @@ Kernel driver xdpe122
> >   
> >   Supported chips:
> >   
> > +  * Infineon XDPE11280
> > +
> > +    Prefix: 'xdpe11280'
> > +
> >     * Infineon XDPE12254
> >   
> >       Prefix: 'xdpe12254'
> > @@ -20,9 +24,9 @@ Authors:
> >   Description
> >   -----------
> >   
> > -This driver implements support for Infineon Multi-phase XDPE122
> > family
> > -dual loop voltage regulators.
> > -The family includes XDPE12284 and XDPE12254 devices.
> > +This driver implements support for Infineon Multi-phase XDPE112
> > and XDPE122
> > +family dual loop voltage regulators.
> > +These families include XDPE11280, XDPE12284 and XDPE12254 devices.
> >   The devices from this family complaint with:
> 
> Hmm, s/complaint/compliant/.

ack

> 
> Anyway, is it still correct that the XDPE11280 is compliant with the
> Intel specifications ? The datasheet isn't public, so I can not check
> myself
> what the chip actually supports.

The hardware we are testing on is an Intel Cascade Lake, which uses
this chip. The datasheet tells us it is compliant:

```
The XDPE11280B implements a fully compliant Intel® VR 13, VR12, VR
12.5, VR13.HC, and IMVP8 Serial VID (SVID)
interface.
```

> 
> >   
> >   - Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9 rev 1.3
> > DC-DC
> > diff --git a/drivers/hwmon/pmbus/xdpe12284.c
> > b/drivers/hwmon/pmbus/xdpe12284.c
> > index b07da06a40c9..ec947c697670 100644
> > --- a/drivers/hwmon/pmbus/xdpe12284.c
> > +++ b/drivers/hwmon/pmbus/xdpe12284.c
> > @@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct
> > i2c_client *client, int page,
> >         s32 mantissa;
> >         int ret;
> >   
> > +       if (info->format[PSC_VOLTAGE_OUT] == linear)
> > +               return -ENODATA;
> > +
> >         switch (reg) {
> >         case PMBUS_VOUT_OV_FAULT_LIMIT:
> >         case PMBUS_VOUT_UV_FAULT_LIMIT:
> > @@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct
> > i2c_client *client, int page,
> >   static int xdpe122_identify(struct i2c_client *client,
> >                             struct pmbus_driver_info *info)
> >   {
> > -       u8 vout_params;
> > +       u8 vout_mode, vout_params;
> >         int i, ret;
> >   
> > +       ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
> > +       if (ret < 0)
> > +               return ret;
> > +
> > +       vout_mode = ret >> 5;
> > +       if (vout_mode == 0) {
> > +               info->format[PSC_VOLTAGE_OUT] = linear;
> > +               return 0;
> > +       }
> 
> .... the code above is not chip dependent but this code checks the
> mode register on page 0. At the very least this is confusing.
> 
> What the driver should do instead is to check the chip type during
> probe and make the necessary changes there, ie set the output format
> for xdpe11280 to linear and drop the pointers to the .identify
> and .read_word_data.

Sgtm. This sounds like a better approach indeed.

Thanks,
Marcello

> 
> Guenter
> 
> > +
> >         for (i = 0; i < XDPE122_PAGE_NUM; i++) {
> >                 /* Read the register with VOUT scaling value.*/
> >                 ret = pmbus_read_byte_data(client, i,
> > PMBUS_VOUT_MODE);
> > @@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client
> > *client)
> >   }
> >   
> >   static const struct i2c_device_id xdpe122_id[] = {
> > +       {"xdpe11280", 0},
> >         {"xdpe12254", 0},
> >         {"xdpe12284", 0},
> >         {}
> > @@ -148,6 +162,7 @@ static const struct i2c_device_id xdpe122_id[]
> > = {
> >   MODULE_DEVICE_TABLE(i2c, xdpe122_id);
> >   
> >   static const struct of_device_id __maybe_unused
> > xdpe122_of_match[] = {
> > +       {.compatible = "infineon,xdpe11280"},
> >         {.compatible = "infineon,xdpe12254"},
> >         {.compatible = "infineon,xdpe12284"},
> >         {}
> 

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Guenter Roeck]

On 2/17/22 08:39, sylv wrote:
> On Thu, 2022-02-17 at 07:20 -0800, Guenter Roeck wrote:
>> On 2/17/22 06:41, Marcello Sylvester Bauer wrote:
>>> Add support for another family of Infineon Multi-phase controllers.
>>> The xdpe11280 uses linear instead of vid data format for VOUT.
>>> Add the required logic to detect VOUT_MODE during identification,
>>> and set the format accordingly.
>>>
>> This talks about the chip, but ...
> 
> Oh, sure. I should be more clear that it is a chip of a different
> family.
> 
>>
>>> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
>>> ---
>>>    Documentation/hwmon/xdpe12284.rst | 10 +++++++---
>>>    drivers/hwmon/pmbus/xdpe12284.c   | 17 ++++++++++++++++-
>>>    2 files changed, 23 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/hwmon/xdpe12284.rst
>>> b/Documentation/hwmon/xdpe12284.rst
>>> index 67d1f87808e5..e9a5a19b0c3d 100644
>>> --- a/Documentation/hwmon/xdpe12284.rst
>>> +++ b/Documentation/hwmon/xdpe12284.rst
>>> @@ -5,6 +5,10 @@ Kernel driver xdpe122
>>>    
>>>    Supported chips:
>>>    
>>> +  * Infineon XDPE11280
>>> +
>>> +    Prefix: 'xdpe11280'
>>> +
>>>      * Infineon XDPE12254
>>>    
>>>        Prefix: 'xdpe12254'
>>> @@ -20,9 +24,9 @@ Authors:
>>>    Description
>>>    -----------
>>>    
>>> -This driver implements support for Infineon Multi-phase XDPE122
>>> family
>>> -dual loop voltage regulators.
>>> -The family includes XDPE12284 and XDPE12254 devices.
>>> +This driver implements support for Infineon Multi-phase XDPE112
>>> and XDPE122
>>> +family dual loop voltage regulators.
>>> +These families include XDPE11280, XDPE12284 and XDPE12254 devices.
>>>    The devices from this family complaint with:
>>
>> Hmm, s/complaint/compliant/.
> 
> ack
> 
>>
>> Anyway, is it still correct that the XDPE11280 is compliant with the
>> Intel specifications ? The datasheet isn't public, so I can not check
>> myself
>> what the chip actually supports.
> 
> The hardware we are testing on is an Intel Cascade Lake, which uses
> this chip. The datasheet tells us it is compliant:
> 
> ```
> The XDPE11280B implements a fully compliant Intel® VR 13, VR12, VR
> 12.5, VR13.HC, and IMVP8 Serial VID (SVID)
> interface.
> ```
> 

This seems to be one of those chips where the vendor doesn't even admit
that it exists unless one signs an NDA. Sigh :-(.

>>
>>>    
>>>    - Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9 rev 1.3
>>> DC-DC
>>> diff --git a/drivers/hwmon/pmbus/xdpe12284.c
>>> b/drivers/hwmon/pmbus/xdpe12284.c
>>> index b07da06a40c9..ec947c697670 100644
>>> --- a/drivers/hwmon/pmbus/xdpe12284.c
>>> +++ b/drivers/hwmon/pmbus/xdpe12284.c
>>> @@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct
>>> i2c_client *client, int page,
>>>          s32 mantissa;
>>>          int ret;
>>>    
>>> +       if (info->format[PSC_VOLTAGE_OUT] == linear)
>>> +               return -ENODATA;
>>> +
>>>          switch (reg) {
>>>          case PMBUS_VOUT_OV_FAULT_LIMIT:
>>>          case PMBUS_VOUT_UV_FAULT_LIMIT:
>>> @@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct
>>> i2c_client *client, int page,
>>>    static int xdpe122_identify(struct i2c_client *client,
>>>                              struct pmbus_driver_info *info)
>>>    {
>>> -       u8 vout_params;
>>> +       u8 vout_mode, vout_params;
>>>          int i, ret;
>>>    
>>> +       ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
>>> +       if (ret < 0)
>>> +               return ret;
>>> +
>>> +       vout_mode = ret >> 5;
>>> +       if (vout_mode == 0) {
>>> +               info->format[PSC_VOLTAGE_OUT] = linear;
>>> +               return 0;
>>> +       }
>>
>> .... the code above is not chip dependent but this code checks the
>> mode register on page 0. At the very least this is confusing.
>>
>> What the driver should do instead is to check the chip type during
>> probe and make the necessary changes there, ie set the output format
>> for xdpe11280 to linear and drop the pointers to the .identify
>> and .read_word_data.
> 
> Sgtm. This sounds like a better approach indeed.
> 

That makes me wonder if the chip needs to be added to this driver in the first
place, or if it could be added to pmbus.c instead. Any idea ?

Thanks,
Guenter

> Thanks,
> Marcello
> 
>>
>> Guenter
>>
>>> +
>>>          for (i = 0; i < XDPE122_PAGE_NUM; i++) {
>>>                  /* Read the register with VOUT scaling value.*/
>>>                  ret = pmbus_read_byte_data(client, i,
>>> PMBUS_VOUT_MODE);
>>> @@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client
>>> *client)
>>>    }
>>>    
>>>    static const struct i2c_device_id xdpe122_id[] = {
>>> +       {"xdpe11280", 0},
>>>          {"xdpe12254", 0},
>>>          {"xdpe12284", 0},
>>>          {}
>>> @@ -148,6 +162,7 @@ static const struct i2c_device_id xdpe122_id[]
>>> = {
>>>    MODULE_DEVICE_TABLE(i2c, xdpe122_id);
>>>    
>>>    static const struct of_device_id __maybe_unused
>>> xdpe122_of_match[] = {
>>> +       {.compatible = "infineon,xdpe11280"},
>>>          {.compatible = "infineon,xdpe12254"},
>>>          {.compatible = "infineon,xdpe12284"},
>>>          {}
>>
> 

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[sylv]

On Thu, 2022-02-17 at 10:11 -0800, Guenter Roeck wrote:
> On 2/17/22 08:39, sylv wrote:
> > On Thu, 2022-02-17 at 07:20 -0800, Guenter Roeck wrote:
> > > On 2/17/22 06:41, Marcello Sylvester Bauer wrote:
> > > > Add support for another family of Infineon Multi-phase
> > > > controllers.
> > > > The xdpe11280 uses linear instead of vid data format for VOUT.
> > > > Add the required logic to detect VOUT_MODE during
> > > > identification,
> > > > and set the format accordingly.
> > > > 
> > > This talks about the chip, but ...
> > 
> > Oh, sure. I should be more clear that it is a chip of a different
> > family.
> > 
> > > 
> > > > Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> > > > ---
> > > >    Documentation/hwmon/xdpe12284.rst | 10 +++++++---
> > > >    drivers/hwmon/pmbus/xdpe12284.c   | 17 ++++++++++++++++-
> > > >    2 files changed, 23 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/Documentation/hwmon/xdpe12284.rst
> > > > b/Documentation/hwmon/xdpe12284.rst
> > > > index 67d1f87808e5..e9a5a19b0c3d 100644
> > > > --- a/Documentation/hwmon/xdpe12284.rst
> > > > +++ b/Documentation/hwmon/xdpe12284.rst
> > > > @@ -5,6 +5,10 @@ Kernel driver xdpe122
> > > >    
> > > >    Supported chips:
> > > >    
> > > > +  * Infineon XDPE11280
> > > > +
> > > > +    Prefix: 'xdpe11280'
> > > > +
> > > >      * Infineon XDPE12254
> > > >    
> > > >        Prefix: 'xdpe12254'
> > > > @@ -20,9 +24,9 @@ Authors:
> > > >    Description
> > > >    -----------
> > > >    
> > > > -This driver implements support for Infineon Multi-phase
> > > > XDPE122
> > > > family
> > > > -dual loop voltage regulators.
> > > > -The family includes XDPE12284 and XDPE12254 devices.
> > > > +This driver implements support for Infineon Multi-phase
> > > > XDPE112
> > > > and XDPE122
> > > > +family dual loop voltage regulators.
> > > > +These families include XDPE11280, XDPE12284 and XDPE12254
> > > > devices.
> > > >    The devices from this family complaint with:
> > > 
> > > Hmm, s/complaint/compliant/.
> > 
> > ack
> > 
> > > 
> > > Anyway, is it still correct that the XDPE11280 is compliant with
> > > the
> > > Intel specifications ? The datasheet isn't public, so I can not
> > > check
> > > myself
> > > what the chip actually supports.
> > 
> > The hardware we are testing on is an Intel Cascade Lake, which uses
> > this chip. The datasheet tells us it is compliant:
> > 
> > ```
> > The XDPE11280B implements a fully compliant Intel® VR 13, VR12, VR
> > 12.5, VR13.HC, and IMVP8 Serial VID (SVID)
> > interface.
> > ```
> > 
> 
> This seems to be one of those chips where the vendor doesn't even
> admit
> that it exists unless one signs an NDA. Sigh :-(.

Yeah, it's pretty... We do not understand the reasoning.

> 
> > > 
> > > >    
> > > >    - Intel VR13 and VR13HC rev 1.3, IMVP8 rev 1.2 and IMPVP9
> > > > rev 1.3
> > > > DC-DC
> > > > diff --git a/drivers/hwmon/pmbus/xdpe12284.c
> > > > b/drivers/hwmon/pmbus/xdpe12284.c
> > > > index b07da06a40c9..ec947c697670 100644
> > > > --- a/drivers/hwmon/pmbus/xdpe12284.c
> > > > +++ b/drivers/hwmon/pmbus/xdpe12284.c
> > > > @@ -27,6 +27,9 @@ static int xdpe122_read_word_data(struct
> > > > i2c_client *client, int page,
> > > >          s32 mantissa;
> > > >          int ret;
> > > >    
> > > > +       if (info->format[PSC_VOLTAGE_OUT] == linear)
> > > > +               return -ENODATA;
> > > > +
> > > >          switch (reg) {
> > > >          case PMBUS_VOUT_OV_FAULT_LIMIT:
> > > >          case PMBUS_VOUT_UV_FAULT_LIMIT:
> > > > @@ -75,9 +78,19 @@ static int xdpe122_read_word_data(struct
> > > > i2c_client *client, int page,
> > > >    static int xdpe122_identify(struct i2c_client *client,
> > > >                              struct pmbus_driver_info *info)
> > > >    {
> > > > -       u8 vout_params;
> > > > +       u8 vout_mode, vout_params;
> > > >          int i, ret;
> > > >    
> > > > +       ret = pmbus_read_byte_data(client, 0, PMBUS_VOUT_MODE);
> > > > +       if (ret < 0)
> > > > +               return ret;
> > > > +
> > > > +       vout_mode = ret >> 5;
> > > > +       if (vout_mode == 0) {
> > > > +               info->format[PSC_VOLTAGE_OUT] = linear;
> > > > +               return 0;
> > > > +       }
> > > 
> > > .... the code above is not chip dependent but this code checks
> > > the
> > > mode register on page 0. At the very least this is confusing.
> > > 
> > > What the driver should do instead is to check the chip type
> > > during
> > > probe and make the necessary changes there, ie set the output
> > > format
> > > for xdpe11280 to linear and drop the pointers to the .identify
> > > and .read_word_data.
> > 
> > Sgtm. This sounds like a better approach indeed.
> > 
> 
> That makes me wonder if the chip needs to be added to this driver in
> the first
> place, or if it could be added to pmbus.c instead. Any idea ?

Oh, we did wrote a standalone driver too, and it works fine.
Maybe it's better to upsteam it instead. :)

> 
> Thanks,
> Guenter
> 
> > Thanks,
> > Marcello
> > 
> > > 
> > > Guenter
> > > 
> > > > +
> > > >          for (i = 0; i < XDPE122_PAGE_NUM; i++) {
> > > >                  /* Read the register with VOUT scaling
> > > > value.*/
> > > >                  ret = pmbus_read_byte_data(client, i,
> > > > PMBUS_VOUT_MODE);
> > > > @@ -140,6 +153,7 @@ static int xdpe122_probe(struct i2c_client
> > > > *client)
> > > >    }
> > > >    
> > > >    static const struct i2c_device_id xdpe122_id[] = {
> > > > +       {"xdpe11280", 0},
> > > >          {"xdpe12254", 0},
> > > >          {"xdpe12284", 0},
> > > >          {}
> > > > @@ -148,6 +162,7 @@ static const struct i2c_device_id
> > > > xdpe122_id[]
> > > > = {
> > > >    MODULE_DEVICE_TABLE(i2c, xdpe122_id);
> > > >    
> > > >    static const struct of_device_id __maybe_unused
> > > > xdpe122_of_match[] = {
> > > > +       {.compatible = "infineon,xdpe11280"},
> > > >          {.compatible = "infineon,xdpe12254"},
> > > >          {.compatible = "infineon,xdpe12284"},
> > > >          {}
> > > 
> > 
> 

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Guenter Roeck]

On 2/17/22 10:38, sylv wrote:
[ ... ]

>>
>> That makes me wonder if the chip needs to be added to this driver in
>> the first
>> place, or if it could be added to pmbus.c instead. Any idea ?
> 
> Oh, we did wrote a standalone driver too, and it works fine.
> Maybe it's better to upsteam it instead. :)

No, I meant if it would make sense to just add something like

	{"xdpe11280", (kernel_ulong_t)&pmbus_info_one },

to drivers/hwmon/pmbus/pmbus.c.

You only really need a standalone driver if it does something
special, such as a workaround for some register access (like
the xdpe12284 driver), or if support for manufacturer specific
registers is desired or needed. That would, for example, be useful
if the xdpe11280 supports per-phase sensors.

Thanks,
Guenter

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[sylv]

On Thu, 2022-02-17 at 11:25 -0800, Guenter Roeck wrote:
> On 2/17/22 10:38, sylv wrote:
> [ ... ]
> 
> > > 
> > > That makes me wonder if the chip needs to be added to this driver
> > > in
> > > the first
> > > place, or if it could be added to pmbus.c instead. Any idea ?
> > 
> > Oh, we did wrote a standalone driver too, and it works fine.
> > Maybe it's better to upsteam it instead. :)
> 
> No, I meant if it would make sense to just add something like
> 
>         {"xdpe11280", (kernel_ulong_t)&pmbus_info_one },
> 
> to drivers/hwmon/pmbus/pmbus.c.
> 
> You only really need a standalone driver if it does something
> special, such as a workaround for some register access (like
> the xdpe12284 driver), or if support for manufacturer specific
> registers is desired or needed. That would, for example, be useful
> if the xdpe11280 supports per-phase sensors.
> 
> Thanks,
> Guenter

Hi,

I tested if the xdpe11280 can use the generic pmbus driver. Everything
works fine except it does only detect READ_TEMPERATURE_1 on page 0.
Looking at the pmbus_find_sensor_groups function it looks like only
some commands are probed on each page (READ_VOUT, READ_IOUT, and
READ_POUT) but not READ_TEMPERATURE_1.
The PMBus spec 1.3.1 tells us: "Each page may offer the full range of
PMBus commands available for each output or non-PMBus device." How
could we adapt the generic driver so that it is possible to probe
commands for each page?

Furthermore, It would be great to add regulator and DT support. I
created a WIP branch on GitHub with a possible way to implement this:
https://github.com/9elements/linux/tree/upstreaming_pmbus_regulator_wip

What do you think?

Thanks,
Marcello 

Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Add xdpe11280

[Rob Herring]

On Thu, 17 Feb 2022 15:41:33 +0100, Marcello Sylvester Bauer wrote:
> Add Infineon Multi-phase Digital Controller XDPE11280.
> 
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Guenter Roeck]

On 2/21/22 04:13, sylv wrote:
> On Thu, 2022-02-17 at 11:25 -0800, Guenter Roeck wrote:
>> On 2/17/22 10:38, sylv wrote:
>> [ ... ]
>>
>>>>
>>>> That makes me wonder if the chip needs to be added to this driver
>>>> in
>>>> the first
>>>> place, or if it could be added to pmbus.c instead. Any idea ?
>>>
>>> Oh, we did wrote a standalone driver too, and it works fine.
>>> Maybe it's better to upsteam it instead. :)
>>
>> No, I meant if it would make sense to just add something like
>>
>>          {"xdpe11280", (kernel_ulong_t)&pmbus_info_one },
>>
>> to drivers/hwmon/pmbus/pmbus.c.
>>
>> You only really need a standalone driver if it does something
>> special, such as a workaround for some register access (like
>> the xdpe12284 driver), or if support for manufacturer specific
>> registers is desired or needed. That would, for example, be useful
>> if the xdpe11280 supports per-phase sensors.
>>
>> Thanks,
>> Guenter
> 
> Hi,
> 
> I tested if the xdpe11280 can use the generic pmbus driver. Everything
> works fine except it does only detect READ_TEMPERATURE_1 on page 0.
> Looking at the pmbus_find_sensor_groups function it looks like only
> some commands are probed on each page (READ_VOUT, READ_IOUT, and
> READ_POUT) but not READ_TEMPERATURE_1.
> The PMBus spec 1.3.1 tells us: "Each page may offer the full range of
> PMBus commands available for each output or non-PMBus device." How
> could we adapt the generic driver so that it is possible to probe
> commands for each page?
> 

The problem is the "may". Some chips don't implement multi-page
support especially for temperature sensors. So we'll have to go
with adding support to the existing driver.

Guenter

> Furthermore, It would be great to add regulator and DT support. I
> created a WIP branch on GitHub with a possible way to implement this:
> https://github.com/9elements/linux/tree/upstreaming_pmbus_regulator_wip
> 
> What do you think?
> 
> Thanks,
> Marcello
> 

Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

[Marcello Sylvester Bauer]

On Fri, 2022-02-25 at 08:39 -0800, Guenter Roeck wrote:
> On 2/21/22 04:13, sylv wrote:
> > On Thu, 2022-02-17 at 11:25 -0800, Guenter Roeck wrote:
> > > On 2/17/22 10:38, sylv wrote:
> > > [ ... ]
> > > 
> > > > > 
> > > > > That makes me wonder if the chip needs to be added to this
> > > > > driver
> > > > > in
> > > > > the first
> > > > > place, or if it could be added to pmbus.c instead. Any idea ?
> > > > 
> > > > Oh, we did wrote a standalone driver too, and it works fine.
> > > > Maybe it's better to upsteam it instead. :)
> > > 
> > > No, I meant if it would make sense to just add something like
> > > 
> > >          {"xdpe11280", (kernel_ulong_t)&pmbus_info_one },
> > > 
> > > to drivers/hwmon/pmbus/pmbus.c.
> > > 
> > > You only really need a standalone driver if it does something
> > > special, such as a workaround for some register access (like
> > > the xdpe12284 driver), or if support for manufacturer specific
> > > registers is desired or needed. That would, for example, be
> > > useful
> > > if the xdpe11280 supports per-phase sensors.
> > > 
> > > Thanks,
> > > Guenter
> > 
> > Hi,
> > 
> > I tested if the xdpe11280 can use the generic pmbus driver.
> > Everything
> > works fine except it does only detect READ_TEMPERATURE_1 on page 0.
> > Looking at the pmbus_find_sensor_groups function it looks like only
> > some commands are probed on each page (READ_VOUT, READ_IOUT, and
> > READ_POUT) but not READ_TEMPERATURE_1.
> > The PMBus spec 1.3.1 tells us: "Each page may offer the full range
> > of
> > PMBus commands available for each output or non-PMBus device." How
> > could we adapt the generic driver so that it is possible to probe
> > commands for each page?
> > 
> 
> The problem is the "may". Some chips don't implement multi-page
> support especially for temperature sensors. So we'll have to go
> with adding support to the existing driver.
> 
> Guenter

sgtm. So I'll continue working on this patch set.

> 
> > Furthermore, It would be great to add regulator and DT support. I
> > created a WIP branch on GitHub with a possible way to implement
> > this:
> > https://github.com/9elements/linux/tree/upstreaming_pmbus_regulator_wip
> > 
> > What do you think?
> > 
> > Thanks,
> > Marcello
> > 
>