From: Guenter Roeck <linux@roeck-us.net>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Łukasz Majczak" <lma@semihalf.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Radoslaw Biernacki <rad@semihalf.com>,
Marcin Wojtas <mw@semihalf.com>, Alex Levin <levinale@google.com>,
James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls
Date: Sat, 30 Jan 2021 15:49:09 -0800 [thread overview]
Message-ID: <7a702108-ec9e-b2e2-be89-3590437c0eb5@roeck-us.net> (raw)
In-Reply-To: <YBSTOrlgTPpzoblY@kernel.org>
On 1/29/21 2:59 PM, Jarkko Sakkinen wrote:
> On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote:
>> Hi Jarkko, Guenter
>>
>> Yes, here are the logs when failure occurs -
>> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9
>> Look for a phrase "TPM returned invalid status"
>>
>> Guenter - good suggestion - I will try to keep it as tight as possible.
>>
>> Best regards,
>> Lukasz
>
> Is it possible for you try out with linux-next? Thanks. It's a known
> issue, which ought to be fixed by now.
>
> The log message is harmless, it'a warning not panic, and does not
> endanger system stability. WARN()'s always dump stack trace. No oops
> is happening.
>
There is a note in the kernel documentation which states:
Note that the WARN()-family should only be used for "expected to
be unreachable" situations. If you want to warn about "reachable
but undesirable" situations, please use the pr_warn()-family of
functions.
It seems to me that "harmless" doesn't really fit the expected
use of WARN(). Should it possibly be converted to pr_warn() ?
Thanks,
Guenter
next prev parent reply other threads:[~2021-01-30 23:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 1:42 [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls Lukasz Majczak
2021-01-25 17:12 ` Jarkko Sakkinen
2021-01-25 17:18 ` Guenter Roeck
2021-01-26 15:46 ` Łukasz Majczak
2021-01-26 16:46 ` James Bottomley
2021-01-26 18:55 ` Tj (Elloe Linux)
2021-01-28 5:58 ` Jarkko Sakkinen
2021-01-29 22:59 ` Jarkko Sakkinen
2021-01-29 23:00 ` Jarkko Sakkinen
2021-01-30 23:49 ` Guenter Roeck [this message]
2021-01-31 0:41 ` James Bottomley
2021-01-31 3:36 ` Guenter Roeck
2021-01-31 4:18 ` James Bottomley
2021-02-02 16:17 ` Jarkko Sakkinen
2021-02-02 15:33 ` Jarkko Sakkinen
2021-01-29 22:49 ` Jarkko Sakkinen
2021-01-29 23:32 ` Guenter Roeck
2021-01-28 13:07 ` [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls Lukasz Majczak
2021-01-28 17:37 ` Guenter Roeck
2021-01-30 20:40 ` Jarkko Sakkinen
2021-01-30 20:47 ` Jarkko Sakkinen
[not found] ` <ghwnvtwifq.fsf@gouders.net>
2021-02-02 16:29 ` Jarkko Sakkinen
2021-02-02 15:51 ` [PATCH v3] " Lukasz Majczak
2021-02-02 16:29 ` Guenter Roeck
2021-02-02 22:35 ` Jarkko Sakkinen
2021-02-02 18:47 ` Dirk Gouders
2021-02-03 11:46 ` Dirk Gouders
2021-02-03 13:43 ` Lukasz Majczak
2021-02-03 23:24 ` Jarkko Sakkinen
2021-02-02 19:57 ` [PATCH v4] " Lukasz Majczak
2021-02-02 21:49 ` Jarkko Sakkinen
2021-02-02 21:49 ` [PATCH v3] " Jarkko Sakkinen
2021-02-03 0:05 ` Jarkko Sakkinen
2021-02-03 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a702108-ec9e-b2e2-be89-3590437c0eb5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=levinale@google.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lma@semihalf.com \
--cc=mw@semihalf.com \
--cc=peterhuewe@gmx.de \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).