From: Jarkko Sakkinen <jarkko@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: "Łukasz Majczak" <lma@semihalf.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Tj (Elloe Linux)" <ml.linux@elloe.vision>,
"Dirk Gouders" <dirk@gouders.net>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Alex Levin" <levinale@google.com>
Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls
Date: Thu, 28 Jan 2021 07:58:38 +0200 [thread overview]
Message-ID: <YBJSju6RX4LZx08N@kernel.org> (raw)
In-Reply-To: <a0249ad7b498e6f1cc065814350e145a07e92d37.camel@HansenPartnership.com>
On Tue, Jan 26, 2021 at 08:46:48AM -0800, James Bottomley wrote:
> On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote:
> > Hi Jarkko, Guenter
> >
> > Yes, here are the logs when failure occurs -
> > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9
> > Look for a phrase "TPM returned invalid status"
>
> We've had other reports of this:
>
> https://lore.kernel.org/linux-integrity/ghsgagsnag.fsf@gouders.net/
> https://lore.kernel.org/linux-integrity/374e918c-f167-9308-2bea-ae6bc6a3d2e3@elloe.vision/
>
> The problem is some TIS TPMs don't begin in the correct locality so we
> have to set it. When I proposed the check, I also proposed a fix for
> this problem:
>
> https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
>
> But it's part of a series that never went upstream. Part of the reason
> was Jarkko proposed the get/put patch to fix this instead, but that
> never went upstream either. We need to decide an approach and apply
> one or other fixes.
Can you remind me what I proposed? I remember only proposing removing
interrupt code.
Can you pick up just 1/5 and 2/5 from that serieis and send them as a
mini series?
I had one remark for 1/5, which can be found here:
https://lore.kernel.org/linux-integrity/20201024120744.GA32607@kernel.org/
I don't think there was never argument on locality changes.
/Jarkko
next prev parent reply other threads:[~2021-01-28 5:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 1:42 [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls Lukasz Majczak
2021-01-25 17:12 ` Jarkko Sakkinen
2021-01-25 17:18 ` Guenter Roeck
2021-01-26 15:46 ` Łukasz Majczak
2021-01-26 16:46 ` James Bottomley
2021-01-26 18:55 ` Tj (Elloe Linux)
2021-01-28 5:58 ` Jarkko Sakkinen [this message]
2021-01-29 22:59 ` Jarkko Sakkinen
2021-01-29 23:00 ` Jarkko Sakkinen
2021-01-30 23:49 ` Guenter Roeck
2021-01-31 0:41 ` James Bottomley
2021-01-31 3:36 ` Guenter Roeck
2021-01-31 4:18 ` James Bottomley
2021-02-02 16:17 ` Jarkko Sakkinen
2021-02-02 15:33 ` Jarkko Sakkinen
2021-01-29 22:49 ` Jarkko Sakkinen
2021-01-29 23:32 ` Guenter Roeck
2021-01-28 13:07 ` [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls Lukasz Majczak
2021-01-28 17:37 ` Guenter Roeck
2021-01-30 20:40 ` Jarkko Sakkinen
2021-01-30 20:47 ` Jarkko Sakkinen
[not found] ` <ghwnvtwifq.fsf@gouders.net>
2021-02-02 16:29 ` Jarkko Sakkinen
2021-02-02 15:51 ` [PATCH v3] " Lukasz Majczak
2021-02-02 16:29 ` Guenter Roeck
2021-02-02 22:35 ` Jarkko Sakkinen
2021-02-02 18:47 ` Dirk Gouders
2021-02-03 11:46 ` Dirk Gouders
2021-02-03 13:43 ` Lukasz Majczak
2021-02-03 23:24 ` Jarkko Sakkinen
2021-02-02 19:57 ` [PATCH v4] " Lukasz Majczak
2021-02-02 21:49 ` Jarkko Sakkinen
2021-02-02 21:49 ` [PATCH v3] " Jarkko Sakkinen
2021-02-03 0:05 ` Jarkko Sakkinen
2021-02-03 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBJSju6RX4LZx08N@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dirk@gouders.net \
--cc=jgg@ziepe.ca \
--cc=levinale@google.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lma@semihalf.com \
--cc=ml.linux@elloe.vision \
--cc=mw@semihalf.com \
--cc=peterhuewe@gmx.de \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).