From: Jarkko Sakkinen <jarkko@kernel.org>
To: Lukasz Majczak <lma@semihalf.com>,
Guenter Roeck <linux@roeck-us.net>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Tj <ml.linux@elloe.vision>, Dirk Gouders <dirk@gouders.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Radoslaw Biernacki <rad@semihalf.com>,
Marcin Wojtas <mw@semihalf.com>, Alex Levin <levinale@google.com>
Subject: Re: [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls
Date: Sat, 30 Jan 2021 22:47:43 +0200 [thread overview]
Message-ID: <ad016e07e5d8c8584981dfbc920eda9c80e3459a.camel@kernel.org> (raw)
In-Reply-To: <464454f440df67d3470e67ff0386bbc306d07dac.camel@kernel.org>
On Sat, 2021-01-30 at 22:40 +0200, Jarkko Sakkinen wrote:
> On Thu, 2021-01-28 at 14:07 +0100, Lukasz Majczak wrote:
> > There is a missing call to tpm_request_locality before the call to
> > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current
> > approach might work for tpm2, it fails for tpm1.x - in that case
> > call to tpm_get_timeouts() or tpm_tis_probe_irq_single()
> > without locality fails and in turn causes tpm_tis_core_init() to fail.
> > Tested on Samsung Chromebook Pro (Caroline).
> >
> > Signed-off-by: Lukasz Majczak <lma@semihalf.com>
>
> Is it possible that you test against linux-next and see if any
> problems still arise? I've applied the locality fixes from James.
Also one nit: if any problems still persist, please add a snippet
from klog to your commit message.
/Jarkko
next prev parent reply other threads:[~2021-01-30 20:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 1:42 [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls Lukasz Majczak
2021-01-25 17:12 ` Jarkko Sakkinen
2021-01-25 17:18 ` Guenter Roeck
2021-01-26 15:46 ` Łukasz Majczak
2021-01-26 16:46 ` James Bottomley
2021-01-26 18:55 ` Tj (Elloe Linux)
2021-01-28 5:58 ` Jarkko Sakkinen
2021-01-29 22:59 ` Jarkko Sakkinen
2021-01-29 23:00 ` Jarkko Sakkinen
2021-01-30 23:49 ` Guenter Roeck
2021-01-31 0:41 ` James Bottomley
2021-01-31 3:36 ` Guenter Roeck
2021-01-31 4:18 ` James Bottomley
2021-02-02 16:17 ` Jarkko Sakkinen
2021-02-02 15:33 ` Jarkko Sakkinen
2021-01-29 22:49 ` Jarkko Sakkinen
2021-01-29 23:32 ` Guenter Roeck
2021-01-28 13:07 ` [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls Lukasz Majczak
2021-01-28 17:37 ` Guenter Roeck
2021-01-30 20:40 ` Jarkko Sakkinen
2021-01-30 20:47 ` Jarkko Sakkinen [this message]
[not found] ` <ghwnvtwifq.fsf@gouders.net>
2021-02-02 16:29 ` Jarkko Sakkinen
2021-02-02 15:51 ` [PATCH v3] " Lukasz Majczak
2021-02-02 16:29 ` Guenter Roeck
2021-02-02 22:35 ` Jarkko Sakkinen
2021-02-02 18:47 ` Dirk Gouders
2021-02-03 11:46 ` Dirk Gouders
2021-02-03 13:43 ` Lukasz Majczak
2021-02-03 23:24 ` Jarkko Sakkinen
2021-02-02 19:57 ` [PATCH v4] " Lukasz Majczak
2021-02-02 21:49 ` Jarkko Sakkinen
2021-02-02 21:49 ` [PATCH v3] " Jarkko Sakkinen
2021-02-03 0:05 ` Jarkko Sakkinen
2021-02-03 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad016e07e5d8c8584981dfbc920eda9c80e3459a.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dirk@gouders.net \
--cc=jgg@ziepe.ca \
--cc=levinale@google.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lma@semihalf.com \
--cc=ml.linux@elloe.vision \
--cc=mw@semihalf.com \
--cc=peterhuewe@gmx.de \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).