* [PATCH 1/4] mm/init-mm: remove unused header cpumask.h
@ 2016-06-02 6:15 Geliang Tang
2016-06-02 6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
0 siblings, 1 reply; 9+ messages in thread
From: Geliang Tang @ 2016-06-02 6:15 UTC (permalink / raw)
To: Alexey Dobriyan, Andrew Morton; +Cc: Geliang Tang, linux-mm, linux-kernel
Remove unused header cpumask.h from mm/init-mm.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/init-mm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/init-mm.c b/mm/init-mm.c
index a56a851..2acae89 100644
--- a/mm/init-mm.c
+++ b/mm/init-mm.c
@@ -3,7 +3,6 @@
#include <linux/rwsem.h>
#include <linux/spinlock.h>
#include <linux/list.h>
-#include <linux/cpumask.h>
#include <linux/atomic.h>
#include <asm/pgtable.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h
2016-06-02 6:15 [PATCH 1/4] mm/init-mm: remove unused header cpumask.h Geliang Tang
@ 2016-06-02 6:15 ` Geliang Tang
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02 9:32 ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
0 siblings, 2 replies; 9+ messages in thread
From: Geliang Tang @ 2016-06-02 6:15 UTC (permalink / raw)
To: Catalin Marinas, Andrew Morton; +Cc: Geliang Tang, linux-mm, linux-kernel
Remove unused header cpumask.h from mm/kmemleak.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/kmemleak.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index e642992..2617309 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -82,7 +82,6 @@
#include <linux/fs.h>
#include <linux/debugfs.h>
#include <linux/seq_file.h>
-#include <linux/cpumask.h>
#include <linux/spinlock.h>
#include <linux/mutex.h>
#include <linux/rcupdate.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] mm/vmstat: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
@ 2016-06-02 6:15 ` Geliang Tang
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
` (2 more replies)
2016-06-02 9:32 ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
1 sibling, 3 replies; 9+ messages in thread
From: Geliang Tang @ 2016-06-02 6:15 UTC (permalink / raw)
To: Andrew Morton, Vlastimil Babka, Michal Hocko, Christoph Lameter,
Mel Gorman, Joonsoo Kim, Hugh Dickins
Cc: Geliang Tang, linux-mm, linux-kernel
Remove unused header cpumask.h from mm/vmstat.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/vmstat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 1b585f8..3653449 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -15,7 +15,6 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/cpu.h>
-#include <linux/cpumask.h>
#include <linux/vmstat.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
@ 2016-06-02 6:15 ` Geliang Tang
2016-06-02 7:10 ` Sergey Senozhatsky
2016-06-02 6:44 ` [PATCH 3/4] mm/vmstat: " Michal Hocko
2016-06-02 13:46 ` Christoph Lameter
2 siblings, 1 reply; 9+ messages in thread
From: Geliang Tang @ 2016-06-02 6:15 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton
Cc: Geliang Tang, linux-mm, linux-kernel
Remove unused header cpumask.h from mm/zsmalloc.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
mm/zsmalloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index b6d4f25..a93327e 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -57,7 +57,6 @@
#include <linux/slab.h>
#include <asm/tlbflush.h>
#include <asm/pgtable.h>
-#include <linux/cpumask.h>
#include <linux/cpu.h>
#include <linux/vmalloc.h>
#include <linux/preempt.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
@ 2016-06-02 6:44 ` Michal Hocko
2016-06-02 13:46 ` Christoph Lameter
2 siblings, 0 replies; 9+ messages in thread
From: Michal Hocko @ 2016-06-02 6:44 UTC (permalink / raw)
To: Geliang Tang
Cc: Andrew Morton, Vlastimil Babka, Christoph Lameter, Mel Gorman,
Joonsoo Kim, Hugh Dickins, linux-mm, linux-kernel
On Thu 02-06-16 14:15:35, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/vmstat.c.
what about for_each_online_cpu? Maybe it will get included transitively
from other header but I guess it is better to have a direct include
because transitive includes lead to unexpected compilation issues.
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> mm/vmstat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 1b585f8..3653449 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -15,7 +15,6 @@
> #include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/cpu.h>
> -#include <linux/cpumask.h>
> #include <linux/vmstat.h>
> #include <linux/proc_fs.h>
> #include <linux/seq_file.h>
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
@ 2016-06-02 7:10 ` Sergey Senozhatsky
0 siblings, 0 replies; 9+ messages in thread
From: Sergey Senozhatsky @ 2016-06-02 7:10 UTC (permalink / raw)
To: Geliang Tang
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton,
linux-mm, linux-kernel
On (06/02/16 14:15), Geliang Tang wrote:
> Remove unused header cpumask.h from mm/zsmalloc.c.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> mm/zsmalloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b6d4f25..a93327e 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -57,7 +57,6 @@
> #include <linux/slab.h>
> #include <asm/tlbflush.h>
> #include <asm/pgtable.h>
> -#include <linux/cpumask.h>
> #include <linux/cpu.h>
> #include <linux/vmalloc.h>
> #include <linux/preempt.h>
NAK. I don't think it's "unused".
zs_register_cpu_notifier()
for_each_online_cpu()
which is coming from include/linux/cpumask.h
#define for_each_online_cpu(cpu) for_each_cpu((cpu), cpu_online_mask)
-ss
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
@ 2016-06-02 9:32 ` Catalin Marinas
2016-06-02 10:10 ` Geliang Tang
1 sibling, 1 reply; 9+ messages in thread
From: Catalin Marinas @ 2016-06-02 9:32 UTC (permalink / raw)
To: Geliang Tang; +Cc: Andrew Morton, linux-mm, linux-kernel
On Thu, Jun 02, 2016 at 02:15:34PM +0800, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/kmemleak.c.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h
2016-06-02 9:32 ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
@ 2016-06-02 10:10 ` Geliang Tang
0 siblings, 0 replies; 9+ messages in thread
From: Geliang Tang @ 2016-06-02 10:10 UTC (permalink / raw)
To: Catalin Marinas, Andrew Morton; +Cc: linux-mm, linux-kernel
On Thu, Jun 02, 2016 at 10:32:41AM +0100, Catalin Marinas wrote:
> On Thu, Jun 02, 2016 at 02:15:34PM +0800, Geliang Tang wrote:
> > Remove unused header cpumask.h from mm/kmemleak.c.
> >
> > Signed-off-by: Geliang Tang <geliangtang@gmail.com>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
This patch is incorrect because for_each_possible_cpu() is defined in
cpumask.h. Sorry about that.
-Geliang
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
2016-06-02 6:44 ` [PATCH 3/4] mm/vmstat: " Michal Hocko
@ 2016-06-02 13:46 ` Christoph Lameter
2 siblings, 0 replies; 9+ messages in thread
From: Christoph Lameter @ 2016-06-02 13:46 UTC (permalink / raw)
To: Geliang Tang
Cc: Andrew Morton, Vlastimil Babka, Michal Hocko, Mel Gorman,
Joonsoo Kim, Hugh Dickins, linux-mm, linux-kernel
On Thu, 2 Jun 2016, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/vmstat.c.
cpu.h by necessity already includes cpumask.h. So I guess its ok.
Acked-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-02 13:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 6:15 [PATCH 1/4] mm/init-mm: remove unused header cpumask.h Geliang Tang
2016-06-02 6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
2016-06-02 7:10 ` Sergey Senozhatsky
2016-06-02 6:44 ` [PATCH 3/4] mm/vmstat: " Michal Hocko
2016-06-02 13:46 ` Christoph Lameter
2016-06-02 9:32 ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
2016-06-02 10:10 ` Geliang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).