From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>, Radim Krcmar <rkrcmar@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs
Date: Fri, 20 Jul 2018 10:04:23 +0200 [thread overview]
Message-ID: <825c953c-ec48-84cf-f1ca-bdee5d327427@redhat.com> (raw)
In-Reply-To: <CANRm+CwzG8jcsVhhGa2w55KcCTpwm-yokFR2Oi6LYaoS0ameqQ@mail.gmail.com>
On 20/07/2018 05:53, Wanpeng Li wrote:
>>> - ret = kvm_hypercall3(KVM_HC_SEND_IPI, ipi_bitmap_low, ipi_bitmap_high, vector);
>>> + switch (vector) {
>>> + default:
>>> + icr = APIC_DM_FIXED | vector;
>>> + break;
>>> + case NMI_VECTOR:
>>> + icr = APIC_DM_NMI;
>> I think it would be better to say that KVM interprets NMI_VECTOR and
>> sends the interrupt as APIC_DM_NMI.
It's not KVM, this is arch/x86/kernel/kvm.c so the guest side.
Paolo
> Yeah, in addition, SDM 10.6.1 also mentioned that:
> Delivery mode:
> 100 (NMI) Delivers an NMI interrupt to the target processor or
> processors. The vector information is ignored.
next prev parent reply other threads:[~2018-07-20 8:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 6:21 [PATCH v3 0/6] KVM: X86: Implement PV IPIs support Wanpeng Li
2018-07-03 6:21 ` [PATCH v3 1/6] KVM: X86: Add kvm hypervisor init time platform setup callback Wanpeng Li
2018-07-03 6:21 ` [PATCH v3 2/6] KVM: X86: Implement PV IPIs in linux guest Wanpeng Li
2018-07-19 16:28 ` Radim Krčmář
2018-07-19 16:47 ` Paolo Bonzini
2018-07-19 17:22 ` Radim Krčmář
2018-07-20 3:35 ` Wanpeng Li
2018-07-20 5:58 ` Wanpeng Li
2018-07-20 8:06 ` Paolo Bonzini
2018-07-20 3:33 ` Wanpeng Li
2018-07-20 9:51 ` Radim Krcmar
2018-07-20 10:17 ` Wanpeng Li
2018-07-19 23:05 ` David Matlack
2018-07-20 3:45 ` Wanpeng Li
2018-07-20 13:12 ` Radim Krcmar
2018-07-03 6:21 ` [PATCH v3 3/6] KVM: X86: Fallback to original apic hooks when bad happens Wanpeng Li
2018-07-03 6:21 ` [PATCH v3 4/6] KVM: X86: Implement PV IPIs send hypercall Wanpeng Li
2018-07-19 16:47 ` Paolo Bonzini
2018-07-20 3:49 ` Wanpeng Li
2018-07-03 6:21 ` [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs Wanpeng Li
2018-07-19 16:31 ` Radim Krčmář
2018-07-20 3:53 ` Wanpeng Li
2018-07-20 8:04 ` Paolo Bonzini [this message]
2018-07-20 13:26 ` Radim Krcmar
2018-07-23 0:52 ` Wanpeng Li
2018-07-03 6:21 ` [PATCH v3 6/6] KVM: X86: Expose PV_SEND_IPI CPUID feature bit to guest Wanpeng Li
2018-07-18 3:00 ` [PATCH v3 0/6] KVM: X86: Implement PV IPIs support Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825c953c-ec48-84cf-f1ca-bdee5d327427@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).