linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Vitaly Kuznetsov" <vkuznets@redhat.com>
Subject: Re: [PATCH v3 4/6] KVM: X86: Implement PV IPIs send hypercall
Date: Thu, 19 Jul 2018 18:47:01 +0200	[thread overview]
Message-ID: <a4f281c2-f189-ae23-bf86-2ea009b38357@redhat.com> (raw)
In-Reply-To: <1530598891-21370-5-git-send-email-wanpengli@tencent.com>

On 03/07/2018 08:21, Wanpeng Li wrote:
> +
> +	rcu_read_lock();
> +	map = rcu_dereference(kvm->arch.apic_map);
> +
> +	for_each_set_bit(i, &ipi_bitmap_low, BITS_PER_LONG) {
> +		vcpu = map->phys_map[i]->vcpu;
> +		if (!kvm_apic_set_irq(vcpu, &irq, NULL))
> +			return 1;
> +	}
> +
> +	for_each_set_bit(i, &ipi_bitmap_high, BITS_PER_LONG) {
> +		vcpu = map->phys_map[i + BITS_PER_LONG]->vcpu;
> +		if (!kvm_apic_set_irq(vcpu, &irq, NULL))
> +			return 1;
> +	}
> +

This should be the guest's BITS_PER_LONG, not the host's (i.e. you need
to pass op_64_bit from kvm_emulate_hypercall).

Thanks,

Paolo

  reply	other threads:[~2018-07-19 16:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03  6:21 [PATCH v3 0/6] KVM: X86: Implement PV IPIs support Wanpeng Li
2018-07-03  6:21 ` [PATCH v3 1/6] KVM: X86: Add kvm hypervisor init time platform setup callback Wanpeng Li
2018-07-03  6:21 ` [PATCH v3 2/6] KVM: X86: Implement PV IPIs in linux guest Wanpeng Li
2018-07-19 16:28   ` Radim Krčmář
2018-07-19 16:47     ` Paolo Bonzini
2018-07-19 17:22       ` Radim Krčmář
2018-07-20  3:35       ` Wanpeng Li
2018-07-20  5:58       ` Wanpeng Li
2018-07-20  8:06         ` Paolo Bonzini
2018-07-20  3:33     ` Wanpeng Li
2018-07-20  9:51       ` Radim Krcmar
2018-07-20 10:17         ` Wanpeng Li
2018-07-19 23:05   ` David Matlack
2018-07-20  3:45     ` Wanpeng Li
2018-07-20 13:12       ` Radim Krcmar
2018-07-03  6:21 ` [PATCH v3 3/6] KVM: X86: Fallback to original apic hooks when bad happens Wanpeng Li
2018-07-03  6:21 ` [PATCH v3 4/6] KVM: X86: Implement PV IPIs send hypercall Wanpeng Li
2018-07-19 16:47   ` Paolo Bonzini [this message]
2018-07-20  3:49     ` Wanpeng Li
2018-07-03  6:21 ` [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs Wanpeng Li
2018-07-19 16:31   ` Radim Krčmář
2018-07-20  3:53     ` Wanpeng Li
2018-07-20  8:04       ` Paolo Bonzini
2018-07-20 13:26         ` Radim Krcmar
2018-07-23  0:52           ` Wanpeng Li
2018-07-03  6:21 ` [PATCH v3 6/6] KVM: X86: Expose PV_SEND_IPI CPUID feature bit to guest Wanpeng Li
2018-07-18  3:00 ` [PATCH v3 0/6] KVM: X86: Implement PV IPIs support Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f281c2-f189-ae23-bf86-2ea009b38357@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).