* [PATCH] fbcon: Remove the superfluous break
@ 2020-09-17 13:15 Jing Xiangfeng
2020-09-17 17:36 ` Nick Desaulniers
2020-09-17 18:52 ` Gustavo A. R. Silva
0 siblings, 2 replies; 6+ messages in thread
From: Jing Xiangfeng @ 2020-09-17 13:15 UTC (permalink / raw)
To: b.zolnierkie, gregkh, daniel.vetter, jirislaby, ndesaulniers,
natechancellor, george.kennedy, peda
Cc: dri-devel, linux-fbdev, linux-kernel, jingxiangfeng
Remove the superfuous break, as there is a 'return' before it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/video/fbdev/core/fbcon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 0b49b0f44edf..623359aadd1e 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;
case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
@@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;
case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] fbcon: Remove the superfluous break
2020-09-17 13:15 [PATCH] fbcon: Remove the superfluous break Jing Xiangfeng
@ 2020-09-17 17:36 ` Nick Desaulniers
2020-09-18 0:50 ` Jing Xiangfeng
2020-09-17 18:52 ` Gustavo A. R. Silva
1 sibling, 1 reply; 6+ messages in thread
From: Nick Desaulniers @ 2020-09-17 17:36 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: Bartlomiej Zolnierkiewicz, Greg KH, daniel.vetter, jirislaby,
Nathan Chancellor, george.kennedy, peda, dri-devel, linux-fbdev,
LKML, Gustavo A. R. Silva, Joe Perches
On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> Remove the superfuous break, as there is a 'return' before it.
superfluous (missed "l")
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Thanks for the patch; I audited the rest of the switch statements in
this translation unit; LGTM.
> ---
> drivers/video/fbdev/core/fbcon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> --
> 2.17.1
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fbcon: Remove the superfluous break
2020-09-17 17:36 ` Nick Desaulniers
@ 2020-09-18 0:50 ` Jing Xiangfeng
0 siblings, 0 replies; 6+ messages in thread
From: Jing Xiangfeng @ 2020-09-18 0:50 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Bartlomiej Zolnierkiewicz, Greg KH, daniel.vetter, jirislaby,
Nathan Chancellor, george.kennedy, peda, dri-devel, linux-fbdev,
LKML, Gustavo A. R. Silva, Joe Perches
On 2020/9/18 1:36, Nick Desaulniers wrote:
> On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>>
>> Remove the superfuous break, as there is a 'return' before it.
>
> superfluous (missed "l")
Thanks for correcting!
>
>>
>> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Thanks for the patch; I audited the rest of the switch statements in
> this translation unit; LGTM.
>
>> ---
>> drivers/video/fbdev/core/fbcon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>> index 0b49b0f44edf..623359aadd1e 100644
>> --- a/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> --
>> 2.17.1
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbcon: Remove the superfluous break
2020-09-17 13:15 [PATCH] fbcon: Remove the superfluous break Jing Xiangfeng
2020-09-17 17:36 ` Nick Desaulniers
@ 2020-09-17 18:52 ` Gustavo A. R. Silva
2020-09-18 0:52 ` Jing Xiangfeng
1 sibling, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-09-17 18:52 UTC (permalink / raw)
To: Jing Xiangfeng, b.zolnierkie, gregkh, daniel.vetter, jirislaby,
ndesaulniers, natechancellor, george.kennedy, peda
Cc: dri-devel, linux-fbdev, linux-kernel
On 9/17/20 08:15, Jing Xiangfeng wrote:
> Remove the superfuous break, as there is a 'return' before it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Also, the following Fixes tag should be included in the changelog text:
Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
Thanks
--
Gustavo
> ---
> drivers/video/fbdev/core/fbcon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fbcon: Remove the superfluous break
2020-09-17 18:52 ` Gustavo A. R. Silva
@ 2020-09-18 0:52 ` Jing Xiangfeng
2020-09-18 12:43 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Jing Xiangfeng @ 2020-09-18 0:52 UTC (permalink / raw)
To: Gustavo A. R. Silva, b.zolnierkie, gregkh, daniel.vetter,
jirislaby, ndesaulniers, natechancellor, george.kennedy, peda
Cc: dri-devel, linux-fbdev, linux-kernel
On 2020/9/18 2:52, Gustavo A. R. Silva wrote:
>
>
> On 9/17/20 08:15, Jing Xiangfeng wrote:
>> Remove the superfuous break, as there is a 'return' before it.
>>
>> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Also, the following Fixes tag should be included in the changelog text:
>
> Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
OK, I'll send a v2 with this tag.
>
> Thanks
> --
> Gustavo
>
>> ---
>> drivers/video/fbdev/core/fbcon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>> index 0b49b0f44edf..623359aadd1e 100644
>> --- a/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fbcon: Remove the superfluous break
2020-09-18 0:52 ` Jing Xiangfeng
@ 2020-09-18 12:43 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2020-09-18 12:43 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: Gustavo A. R. Silva, b.zolnierkie, gregkh, daniel.vetter,
jirislaby, ndesaulniers, natechancellor, george.kennedy, peda,
dri-devel, linux-fbdev, linux-kernel
On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote:
>
>
> On 2020/9/18 2:52, Gustavo A. R. Silva wrote:
> >
> >
> > On 9/17/20 08:15, Jing Xiangfeng wrote:
> > > Remove the superfuous break, as there is a 'return' before it.
> > >
> > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> >
> > Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> >
> > Also, the following Fixes tag should be included in the changelog text:
> >
> > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
>
> OK, I'll send a v2 with this tag.
Please also collect all the r-b tags you received so I can just apply
everything.
-Daniel
>
> >
> > Thanks
> > --
> > Gustavo
> >
> > > ---
> > > drivers/video/fbdev/core/fbcon.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> > > index 0b49b0f44edf..623359aadd1e 100644
> > > --- a/drivers/video/fbdev/core/fbcon.c
> > > +++ b/drivers/video/fbdev/core/fbcon.c
> > > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > >
> > .
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-18 12:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 13:15 [PATCH] fbcon: Remove the superfluous break Jing Xiangfeng
2020-09-17 17:36 ` Nick Desaulniers
2020-09-18 0:50 ` Jing Xiangfeng
2020-09-17 18:52 ` Gustavo A. R. Silva
2020-09-18 0:52 ` Jing Xiangfeng
2020-09-18 12:43 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).