[PATCH V2 0/4] arm64: dts: ti: k3-j721e/j7200: Introduce EVM compatible

[PATCH V2 0/4] arm64: dts: ti: k3-j721e/j7200: Introduce EVM compatible

[Nishanth Menon]

Hi,

This is prep work for potentially introducing new platforms for
j721e/j7200 and brings these evms on par with AM65 and AM64 usage
models as well for consistency.

Changes since v1:
* Modified the series so that backward compatibility is still maintained
* No more conflict or dependence with [1].
* Added consistency to am642/am654 platforms as well.

V1: https://lore.kernel.org/all/20210915121937.27702-1-nm@ti.com/

Jan: This series will probably conflict with [2] - I'd rather we did
this cleanup before we introduce new platform patches, lets see if a
rebase and repost may be needed.

Nishanth Menon (4):
  dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms
  dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles
  arm64: dts: ti: k3-j721e-common-proc-board: Add j721e-evm compatible
  arm64: dts: ti: k3-j7200-common-proc-board: Add j7200-evm compatible

 .../devicetree/bindings/arm/ti/k3.yaml        | 35 +++++++++++++------
 .../dts/ti/k3-j7200-common-proc-board.dts     |  3 ++
 .../dts/ti/k3-j721e-common-proc-board.dts     |  3 ++
 3 files changed, 30 insertions(+), 11 deletions(-)

[1] https://lore.kernel.org/all/6a6a0d3a-522c-d01c-d3b8-a13488d0c736@ti.com/
[2] https://lore.kernel.org/all/336ade4715b3d2f5f83c3ed8f3fa2989f5699578.1631708830.git.jan.kiszka@siemens.com/
-- 
2.32.0

[PATCH V2 1/4] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

[Nishanth Menon]

Add compatibles for j721e and j7200 evms to allow for newer platforms
to distinguish themselves.

While doing this, maintain support for older style of description where
the board compatibility was not required.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes in V2:
* Modified such that legacy style of compatibles (of just SoC alone) is
  still valid
* Made the capability of providing a board specific compatible as an
  alternate scheme
* No longer dependent on rproc cleanup and platforms hosted in
  downstream trees remain compatible

V1: https://lore.kernel.org/all/20210915121937.27702-2-nm@ti.com/

 Documentation/devicetree/bindings/arm/ti/k3.yaml | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index c5aa362e4026..cefb06424a4a 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -28,12 +28,20 @@ properties:
           - const: ti,am654
 
       - description: K3 J721E SoC
-        items:
+        oneOf:
           - const: ti,j721e
+          - items:
+              - enum:
+                  - ti,j721e-evm
+              - const: ti,j721e
 
       - description: K3 J7200 SoC
-        items:
+        oneOf:
           - const: ti,j7200
+          - items:
+              - enum:
+                  - ti,j7200-evm
+              - const: ti,j7200
 
       - description: K3 AM642 SoC
         items:
-- 
2.32.0

Re: [PATCH V2 1/4] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

[Suman Anna]

On 9/25/21 3:14 PM, Nishanth Menon wrote:
> Add compatibles for j721e and j7200 evms to allow for newer platforms
> to distinguish themselves.
> 
> While doing this, maintain support for older style of description where
> the board compatibility was not required.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
> 
> Changes in V2:
> * Modified such that legacy style of compatibles (of just SoC alone) is
>   still valid
> * Made the capability of providing a board specific compatible as an
>   alternate scheme
> * No longer dependent on rproc cleanup and platforms hosted in
>   downstream trees remain compatible
> 
> V1: https://lore.kernel.org/all/20210915121937.27702-2-nm@ti.com/
> 
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index c5aa362e4026..cefb06424a4a 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -28,12 +28,20 @@ properties:
>            - const: ti,am654
>  
>        - description: K3 J721E SoC
> -        items:
> +        oneOf:
>            - const: ti,j721e
> +          - items:
> +              - enum:
> +                  - ti,j721e-evm
> +              - const: ti,j721e
>  
>        - description: K3 J7200 SoC
> -        items:
> +        oneOf:
>            - const: ti,j7200
> +          - items:
> +              - enum:
> +                  - ti,j7200-evm
> +              - const: ti,j7200
>  
>        - description: K3 AM642 SoC
>          items:
> 

Re: [PATCH V2 1/4] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

[Rob Herring]

On Sat, 25 Sep 2021 15:14:27 -0500, Nishanth Menon wrote:
> Add compatibles for j721e and j7200 evms to allow for newer platforms
> to distinguish themselves.
> 
> While doing this, maintain support for older style of description where
> the board compatibility was not required.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Changes in V2:
> * Modified such that legacy style of compatibles (of just SoC alone) is
>   still valid
> * Made the capability of providing a board specific compatible as an
>   alternate scheme
> * No longer dependent on rproc cleanup and platforms hosted in
>   downstream trees remain compatible
> 
> V1: https://lore.kernel.org/all/20210915121937.27702-2-nm@ti.com/
> 
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

[Nishanth Menon]

Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
just state SoC compatibles without specific board specific compatibles
aligned with what we have done for J721E/J7200 platforms as well.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Motivation to introduce in V2:
* Retain consistency with both "soc only" and "board specific" as two
  schemes we support across k3.

V1:  did'nt exist

 .../devicetree/bindings/arm/ti/k3.yaml        | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index cefb06424a4a..30c3f5c70014 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -20,12 +20,15 @@ properties:
     oneOf:
 
       - description: K3 AM654 SoC
-        items:
-          - enum:
-              - ti,am654-evm
-              - siemens,iot2050-basic
-              - siemens,iot2050-advanced
+        oneOf:
           - const: ti,am654
+          - items:
+              - enum:
+                  - ti,am654-evm
+                  - siemens,iot2050-basic
+                  - siemens,iot2050-advanced
+              - const: ti,am654
+
 
       - description: K3 J721E SoC
         oneOf:
@@ -44,11 +47,13 @@ properties:
               - const: ti,j7200
 
       - description: K3 AM642 SoC
-        items:
-          - enum:
-              - ti,am642-evm
-              - ti,am642-sk
+        oneOf:
           - const: ti,am642
+          - items:
+              - enum:
+                  - ti,am642-evm
+                  - ti,am642-sk
+              - const: ti,am642
 
 additionalProperties: true
 
-- 
2.32.0

Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

[Suman Anna]

On 9/25/21 3:14 PM, Nishanth Menon wrote:
> Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> just state SoC compatibles without specific board specific compatibles
> aligned with what we have done for J721E/J7200 platforms as well.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
> 
> Motivation to introduce in V2:
> * Retain consistency with both "soc only" and "board specific" as two
>   schemes we support across k3.

Thanks for the updates and making it consistent across the K3 platforms.

regards
Suman

> 
> V1:  did'nt exist
> 
>  .../devicetree/bindings/arm/ti/k3.yaml        | 23 +++++++++++--------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index cefb06424a4a..30c3f5c70014 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -20,12 +20,15 @@ properties:
>      oneOf:
>  
>        - description: K3 AM654 SoC
> -        items:
> -          - enum:
> -              - ti,am654-evm
> -              - siemens,iot2050-basic
> -              - siemens,iot2050-advanced
> +        oneOf:
>            - const: ti,am654
> +          - items:
> +              - enum:
> +                  - ti,am654-evm
> +                  - siemens,iot2050-basic
> +                  - siemens,iot2050-advanced
> +              - const: ti,am654
> +
>  
>        - description: K3 J721E SoC
>          oneOf:
> @@ -44,11 +47,13 @@ properties:
>                - const: ti,j7200
>  
>        - description: K3 AM642 SoC
> -        items:
> -          - enum:
> -              - ti,am642-evm
> -              - ti,am642-sk
> +        oneOf:
>            - const: ti,am642
> +          - items:
> +              - enum:
> +                  - ti,am642-evm
> +                  - ti,am642-sk
> +              - const: ti,am642
>  
>  additionalProperties: true
>  
> 

Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

[Rob Herring]

On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> just state SoC compatibles without specific board specific compatibles
> aligned with what we have done for J721E/J7200 platforms as well.

This is the wrong direction IMO. Why do you want this other than 
alignment?

> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Motivation to introduce in V2:
> * Retain consistency with both "soc only" and "board specific" as two
>   schemes we support across k3.
> 
> V1:  did'nt exist
> 
>  .../devicetree/bindings/arm/ti/k3.yaml        | 23 +++++++++++--------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index cefb06424a4a..30c3f5c70014 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -20,12 +20,15 @@ properties:
>      oneOf:
>  
>        - description: K3 AM654 SoC
> -        items:
> -          - enum:
> -              - ti,am654-evm
> -              - siemens,iot2050-basic
> -              - siemens,iot2050-advanced
> +        oneOf:
>            - const: ti,am654
> +          - items:
> +              - enum:
> +                  - ti,am654-evm
> +                  - siemens,iot2050-basic
> +                  - siemens,iot2050-advanced
> +              - const: ti,am654
> +
>  
>        - description: K3 J721E SoC
>          oneOf:
> @@ -44,11 +47,13 @@ properties:
>                - const: ti,j7200
>  
>        - description: K3 AM642 SoC
> -        items:
> -          - enum:
> -              - ti,am642-evm
> -              - ti,am642-sk
> +        oneOf:
>            - const: ti,am642
> +          - items:
> +              - enum:
> +                  - ti,am642-evm
> +                  - ti,am642-sk
> +              - const: ti,am642
>  
>  additionalProperties: true
>  
> -- 
> 2.32.0
> 
> 

Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

[Nishanth Menon]

On 12:54-20211004, Rob Herring wrote:
> On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> > Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> > just state SoC compatibles without specific board specific compatibles
> > aligned with what we have done for J721E/J7200 platforms as well.
> 
> This is the wrong direction IMO. Why do you want this other than 
> alignment?

Many downstream boards tend not to have an specific compatible at least
during initial phase and I would like folks to start using checks to
make sure that the easy to catch issues via match against bindings are
already handled.

I am curious as to why you think this is wrong - because we permit an
alternative option that allows the board files to be less specific?

[...]
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

[Nishanth Menon]

On 13:59-20211004, Nishanth Menon wrote:
> On 12:54-20211004, Rob Herring wrote:
> > On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> > > Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> > > just state SoC compatibles without specific board specific compatibles
> > > aligned with what we have done for J721E/J7200 platforms as well.
> > 
> > This is the wrong direction IMO. Why do you want this other than 
> > alignment?
> 
> Many downstream boards tend not to have an specific compatible at least
> during initial phase and I would like folks to start using checks to
> make sure that the easy to catch issues via match against bindings are
> already handled.
> 
> I am curious as to why you think this is wrong - because we permit an
> alternative option that allows the board files to be less specific?


Thinking again, I get the rationale. We are attempting to be specific,
and this patch reverses the direction. Agreed. Will drop applying this
patch. Also, for future SoCs, will insist on being specific compatible.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

[PATCH V2 3/4] arm64: dts: ti: k3-j721e-common-proc-board: Add j721e-evm compatible

[Nishanth Menon]

Add j721e-evm compatible to the board to allow the board to distinguish
itself from other platforms that are pending to be added.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes in V2:
* no change

V1: https://lore.kernel.org/all/20210915121937.27702-3-nm@ti.com/

 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 8bd02d9e28ad..dc2bc67f9f48 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -12,6 +12,9 @@
 #include <dt-bindings/phy/phy-cadence.h>
 
 / {
+	compatible = "ti,j721e-evm", "ti,j721e";
+	model = "Texas Instruments J721e EVM";
+
 	chosen {
 		stdout-path = "serial2:115200n8";
 		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
-- 
2.32.0

Re: [PATCH V2 3/4] arm64: dts: ti: k3-j721e-common-proc-board: Add j721e-evm compatible

[Suman Anna]

On 9/25/21 3:14 PM, Nishanth Menon wrote:
> Add j721e-evm compatible to the board to allow the board to distinguish
> itself from other platforms that are pending to be added.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
> 
> Changes in V2:
> * no change
> 
> V1: https://lore.kernel.org/all/20210915121937.27702-3-nm@ti.com/
> 
>  arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 8bd02d9e28ad..dc2bc67f9f48 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -12,6 +12,9 @@
>  #include <dt-bindings/phy/phy-cadence.h>
>  
>  / {
> +	compatible = "ti,j721e-evm", "ti,j721e";
> +	model = "Texas Instruments J721e EVM";
> +
>  	chosen {
>  		stdout-path = "serial2:115200n8";
>  		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
> 

[PATCH V2 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Add j7200-evm compatible

[Nishanth Menon]

Add j7200-evm compatible to the board to allow the board to distinguish
itself from other platforms that may be added in the future.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes in V2:
* no change

V1: https://lore.kernel.org/all/20210915121937.27702-4-nm@ti.com/

 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index d14f3c18b65f..121975dc8239 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -12,6 +12,9 @@
 #include <dt-bindings/phy/phy.h>
 
 / {
+	compatible = "ti,j7200-evm", "ti,j7200";
+	model = "Texas Instruments J7200 EVM";
+
 	chosen {
 		stdout-path = "serial2:115200n8";
 		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
-- 
2.32.0

Re: [PATCH V2 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Add j7200-evm compatible

[Suman Anna]

On 9/25/21 3:14 PM, Nishanth Menon wrote:
> Add j7200-evm compatible to the board to allow the board to distinguish
> itself from other platforms that may be added in the future.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
> 
> Changes in V2:
> * no change
> 
> V1: https://lore.kernel.org/all/20210915121937.27702-4-nm@ti.com/
> 
>  arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index d14f3c18b65f..121975dc8239 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -12,6 +12,9 @@
>  #include <dt-bindings/phy/phy.h>
>  
>  / {
> +	compatible = "ti,j7200-evm", "ti,j7200";
> +	model = "Texas Instruments J7200 EVM";
> +
>  	chosen {
>  		stdout-path = "serial2:115200n8";
>  		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
> 

Re: (subset) [PATCH V2 0/4] arm64: dts: ti: k3-j721e/j7200: Introduce EVM compatible

[Nishanth Menon]

On Sat, 25 Sep 2021 15:14:26 -0500, Nishanth Menon wrote:
> This is prep work for potentially introducing new platforms for
> j721e/j7200 and brings these evms on par with AM65 and AM64 usage
> models as well for consistency.
> 
> Changes since v1:
> * Modified the series so that backward compatibility is still maintained
> * No more conflict or dependence with [1].
> * Added consistency to am642/am654 platforms as well.
> 
> [...]

Hi Nishanth Menon,

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/4] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms
      commit: c4d269c95545929263bdd06392d4ef4791363bda
[3/4] arm64: dts: ti: k3-j721e-common-proc-board: Add j721e-evm compatible
      commit: c47eebaf4d76d995104e811b040d196082b880fd
[4/4] arm64: dts: ti: k3-j7200-common-proc-board: Add j7200-evm compatible
      commit: 2cf3213d2331526f00ca31a5b00450e920a03908


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D