From: yhlu <yhlu.kernel@gmail.com>
To: Roland Dreier <rolandd@cisco.com>,
linville@tuxdriver.com, gregkh@suse.de, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: mthca and LinuxBIOS
Date: Fri, 5 Aug 2005 12:45:25 -0700 [thread overview]
Message-ID: <86802c4405080512451cdcae48@mail.gmail.com> (raw)
In-Reply-To: <86802c4405080512254b9cd496@mail.gmail.com>
in drivers/pci/setup-res.c: pci_update_resource()
why????
new = 0; /* currently everyone zeros the high address */
if ((new & (PCI_BASE_ADDRESS_SPACE|PCI_BASE_ADDRESS_MEM_TYPE_MASK)) ==
(PCI_BASE_ADDRESS_SPACE_MEMORY|PCI_BASE_ADDRESS_MEM_TYPE_64)) {
new = 0; /* currently everyone zeros the high address */
pci_write_config_dword(dev, reg + 4, new);
pci_read_config_dword(dev, reg + 4, &check);
if (check != new) {
printk(KERN_ERR "PCI: Error updating region "
"%s/%d (high %08x != %08x)\n",
pci_name(dev), resno, new, check);
}
}
On 8/5/05, yhlu <yhlu.kernel@gmail.com> wrote:
> pci_restore_bars cause that.
> it didn't restore that according to if resource is 64 bit or not. So
> it overwirte upper 32 bit with 0.
>
> YH
>
> file:1b34fc56067ed8ae0ba9b32f46679e13068bb86c ->
> file:65ea7d25f6911d7396e19afbf4bb2738906376f7
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -222,6 +222,37 @@ pci_find_parent_resource(const struct pc
> }
> /**
> + * pci_restore_bars - restore a devices BAR values (e.g. after wake-up)
> + * @dev: PCI device to have its BARs restored
> + *
> + * Restore the BAR values for a given device, so as to make it
> + * accessible by its driver.
> + */
> +void
> +pci_restore_bars(struct pci_dev *dev)
> +{
> + int i, numres;
> +
> + switch (dev->hdr_type) {
> + case PCI_HEADER_TYPE_NORMAL:
> + numres = 6;
> + break;
> + case PCI_HEADER_TYPE_BRIDGE:
> + numres = 2;
> + break;
> + case PCI_HEADER_TYPE_CARDBUS:
> + numres = 1;
> + break;
> + default:
> + /* Should never get here, but just in case... */
> + return;
> + }
> +
> + for (i = 0; i < numres; i ++)
> + pci_update_resource(dev, &dev->resource[i], i);
> +}
> +
> +/**
>
> On 8/5/05, yhlu <yhlu.kernel@gmail.com> wrote:
> > before I do the cg-update this morning, it didn't mask out the upper 8 bit.
> >
> > YH
> >
> > On 8/5/05, Roland Dreier <rolandd@cisco.com> wrote:
> > > yhlu> ps. some kernel pci code patch broke sth yesterday night.
> > > yhlu> it mask out bit [32-39]
> > >
> > > Is it possible that all your problems are coming from the PCI setup
> > > code incorrectly assigning BARs?
> > >
> > > - R.
> > >
> >
>
next prev parent reply other threads:[~2005-08-05 19:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 20:31 [PATCH 0/2] REALLY final InfiniBand updates for 2.6.13 Roland Dreier
2005-07-28 20:31 ` [PATCH 1/2] [IB/cm]: Correct CM port redirect reject codes Roland Dreier
2005-07-28 20:31 ` [PATCH 2/2] [IPoIB] Handle sending of unicast RARP responses Roland Dreier
2005-08-04 0:58 ` [PATCH 1/2] [IB/cm]: Correct CM port redirect reject codes yhlu
2005-08-04 1:39 ` [openib-general] " Grant Grundler
2005-08-04 4:44 ` mthca and LinuxBIOS (was: [PATCH 1/2] [IB/cm]: Correct CM port redirect reject codes) Roland Dreier
2005-08-04 16:33 ` yhlu
2005-08-04 16:36 ` mthca and LinuxBIOS Roland Dreier
2005-08-04 17:23 ` yhlu
2005-08-04 18:01 ` yhlu
2005-08-04 18:35 ` Roland Dreier
2005-08-04 19:30 ` yhlu
2005-08-05 3:47 ` Roland Dreier
2005-08-05 18:03 ` yhlu
2005-08-05 18:07 ` yhlu
2005-08-05 18:13 ` Roland Dreier
2005-08-05 18:26 ` yhlu
2005-08-05 19:25 ` yhlu
2005-08-05 19:45 ` yhlu [this message]
2005-08-05 20:28 ` yhlu
2005-08-05 20:38 ` Linus Torvalds
2005-08-05 22:00 ` Greg KH
2005-08-05 22:25 ` yhlu
2005-08-05 23:03 ` Greg KH
2005-08-06 5:29 ` [openib-general] " Grant Grundler
2005-08-05 23:06 ` Linus Torvalds
2005-08-05 23:59 ` [openib-general] " Grant Grundler
2005-08-06 4:33 ` Grant Grundler
2005-08-06 23:52 ` yhlu
2005-08-07 9:49 ` Ivan Kokshaysky
2005-08-05 18:11 ` Roland Dreier
2005-08-06 0:57 ` yhlu
2005-08-06 1:30 ` Roland Dreier
2005-08-06 2:47 ` yhlu
2005-08-04 6:42 ` [PATCH 1/2] [IB/cm]: Correct CM port redirect reject codes Michael S. Tsirkin
2005-08-04 18:22 ` yhlu
2005-08-08 12:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c4405080512451cdcae48@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).