* rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
@ 2019-03-04 18:54 Helen Koike
2019-03-04 20:15 ` Stefan Wahren
2019-03-04 20:27 ` Eric Anholt
0 siblings, 2 replies; 5+ messages in thread
From: Helen Koike @ 2019-03-04 18:54 UTC (permalink / raw)
To: eric
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, stefan.wahren,
linus.walleij, lkundrak, bcm-kernel-feedback-list, devicetree,
kernel
Hello,
I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
driver, the HDMI wans't being detected.
So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
works correctly. I can see that modeprint from libdrm detects correctly
when the display is plugged and when it is unpluggled.
So I was wondering if this is just in my board or if there is an error
in the dts (which I think it's unlikely).
In any case I am dropping this email here in case anyone else see this
problem, if you do, try appliying the patch below.
Regards,
Helen
---
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@
};
&hdmi {
- hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+ hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
};
&pwm {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
2019-03-04 18:54 rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Helen Koike
@ 2019-03-04 20:15 ` Stefan Wahren
2019-03-04 21:52 ` Helen Koike
2019-03-04 20:27 ` Eric Anholt
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Wahren @ 2019-03-04 20:15 UTC (permalink / raw)
To: Helen Koike
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, linus.walleij,
lkundrak, bcm-kernel-feedback-list, eric, devicetree, kernel
Hi Helen,
> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 19:54 geschrieben:
>
>
> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.
thanks for your report and the patch. I verified your change against dt-blob.dts / downstream file and it's correct.
I'm sorry but i cannot apply your patch because it doesn't have the proper format.
Should i take care of this?
Can i add your Signed-off-by including your mail address?
Stefan
>
> Regards,
> Helen
>
> ---
> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> index 5641d162dfdb..28e7513ce617 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> @@ -93,7 +93,7 @@
> };
>
> &hdmi {
> - hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
> };
>
> &pwm {
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
2019-03-04 18:54 rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Helen Koike
2019-03-04 20:15 ` Stefan Wahren
@ 2019-03-04 20:27 ` Eric Anholt
2019-03-04 21:54 ` Helen Koike
1 sibling, 1 reply; 5+ messages in thread
From: Eric Anholt @ 2019-03-04 20:27 UTC (permalink / raw)
To: Helen Koike
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, stefan.wahren,
linus.walleij, lkundrak, bcm-kernel-feedback-list, devicetree,
kernel
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Helen Koike <helen.koike@collabora.com> writes:
> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.
We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts
agrees.
Reviewed-by: Eric Anholt <eric@anholt.net>
Thanks! If Stefan doesn't pick this up shortly, I can.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
2019-03-04 20:15 ` Stefan Wahren
@ 2019-03-04 21:52 ` Helen Koike
0 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2019-03-04 21:52 UTC (permalink / raw)
To: Stefan Wahren
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, linus.walleij,
lkundrak, bcm-kernel-feedback-list, eric, devicetree, kernel
On 3/4/19 5:15 PM, Stefan Wahren wrote:
> Hi Helen,
>
>> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 19:54 geschrieben:
>>
>>
>> Hello,
>>
>> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
>> driver, the HDMI wans't being detected.
>>
>> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
>> works correctly. I can see that modeprint from libdrm detects correctly
>> when the display is plugged and when it is unpluggled.
>>
>> So I was wondering if this is just in my board or if there is an error
>> in the dts (which I think it's unlikely).
>>
>> In any case I am dropping this email here in case anyone else see this
>> problem, if you do, try appliying the patch below.
>
> thanks for your report and the patch. I verified your change against dt-blob.dts / downstream file and it's correct.
>
> I'm sorry but i cannot apply your patch because it doesn't have the proper format.
>
> Should i take care of this?
> Can i add your Signed-off-by including your mail address?
I just resent it in a proper format, please check.
Thanks!
Helen
>
> Stefan
>
>>
>> Regards,
>> Helen
>>
>> ---
>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> index 5641d162dfdb..28e7513ce617 100644
>> --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
>> @@ -93,7 +93,7 @@
>> };
>>
>> &hdmi {
>> - hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
>> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
>> };
>>
>> &pwm {
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
2019-03-04 20:27 ` Eric Anholt
@ 2019-03-04 21:54 ` Helen Koike
0 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2019-03-04 21:54 UTC (permalink / raw)
To: Eric Anholt
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, stefan.wahren,
linus.walleij, lkundrak, bcm-kernel-feedback-list, devicetree,
kernel
On 3/4/19 5:27 PM, Eric Anholt wrote:
> Helen Koike <helen.koike@collabora.com> writes:
>
>> Hello,
>>
>> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
>> driver, the HDMI wans't being detected.
>>
>> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
>> works correctly. I can see that modeprint from libdrm detects correctly
>> when the display is plugged and when it is unpluggled.
>>
>> So I was wondering if this is just in my board or if there is an error
>> in the dts (which I think it's unlikely).
>>
>> In any case I am dropping this email here in case anyone else see this
>> problem, if you do, try appliying the patch below.
>
> We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts
> agrees.
You are right, I didn't notice it.
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
> Thanks! If Stefan doesn't pick this up shortly, I can.
>
Thanks for reviewing!
Helen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-04 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 18:54 rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Helen Koike
2019-03-04 20:15 ` Stefan Wahren
2019-03-04 21:52 ` Helen Koike
2019-03-04 20:27 ` Eric Anholt
2019-03-04 21:54 ` Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).