* [PATCH] fat: Expand a slightly out-of-date comment
@ 2018-09-27 15:00 Mihir Mehta
2018-09-28 10:32 ` OGAWA Hirofumi
0 siblings, 1 reply; 6+ messages in thread
From: Mihir Mehta @ 2018-09-27 15:00 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Mihir Mehta
The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
---
fs/fat/dir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index b833ffe..d954e18 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
}
memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ filenames, see msdos_format_name in namei_msdos.c */
if (work[0] == 0x05)
work[0] = 0xE5;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fat: Expand a slightly out-of-date comment
2018-09-27 15:00 [PATCH] fat: Expand a slightly out-of-date comment Mihir Mehta
@ 2018-09-28 10:32 ` OGAWA Hirofumi
2018-09-28 19:49 ` Mihir Mehta
0 siblings, 1 reply; 6+ messages in thread
From: OGAWA Hirofumi @ 2018-09-28 10:32 UTC (permalink / raw)
To: Mihir Mehta; +Cc: linux-kernel
Mihir Mehta <mihir@cs.utexas.edu> writes:
> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
> fs/fat/dir.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index b833ffe..d954e18 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
> }
>
> memcpy(work, de->name, sizeof(work));
> - /* see namei.c, msdos_format_name */
> + /* For an explanation of the special treatment of 0x05 in
> + filenames, see msdos_format_name in namei_msdos.c */
> if (work[0] == 0x05)
> work[0] = 0xE5;
Sorry. However, could you use
/*
*
*/
style comment? Otherwise, looks good.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] fat: Expand a slightly out-of-date comment
2018-09-28 10:32 ` OGAWA Hirofumi
@ 2018-09-28 19:49 ` Mihir Mehta
2018-09-29 10:04 ` OGAWA Hirofumi
2018-10-02 22:32 ` Andrew Morton
0 siblings, 2 replies; 6+ messages in thread
From: Mihir Mehta @ 2018-09-28 19:49 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Mihir Mehta
The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7f5f369..f4db13f 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
}
memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ * filenames, see msdos_format_name in namei_msdos.c
+ */
if (work[0] == 0x05)
work[0] = 0xE5;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fat: Expand a slightly out-of-date comment
2018-09-28 19:49 ` Mihir Mehta
@ 2018-09-29 10:04 ` OGAWA Hirofumi
2018-10-02 22:32 ` Andrew Morton
1 sibling, 0 replies; 6+ messages in thread
From: OGAWA Hirofumi @ 2018-09-29 10:04 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mihir Mehta, linux-kernel
Mihir Mehta <mihir@cs.utexas.edu> writes:
> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
> fs/fat/dir.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 7f5f369..f4db13f 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
> }
>
> memcpy(work, de->name, sizeof(work));
> - /* see namei.c, msdos_format_name */
> + /* For an explanation of the special treatment of 0x05 in
> + * filenames, see msdos_format_name in namei_msdos.c
> + */
> if (work[0] == 0x05)
> work[0] = 0xE5;
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fat: Expand a slightly out-of-date comment
2018-09-28 19:49 ` Mihir Mehta
2018-09-29 10:04 ` OGAWA Hirofumi
@ 2018-10-02 22:32 ` Andrew Morton
2018-10-02 23:48 ` Mihir Mehta
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2018-10-02 22:32 UTC (permalink / raw)
To: Mihir Mehta; +Cc: hirofumi, linux-kernel
On Fri, 28 Sep 2018 14:49:47 -0500 Mihir Mehta <mihir@cs.utexas.edu> wrote:
> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
Please send us a Signed-off-by: for this patch, as per
Documentation/process/submitting-patches.rst, section 11.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fat: Expand a slightly out-of-date comment
2018-10-02 22:32 ` Andrew Morton
@ 2018-10-02 23:48 ` Mihir Mehta
0 siblings, 0 replies; 6+ messages in thread
From: Mihir Mehta @ 2018-10-02 23:48 UTC (permalink / raw)
To: akpm; +Cc: hirofumi, linux-kernel, Mihir Mehta
The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
Signed-off-by: Mihir Mehta <mihir@cs.utexas.edu>
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7f5f369..ce5f958 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
}
memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ * filenames, see msdos_format_name in namei_msdos.c
+ */
if (work[0] == 0x05)
work[0] = 0xE5;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-02 23:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 15:00 [PATCH] fat: Expand a slightly out-of-date comment Mihir Mehta
2018-09-28 10:32 ` OGAWA Hirofumi
2018-09-28 19:49 ` Mihir Mehta
2018-09-29 10:04 ` OGAWA Hirofumi
2018-10-02 22:32 ` Andrew Morton
2018-10-02 23:48 ` Mihir Mehta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).