* [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message
[not found] ` <redmine.journal-710718.20160523104049.392ea8e63d81580c@dm.renesas.com>
@ 2016-05-24 5:24 ` Kuninori Morimoto
2016-05-24 13:32 ` Laurent Pinchart
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
1 sibling, 1 reply; 8+ messages in thread
From: Kuninori Morimoto @ 2016-05-24 5:24 UTC (permalink / raw)
To: Laurent Pinchart, David Airlie
Cc: dri-devel, linux-renesas-soc, linux-kernel, koji.matsuoka.xm,
yoshihiro.shimoda.uh, naoya.shiiba.nx, ryo.kodama.vz,
hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj, takeshi.kihara.df,
toshiaki.komatsu.ud, harunobu.kurokawa.dn, ryusuke.sakato.bx,
tomoharu.fukawa.eb, kouei.abe.cp, khiem.nguyen.xt, hien.dang.eb
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
EPROBE_DEFER is not error, thus, error message on kernel log on this
case is confusable for user. Prints it only error cases.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 26fd3ba..1db080c 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -354,14 +354,16 @@ static int rcar_du_probe(struct platform_device *pdev)
*/
ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to initialize vblank\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to initialize vblank\n");
goto error;
}
/* DRM/KMS objects */
ret = rcar_du_modeset_init(rcdu);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
goto error;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message
2016-05-24 5:24 ` [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
@ 2016-05-24 13:32 ` Laurent Pinchart
2016-05-25 0:13 ` Kuninori Morimoto
0 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2016-05-24 13:32 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel,
koji.matsuoka.xm, yoshihiro.shimoda.uh, naoya.shiiba.nx,
ryo.kodama.vz, hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj,
takeshi.kihara.df, toshiaki.komatsu.ud, harunobu.kurokawa.dn,
ryusuke.sakato.bx, tomoharu.fukawa.eb, kouei.abe.cp,
khiem.nguyen.xt, hien.dang.eb
Hi Morimoto-san,
Thank you for the patch.
On Tuesday 24 May 2016 14:24:09 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> EPROBE_DEFER is not error, thus, error message on kernel log on this
> case is confusable for user. Prints it only error cases.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 26fd3ba..1db080c 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -354,14 +354,16 @@ static int rcar_du_probe(struct platform_device *pdev)
> */
> ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
> if (ret < 0) {
> - dev_err(&pdev->dev, "failed to initialize vblank\n");
> + if (ret != -EPROBE_DEFER)
I don't think this can ever happen. Actually, the only reason
drm_vblank_init() could return an error at the moment is a kcalloc() failure,
so we could remove this message completely.
> + dev_err(&pdev->dev, "failed to initialize vblank\n");
> goto error;
> }
>
> /* DRM/KMS objects */
> ret = rcar_du_modeset_init(rcdu);
> if (ret < 0) {
> - dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
> goto error;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message
2016-05-24 13:32 ` Laurent Pinchart
@ 2016-05-25 0:13 ` Kuninori Morimoto
0 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2016-05-25 0:13 UTC (permalink / raw)
To: Laurent Pinchart
Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel,
koji.matsuoka.xm, yoshihiro.shimoda.uh, naoya.shiiba.nx,
ryo.kodama.vz, hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj,
takeshi.kihara.df, toshiaki.komatsu.ud, harunobu.kurokawa.dn,
ryusuke.sakato.bx, tomoharu.fukawa.eb, kouei.abe.cp,
khiem.nguyen.xt, hien.dang.eb
Hi Laurent
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > EPROBE_DEFER is not error, thus, error message on kernel log on this
> > case is confusable for user. Prints it only error cases.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 26fd3ba..1db080c 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -354,14 +354,16 @@ static int rcar_du_probe(struct platform_device *pdev)
> > */
> > ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
> > if (ret < 0) {
> > - dev_err(&pdev->dev, "failed to initialize vblank\n");
> > + if (ret != -EPROBE_DEFER)
>
> I don't think this can ever happen. Actually, the only reason
> drm_vblank_init() could return an error at the moment is a kcalloc() failure,
> so we could remove this message completely.
OK, will send v2 patch
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message
[not found] ` <redmine.journal-710718.20160523104049.392ea8e63d81580c@dm.renesas.com>
2016-05-24 5:24 ` [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
@ 2016-05-25 0:38 ` Kuninori Morimoto
2016-05-25 0:40 ` [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init() Kuninori Morimoto
` (3 more replies)
1 sibling, 4 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2016-05-25 0:38 UTC (permalink / raw)
To: Laurent Pinchart, David Airlie
Cc: dri-devel, linux-renesas-soc, linux-kernel, koji.matsuoka.xm,
yoshihiro.shimoda.uh, naoya.shiiba.nx, ryo.kodama.vz,
hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj, takeshi.kihara.df,
toshiaki.komatsu.ud, harunobu.kurokawa.dn, ryusuke.sakato.bx,
tomoharu.fukawa.eb, kouei.abe.cp, khiem.nguyen.xt, hien.dang.eb
Hi David, Laurent
These removes unneeded error message from Renesas DU driver.
Current this unneeded error message makes user confuse.
Kuninori Morimoto (2):
drm: rcar-du: error message is not needed for drm_vblank_init()
drm: rcar-du: error message is not needed for EPROBE_DEFER
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init()
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
@ 2016-05-25 0:40 ` Kuninori Morimoto
2016-05-25 0:41 ` [PATCH 2/2 v2] drm: rcar-du: error message is not needed for EPROBE_DEFER Kuninori Morimoto
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2016-05-25 0:40 UTC (permalink / raw)
To: Laurent Pinchart, David Airlie
Cc: dri-devel, linux-renesas-soc, linux-kernel, koji.matsuoka.xm,
yoshihiro.shimoda.uh, naoya.shiiba.nx, ryo.kodama.vz,
hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj, takeshi.kihara.df,
toshiaki.komatsu.ud, harunobu.kurokawa.dn, ryusuke.sakato.bx,
tomoharu.fukawa.eb, kouei.abe.cp, khiem.nguyen.xt, hien.dang.eb
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
The only reason drm_vblank_init() could return an error at the
moment is a kcalloc() failure.
So we can remove current error message completely.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- just removed error message
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 26fd3ba..786f5d6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -353,10 +353,8 @@ static int rcar_du_probe(struct platform_device *pdev)
* disabled for all CRTCs.
*/
ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to initialize vblank\n");
+ if (ret < 0)
goto error;
- }
/* DRM/KMS objects */
ret = rcar_du_modeset_init(rcdu);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2 v2] drm: rcar-du: error message is not needed for EPROBE_DEFER
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
2016-05-25 0:40 ` [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init() Kuninori Morimoto
@ 2016-05-25 0:41 ` Kuninori Morimoto
2016-06-09 3:03 ` [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
2016-06-10 21:07 ` Laurent Pinchart
3 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2016-05-25 0:41 UTC (permalink / raw)
To: Laurent Pinchart, David Airlie
Cc: dri-devel, linux-renesas-soc, linux-kernel, koji.matsuoka.xm,
yoshihiro.shimoda.uh, naoya.shiiba.nx, ryo.kodama.vz,
hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj, takeshi.kihara.df,
toshiaki.komatsu.ud, harunobu.kurokawa.dn, ryusuke.sakato.bx,
tomoharu.fukawa.eb, kouei.abe.cp, khiem.nguyen.xt, hien.dang.eb
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
EPROBE_DEFER is not error, thus, error message on kernel log on this
case is confusable. Print it only error cases
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- only for rcar_du_modeset_init()
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 786f5d6..cf2698e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -359,7 +359,8 @@ static int rcar_du_probe(struct platform_device *pdev)
/* DRM/KMS objects */
ret = rcar_du_modeset_init(rcdu);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
goto error;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
2016-05-25 0:40 ` [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init() Kuninori Morimoto
2016-05-25 0:41 ` [PATCH 2/2 v2] drm: rcar-du: error message is not needed for EPROBE_DEFER Kuninori Morimoto
@ 2016-06-09 3:03 ` Kuninori Morimoto
2016-06-10 21:07 ` Laurent Pinchart
3 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2016-06-09 3:03 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Laurent Pinchart, David Airlie, dri-devel, linux-renesas-soc,
linux-kernel, koji.matsuoka.xm, yoshihiro.shimoda.uh,
naoya.shiiba.nx, ryo.kodama.vz, hiroyuki.yokoyama.vx,
yoshifumi.hosoya.wj, takeshi.kihara.df, toshiaki.komatsu.ud,
harunobu.kurokawa.dn, ryusuke.sakato.bx, tomoharu.fukawa.eb,
kouei.abe.cp, khiem.nguyen.xt, hien.dang.eb
Hi David
ping ?
> These removes unneeded error message from Renesas DU driver.
> Current this unneeded error message makes user confuse.
>
> Kuninori Morimoto (2):
> drm: rcar-du: error message is not needed for drm_vblank_init()
> drm: rcar-du: error message is not needed for EPROBE_DEFER
>
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
` (2 preceding siblings ...)
2016-06-09 3:03 ` [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
@ 2016-06-10 21:07 ` Laurent Pinchart
3 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-06-10 21:07 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel,
koji.matsuoka.xm, yoshihiro.shimoda.uh, naoya.shiiba.nx,
ryo.kodama.vz, hiroyuki.yokoyama.vx, yoshifumi.hosoya.wj,
takeshi.kihara.df, toshiaki.komatsu.ud, harunobu.kurokawa.dn,
ryusuke.sakato.bx, tomoharu.fukawa.eb, kouei.abe.cp,
khiem.nguyen.xt, hien.dang.eb
Hi Morimoto-san,
On Wednesday 25 May 2016 00:38:48 Kuninori Morimoto wrote:
> Hi David, Laurent
>
> These removes unneeded error message from Renesas DU driver.
> Current this unneeded error message makes user confuse.
Thank you for the patches. For both of them,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I've applied them to my tree and include them in my next pull request.
> Kuninori Morimoto (2):
> drm: rcar-du: error message is not needed for drm_vblank_init()
> drm: rcar-du: error message is not needed for EPROBE_DEFER
>
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-10 21:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <redmine.issue-77851.20151006064038@dm.renesas.com>
[not found] ` <redmine.journal-710718.20160523104049.392ea8e63d81580c@dm.renesas.com>
2016-05-24 5:24 ` [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
2016-05-24 13:32 ` Laurent Pinchart
2016-05-25 0:13 ` Kuninori Morimoto
2016-05-25 0:38 ` [PATCH 0/2 v2] " Kuninori Morimoto
2016-05-25 0:40 ` [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init() Kuninori Morimoto
2016-05-25 0:41 ` [PATCH 2/2 v2] drm: rcar-du: error message is not needed for EPROBE_DEFER Kuninori Morimoto
2016-06-09 3:03 ` [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
2016-06-10 21:07 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).