* [PATCH] x86/gpu: GLK uses the same GMS values as SKL
@ 2017-01-24 18:47 Paulo Zanoni
2017-01-25 7:29 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Paulo Zanoni @ 2017-01-24 18:47 UTC (permalink / raw)
To: intel-gfx
Cc: x86, linux-kernel, Paulo Zanoni, Ingo Molnar, H . Peter Anvin,
Ander Conselvan de Oliveira
So don't forget to reserve its stolen memory bits.
Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: x86@kernel.org
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
arch/x86/kernel/early-quirks.c | 1 +
1 file changed, 1 insertion(+)
Found by code inspection. This is completely untested since I don't have
GLK hardware.
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6a08e25..23c4f1c 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
INTEL_SKL_IDS(&gen9_early_ops),
INTEL_BXT_IDS(&gen9_early_ops),
INTEL_KBL_IDS(&gen9_early_ops),
+ INTEL_GLK_IDS(&gen9_early_ops),
};
static void __init
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL
2017-01-24 18:47 [PATCH] x86/gpu: GLK uses the same GMS values as SKL Paulo Zanoni
@ 2017-01-25 7:29 ` Ingo Molnar
2017-01-25 11:31 ` [Intel-gfx] " Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2017-01-25 7:29 UTC (permalink / raw)
To: Paulo Zanoni
Cc: intel-gfx, x86, linux-kernel, H . Peter Anvin,
Ander Conselvan de Oliveira, Rodrigo Vivi, Dhinakaran Pandiyan
* Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> So don't forget to reserve its stolen memory bits.
>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: x86@kernel.org
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Found by code inspection. This is completely untested since I don't have
> GLK hardware.
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6a08e25..23c4f1c 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_SKL_IDS(&gen9_early_ops),
> INTEL_BXT_IDS(&gen9_early_ops),
> INTEL_KBL_IDS(&gen9_early_ops),
> + INTEL_GLK_IDS(&gen9_early_ops),
> };
There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
changes to the i915 GPU driver?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL
2017-01-25 7:29 ` Ingo Molnar
@ 2017-01-25 11:31 ` Jani Nikula
2017-01-25 11:33 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2017-01-25 11:31 UTC (permalink / raw)
To: Ingo Molnar, Paulo Zanoni
Cc: Ander Conselvan de Oliveira, H . Peter Anvin, intel-gfx, x86,
linux-kernel, Dhinakaran Pandiyan, Rodrigo Vivi, Daniel Vetter
On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>
>> So don't forget to reserve its stolen memory bits.
>>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Cc: x86@kernel.org
>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> ---
>> arch/x86/kernel/early-quirks.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Found by code inspection. This is completely untested since I don't have
>> GLK hardware.
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index 6a08e25..23c4f1c 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>> INTEL_SKL_IDS(&gen9_early_ops),
>> INTEL_BXT_IDS(&gen9_early_ops),
>> INTEL_KBL_IDS(&gen9_early_ops),
>> + INTEL_GLK_IDS(&gen9_early_ops),
>> };
>
> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
> changes to the i915 GPU driver?
It's in our -next. Ack for merging this through drm-intel along with the
deps?
BR,
Jani.
>
> Thanks,
>
> Ingo
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL
2017-01-25 11:31 ` [Intel-gfx] " Jani Nikula
@ 2017-01-25 11:33 ` Jani Nikula
2017-01-25 11:37 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2017-01-25 11:33 UTC (permalink / raw)
To: Ingo Molnar, Paulo Zanoni
Cc: Ander Conselvan de Oliveira, H . Peter Anvin, intel-gfx, x86,
linux-kernel, Dhinakaran Pandiyan, Rodrigo Vivi, Daniel Vetter
(Now without the typo in Daniel's address; apologies for the extra
noise.)
On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>> arch/x86/kernel/early-quirks.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>>
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>> INTEL_SKL_IDS(&gen9_early_ops),
>>> INTEL_BXT_IDS(&gen9_early_ops),
>>> INTEL_KBL_IDS(&gen9_early_ops),
>>> + INTEL_GLK_IDS(&gen9_early_ops),
>>> };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL
2017-01-25 11:33 ` Jani Nikula
@ 2017-01-25 11:37 ` Ingo Molnar
0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2017-01-25 11:37 UTC (permalink / raw)
To: Jani Nikula
Cc: Paulo Zanoni, Ander Conselvan de Oliveira, H . Peter Anvin,
intel-gfx, x86, linux-kernel, Dhinakaran Pandiyan, Rodrigo Vivi,
Daniel Vetter
* Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>>
> >>> Cc: Ingo Molnar <mingo@kernel.org>
> >>> Cc: H. Peter Anvin <hpa@zytor.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Cc: x86@kernel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>> ---
> >>> arch/x86/kernel/early-quirks.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>>
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>> INTEL_SKL_IDS(&gen9_early_ops),
> >>> INTEL_BXT_IDS(&gen9_early_ops),
> >>> INTEL_KBL_IDS(&gen9_early_ops),
> >>> + INTEL_GLK_IDS(&gen9_early_ops),
> >>> };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?
Yeah, LGTM:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-25 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 18:47 [PATCH] x86/gpu: GLK uses the same GMS values as SKL Paulo Zanoni
2017-01-25 7:29 ` Ingo Molnar
2017-01-25 11:31 ` [Intel-gfx] " Jani Nikula
2017-01-25 11:33 ` Jani Nikula
2017-01-25 11:37 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).