* Re: [PATCH] Re: PPPoE Oops with 2.4.22-rc
[not found] ` <fa.k5266bj.136mf8l@ifi.uio.no>
@ 2003-08-22 20:55 ` Junio C Hamano
2003-08-22 21:12 ` Marcus Sundberg
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2003-08-22 20:55 UTC (permalink / raw)
To: Marcus Sundberg; +Cc: linux-kernel
>>>>> "MS" == Marcus Sundberg <marcus@ingate.com> writes:
MS> this patch fixes one crash in pppoe_connect():
--- linux-2.4.21-rc2/drivers/net/pppoe.c~ Wed May 14 00:08:52 2003
+++ linux-2.4.21-rc2/drivers/net/pppoe.c Wed May 14 00:18:47 2003
@@ -606,7 +606,8 @@
/* Delete the old binding */
delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
- dev_put(po->pppoe_dev);
+ if (po->pppoe_dev)
+ dev_put(po->pppoe_dev);
memset(po, 0, sizeof(struct pppox_opt));
po->sk = sk;
Could you explain when/how pppoe_connect gets called with
(pppoe_dev == NULL) but with an old binding?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Re: PPPoE Oops with 2.4.22-rc
2003-08-22 20:55 ` [PATCH] Re: PPPoE Oops with 2.4.22-rc Junio C Hamano
@ 2003-08-22 21:12 ` Marcus Sundberg
2003-08-25 12:57 ` Greg Stark
0 siblings, 1 reply; 5+ messages in thread
From: Marcus Sundberg @ 2003-08-22 21:12 UTC (permalink / raw)
To: Junio C Hamano; +Cc: linux-kernel
Junio C Hamano <junkio@cox.net> writes:
> >>>>> "MS" == Marcus Sundberg <marcus@ingate.com> writes:
>
> MS> this patch fixes one crash in pppoe_connect():
>
> --- linux-2.4.21-rc2/drivers/net/pppoe.c~ Wed May 14 00:08:52 2003
> +++ linux-2.4.21-rc2/drivers/net/pppoe.c Wed May 14 00:18:47 2003
> @@ -606,7 +606,8 @@
> /* Delete the old binding */
> delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
>
> - dev_put(po->pppoe_dev);
> + if (po->pppoe_dev)
> + dev_put(po->pppoe_dev);
>
> memset(po, 0, sizeof(struct pppox_opt));
> po->sk = sk;
>
> Could you explain when/how pppoe_connect gets called with
> (pppoe_dev == NULL) but with an old binding?
I triggered it by doing 'ifconfig down' on the underlying ethernet
device. It's possible there are other ways to trigger it also. When
I made the fix I just looked at where the oops occured.
//Marcus
--
---------------------------------------+--------------------------
Marcus Sundberg <marcus@ingate.com> | Firewalls with SIP & NAT
Firewall Developer, Ingate Systems AB | http://www.ingate.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Re: PPPoE Oops with 2.4.22-rc
2003-08-22 21:12 ` Marcus Sundberg
@ 2003-08-25 12:57 ` Greg Stark
0 siblings, 0 replies; 5+ messages in thread
From: Greg Stark @ 2003-08-25 12:57 UTC (permalink / raw)
To: Marcus Sundberg; +Cc: Junio C Hamano, linux-kernel
Marcus Sundberg <marcus@ingate.com> writes:
> I triggered it by doing 'ifconfig down' on the underlying ethernet
> device. It's possible there are other ways to trigger it also.
Thank you. This has been a bug for a little while. I reported it with 2.4.20 a
few months ago.
--
greg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Re: PPPoE Oops with 2.4.22-rc
2003-08-22 13:43 ` [PATCH] " Marcus Sundberg
@ 2003-08-22 16:54 ` David S. Miller
0 siblings, 0 replies; 5+ messages in thread
From: David S. Miller @ 2003-08-22 16:54 UTC (permalink / raw)
To: Marcus Sundberg; +Cc: marcelo, gzp, mostrows, linux-kernel
On 22 Aug 2003 15:43:01 +0200
Marcus Sundberg <marcus@ingate.com> wrote:
> this patch fixes one crash in pppoe_connect():
It's already in Marcelo's tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Re: PPPoE Oops with 2.4.22-rc
2003-08-12 18:05 ` Gabor Z. Papp
@ 2003-08-22 13:43 ` Marcus Sundberg
2003-08-22 16:54 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Marcus Sundberg @ 2003-08-22 13:43 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Gabor Z. Papp, mostrows, linux-kernel
Hi,
this patch fixes one crash in pppoe_connect():
--- linux-2.4.21-rc2/drivers/net/pppoe.c~ Wed May 14 00:08:52 2003
+++ linux-2.4.21-rc2/drivers/net/pppoe.c Wed May 14 00:18:47 2003
@@ -606,7 +606,8 @@
/* Delete the old binding */
delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
- dev_put(po->pppoe_dev);
+ if (po->pppoe_dev)
+ dev_put(po->pppoe_dev);
memset(po, 0, sizeof(struct pppox_opt));
po->sk = sk;
//Marcus
--
---------------------------------------+--------------------------
Marcus Sundberg <marcus@ingate.com> | Firewalls with SIP & NAT
Firewall Developer, Ingate Systems AB | http://www.ingate.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-08-25 12:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <fa.fl74mr0.184m51s@ifi.uio.no>
[not found] ` <fa.k5266bj.136mf8l@ifi.uio.no>
2003-08-22 20:55 ` [PATCH] Re: PPPoE Oops with 2.4.22-rc Junio C Hamano
2003-08-22 21:12 ` Marcus Sundberg
2003-08-25 12:57 ` Greg Stark
2003-08-12 6:42 Gabor Z. Papp
2003-08-12 17:16 ` Marcelo Tosatti
2003-08-12 18:05 ` Gabor Z. Papp
2003-08-22 13:43 ` [PATCH] " Marcus Sundberg
2003-08-22 16:54 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).