From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751
Date: Thu, 30 Jun 2016 23:52:00 +0900 [thread overview]
Message-ID: <87y45md90v.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <4273068.i3RgB4Ufiy@wuerfel>
On Wed, 29 Jun 2016 23:57:50 +0900,
Arnd Bergmann wrote:
>
> On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote:
> > + interrupt-map = <0x0000 0 1 &cpldintc 0 0>,
> > + 0x0800 0 1 &cpldintc 1 0>,
> > + 0x1000 0 1 &cpldintc 2 0>,
> > + 0x1800 0 1 &cpldintc 3 0>,
> > + 0x1800 0 2 &cpldintc 0 0>;
>
> I just noticed the typo: you have more closing '>' than opening '<'
> here, so this is not valid syntax.
Oh.
It too old files. I mistake commit.
> > +
> > +static __refdata struct platform_driver sh7751_pci_driver = {
> > + .driver = {
> > + .name = "sh7751-pci",
> > + .of_match_table = sh7751_pci_of_match,
> > + },
> > + .probe = sh7751_pci_probe,
> > +};
> > +builtin_platform_driver(sh7751_pci_driver);
>
> I think you need to add '.suppress_bind_attrs = true' to prevent
> the device to be unbound and rebound through sysfs, otherwise
> the __init annotation on the probe function is wrong.
Yes. This target hot add don't use.
It flag required.
> Everything else looks fine to me now.
OK.
Thanks.
> Arnd
>
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next prev parent reply other threads:[~2016-06-30 14:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 13:40 [PATCH v4 00/22] sh: LANDISK and R2Dplus convert to device tree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 01/22] sh: Add sh-specific early_init_dt_reserve_memory_arch Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 02/22] sh: More early unflatten device tree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 03/22] sh: set preset_lpj Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 04/22] sh: Use P1SEGADDR Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 05/22] sh: command line passing chosen/bootargs in devicetree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 06/22] sh: FDT address save before bank change Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 07/22] sh: Passing FDT address on zImage Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 08/22] sh: Disable board specific code on device tree mode Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 09/22] sh: Use GENERIC_IOMAP " Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 10/22] sh: Add board specific initialize of of-generic Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 11/22] sh: SH7750/51 CPG Driver Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 Yoshinori Sato
2016-06-29 14:57 ` Arnd Bergmann
2016-06-30 14:52 ` Yoshinori Sato [this message]
2016-07-01 1:43 ` Rob Herring
2016-06-29 13:40 ` [PATCH v4 13/22] sh: irqchip: SH7751 IRQCHIP Driver Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 14/22] sh: SH7751 core dtsi Yoshinori Sato
2016-07-01 8:57 ` Geert Uytterhoeven
2016-07-03 11:34 ` Yoshinori Sato
2016-07-04 7:15 ` Geert Uytterhoeven
2016-07-04 16:12 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 15/22] sh: Move common PCI stuff to arch/sh/kernel Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 16/22] pci: pci_config_window move to linux/pci.h Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 17/22] pci: PCI_HOST_GENERIC enable for SH Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 18/22] sh: Add separate DTB build rule Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 19/22] sh: IO-DATA HDL-U (a,k.a landisk) IRQCHIP driver Yoshinori Sato
2016-06-29 13:43 ` John Paul Adrian Glaubitz
2016-07-01 1:48 ` Rob Herring
2016-07-03 11:36 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 20/22] sh: IO-DATA HDL-U (a,k.a landisk) DeviceTree Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 21/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) IRQCHIP Driver Yoshinori Sato
2016-07-01 1:53 ` Rob Herring
2016-07-03 11:35 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree Yoshinori Sato
2016-06-29 14:16 ` Sergei Shtylyov
2016-06-30 14:47 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y45md90v.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).