From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree
Date: Thu, 30 Jun 2016 23:47:37 +0900 [thread overview]
Message-ID: <87ziq2d986.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <c13b9615-6bfd-1e16-ffb8-f2c7b7a817b8@cogentembedded.com>
On Wed, 29 Jun 2016 23:16:52 +0900,
Sergei Shtylyov wrote:
>
> On 06/29/2016 04:41 PM, Yoshinori Sato wrote:
>
> > Changes v4
> > - split patch
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> [...]
>
> > diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts
> > new file mode 100644
> > index 0000000..a1a0745
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/r2dplus.dts
> > @@ -0,0 +1,83 @@
> > +/dts-v1/;
> > +
> > +#include "sh7751.dtsi"
> > +
> > +/ {
> > + model = "Renesas RTS7751R2D+";
>
> The ePAPR standard says:
>
> The recommended format is: “manufacturer,model”, where manufacturer
> is a string describing the name of the manufacturer (such as a stock
> ticker symbol), and model specifies the model number.
OK.
I lookd ePAPR standard.
> > + compatible = "renesas,r2dplus";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + interrupt-parent = <&shintc>;
> > + chosen {
> > + stdout-path = &sci1;
> > + bootargs = "console=ttySC1,115200";
> > + };
> > + aliases {
> > + serial1 = &sci1;
> > + };
> > +
> > + memory@0c000000 {
> > + device_type = "memory";
> > + reg = <0x0c000000 0x4000000>;
> > + };
>
> Need empty line here...
>
> > + fpgaintc: fpga@a4000000 {
> > + compatible = "renesas,r2dplus-intc";
> > + #interrupt-cells = <1>;
> > + interrupt-controller;
> > + reg = <0xa4000000 0x40>;
> > + interrupt-map=<0 &shintc evt2irq(0x200)>,
> > + <1 &shintc evt2irq(0x220)>,
> > + <2 &shintc evt2irq(0x240)>,
> > + <3 &shintc evt2irq(0x260)>,
> > + <4 &shintc evt2irq(0x280)>,
> > + <5 &shintc evt2irq(0x2a0)>,
> > + <6 &shintc evt2irq(0x2c0)>,
> > + <7 &shintc evt2irq(0x2e0)>,
> > + <8 &shintc evt2irq(0x300)>,
> > + <9 &shintc evt2irq(0x320)>,
> > + <10 &shintc evt2irq(0x340)>,
> > + <11 &shintc evt2irq(0x360)>,
> > + <12 &shintc evt2irq(0x380)>,
> > + <13 &shintc evt2irq(0x3a0)>,
> > + <14 &shintc evt2irq(0x3c0)>;
> > + };
> > + pata: pata@b4001000 {
>
> This node should be named "ide@..." to comply with ePAPR.
OK.
Thanks.
> MBR, Sergei
>
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
prev parent reply other threads:[~2016-06-30 14:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 13:40 [PATCH v4 00/22] sh: LANDISK and R2Dplus convert to device tree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 01/22] sh: Add sh-specific early_init_dt_reserve_memory_arch Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 02/22] sh: More early unflatten device tree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 03/22] sh: set preset_lpj Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 04/22] sh: Use P1SEGADDR Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 05/22] sh: command line passing chosen/bootargs in devicetree Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 06/22] sh: FDT address save before bank change Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 07/22] sh: Passing FDT address on zImage Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 08/22] sh: Disable board specific code on device tree mode Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 09/22] sh: Use GENERIC_IOMAP " Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 10/22] sh: Add board specific initialize of of-generic Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 11/22] sh: SH7750/51 CPG Driver Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 Yoshinori Sato
2016-06-29 14:57 ` Arnd Bergmann
2016-06-30 14:52 ` Yoshinori Sato
2016-07-01 1:43 ` Rob Herring
2016-06-29 13:40 ` [PATCH v4 13/22] sh: irqchip: SH7751 IRQCHIP Driver Yoshinori Sato
2016-06-29 13:40 ` [PATCH v4 14/22] sh: SH7751 core dtsi Yoshinori Sato
2016-07-01 8:57 ` Geert Uytterhoeven
2016-07-03 11:34 ` Yoshinori Sato
2016-07-04 7:15 ` Geert Uytterhoeven
2016-07-04 16:12 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 15/22] sh: Move common PCI stuff to arch/sh/kernel Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 16/22] pci: pci_config_window move to linux/pci.h Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 17/22] pci: PCI_HOST_GENERIC enable for SH Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 18/22] sh: Add separate DTB build rule Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 19/22] sh: IO-DATA HDL-U (a,k.a landisk) IRQCHIP driver Yoshinori Sato
2016-06-29 13:43 ` John Paul Adrian Glaubitz
2016-07-01 1:48 ` Rob Herring
2016-07-03 11:36 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 20/22] sh: IO-DATA HDL-U (a,k.a landisk) DeviceTree Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 21/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) IRQCHIP Driver Yoshinori Sato
2016-07-01 1:53 ` Rob Herring
2016-07-03 11:35 ` Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree Yoshinori Sato
2016-06-29 14:16 ` Sergei Shtylyov
2016-06-30 14:47 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziq2d986.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).