From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set
Date: Wed, 19 Aug 2020 20:09:11 -0700 [thread overview]
Message-ID: <88afdd4a-1b30-d836-05ce-8919b834579b@infradead.org> (raw)
In-Reply-To: <a020884b-fa44-e732-699f-2b79c9b7d15e@infradead.org>
Hi Konrad,
ping.
I am still seeing this build error. It looks like this is
in your territory to merge...
On 8/13/20 4:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_ACPI is not set/enabled:
>
> ../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
> ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> acpi_noirq_set();
>
> Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-pci@vger.kernel.org
> ---
> arch/x86/pci/xen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200813.orig/arch/x86/pci/xen.c
> +++ linux-next-20200813/arch/x86/pci/xen.c
> @@ -26,6 +26,7 @@
> #include <asm/xen/pci.h>
> #include <asm/xen/cpuid.h>
> #include <asm/apic.h>
> +#include <asm/acpi.h>
> #include <asm/i8259.h>
>
> static int xen_pcifront_enable_irq(struct pci_dev *dev)
>
thanks.
--
~Randy
next prev parent reply other threads:[~2020-08-20 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 23:00 [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set Randy Dunlap
2020-08-20 3:09 ` Randy Dunlap [this message]
2020-08-20 14:40 ` Konrad Rzeszutek Wilk
2020-08-20 14:48 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88afdd4a-1b30-d836-05ce-8919b834579b@infradead.org \
--to=rdunlap@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).