* [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set
@ 2020-08-13 23:00 Randy Dunlap
2020-08-20 3:09 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-08-13 23:00 UTC (permalink / raw)
To: LKML, linux-pci, Andy Shevchenko, Bjorn Helgaas
Cc: Konrad Rzeszutek Wilk, xen-devel
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error when CONFIG_ACPI is not set/enabled:
../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
acpi_noirq_set();
Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org
Cc: linux-pci@vger.kernel.org
---
arch/x86/pci/xen.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200813.orig/arch/x86/pci/xen.c
+++ linux-next-20200813/arch/x86/pci/xen.c
@@ -26,6 +26,7 @@
#include <asm/xen/pci.h>
#include <asm/xen/cpuid.h>
#include <asm/apic.h>
+#include <asm/acpi.h>
#include <asm/i8259.h>
static int xen_pcifront_enable_irq(struct pci_dev *dev)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set
2020-08-13 23:00 [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set Randy Dunlap
@ 2020-08-20 3:09 ` Randy Dunlap
2020-08-20 14:40 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-08-20 3:09 UTC (permalink / raw)
To: LKML, linux-pci, Andy Shevchenko, Bjorn Helgaas
Cc: Konrad Rzeszutek Wilk, xen-devel
Hi Konrad,
ping.
I am still seeing this build error. It looks like this is
in your territory to merge...
On 8/13/20 4:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_ACPI is not set/enabled:
>
> ../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
> ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> acpi_noirq_set();
>
> Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-pci@vger.kernel.org
> ---
> arch/x86/pci/xen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200813.orig/arch/x86/pci/xen.c
> +++ linux-next-20200813/arch/x86/pci/xen.c
> @@ -26,6 +26,7 @@
> #include <asm/xen/pci.h>
> #include <asm/xen/cpuid.h>
> #include <asm/apic.h>
> +#include <asm/acpi.h>
> #include <asm/i8259.h>
>
> static int xen_pcifront_enable_irq(struct pci_dev *dev)
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set
2020-08-20 3:09 ` Randy Dunlap
@ 2020-08-20 14:40 ` Konrad Rzeszutek Wilk
2020-08-20 14:48 ` Jürgen Groß
0 siblings, 1 reply; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2020-08-20 14:40 UTC (permalink / raw)
To: Randy Dunlap, jgross, Boris Ostrovsky
Cc: LKML, linux-pci, Andy Shevchenko, Bjorn Helgaas, xen-devel
On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote:
> Hi Konrad,
Hey Randy,
I believe Juergen is picking this up.
>
> ping.
>
> I am still seeing this build error. It looks like this is
> in your territory to merge...
>
>
> On 8/13/20 4:00 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix build error when CONFIG_ACPI is not set/enabled:
> >
> > ../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
> > ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> > acpi_noirq_set();
> >
> > Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Cc: xen-devel@lists.xenproject.org
> > Cc: linux-pci@vger.kernel.org
> > ---
> > arch/x86/pci/xen.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20200813.orig/arch/x86/pci/xen.c
> > +++ linux-next-20200813/arch/x86/pci/xen.c
> > @@ -26,6 +26,7 @@
> > #include <asm/xen/pci.h>
> > #include <asm/xen/cpuid.h>
> > #include <asm/apic.h>
> > +#include <asm/acpi.h>
> > #include <asm/i8259.h>
> >
> > static int xen_pcifront_enable_irq(struct pci_dev *dev)
> >
>
>
> thanks.
> --
> ~Randy
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set
2020-08-20 14:40 ` Konrad Rzeszutek Wilk
@ 2020-08-20 14:48 ` Jürgen Groß
0 siblings, 0 replies; 4+ messages in thread
From: Jürgen Groß @ 2020-08-20 14:48 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Randy Dunlap, Boris Ostrovsky
Cc: LKML, linux-pci, Andy Shevchenko, Bjorn Helgaas, xen-devel
On 20.08.20 16:40, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote:
>> Hi Konrad,
>
> Hey Randy,
>
> I believe Juergen is picking this up.
Yes, have queued it for rc2.
Juergen
>>
>> ping.
>>
>> I am still seeing this build error. It looks like this is
>> in your territory to merge...
>>
>>
>> On 8/13/20 4:00 PM, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Fix build error when CONFIG_ACPI is not set/enabled:
>>>
>>> ../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
>>> ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
>>> acpi_noirq_set();
>>>
>>> Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> Cc: xen-devel@lists.xenproject.org
>>> Cc: linux-pci@vger.kernel.org
>>> ---
>>> arch/x86/pci/xen.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> --- linux-next-20200813.orig/arch/x86/pci/xen.c
>>> +++ linux-next-20200813/arch/x86/pci/xen.c
>>> @@ -26,6 +26,7 @@
>>> #include <asm/xen/pci.h>
>>> #include <asm/xen/cpuid.h>
>>> #include <asm/apic.h>
>>> +#include <asm/acpi.h>
>>> #include <asm/i8259.h>
>>>
>>> static int xen_pcifront_enable_irq(struct pci_dev *dev)
>>>
>>
>>
>> thanks.
>> --
>> ~Randy
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-20 14:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 23:00 [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set Randy Dunlap
2020-08-20 3:09 ` Randy Dunlap
2020-08-20 14:40 ` Konrad Rzeszutek Wilk
2020-08-20 14:48 ` Jürgen Groß
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).