* [PATCH -next RESEND] tracing: fix iomap.h build warnings
@ 2019-08-31 20:25 Randy Dunlap
2019-09-01 21:10 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-08-31 20:25 UTC (permalink / raw)
To: LKML, Christoph Hellwig, Darrick J . Wong; +Cc: Steven Rostedt
From: Randy Dunlap <rdunlap@infradead.org>
Fix 30 warnings for missing "struct inode" declaration (like these) by
adding a forward reference for it.
These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
CC include/trace/events/iomap.h.s
./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Darrick J. Wong <darrick.wong@oracle.com>
---
Resend to correct maintainer(s).
include/trace/events/iomap.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20190829.orig/include/trace/events/iomap.h
+++ linux-next-20190829/include/trace/events/iomap.h
@@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
__entry->length)
)
+struct inode;
+
#define DEFINE_PAGE_EVENT(name) \
DEFINE_EVENT(iomap_page_class, name, \
TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next RESEND] tracing: fix iomap.h build warnings
2019-08-31 20:25 [PATCH -next RESEND] tracing: fix iomap.h build warnings Randy Dunlap
@ 2019-09-01 21:10 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-09-01 21:10 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Christoph Hellwig, Steven Rostedt
On Sat, Aug 31, 2019 at 01:25:37PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix 30 warnings for missing "struct inode" declaration (like these) by
> adding a forward reference for it.
> These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
> CC include/trace/events/iomap.h.s
>
> ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> Resend to correct maintainer(s).
Looks ok, will add it to my tree. Thanks for the patch. :)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> include/trace/events/iomap.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20190829.orig/include/trace/events/iomap.h
> +++ linux-next-20190829/include/trace/events/iomap.h
> @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
> __entry->length)
> )
>
> +struct inode;
> +
> #define DEFINE_PAGE_EVENT(name) \
> DEFINE_EVENT(iomap_page_class, name, \
> TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-01 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-31 20:25 [PATCH -next RESEND] tracing: fix iomap.h build warnings Randy Dunlap
2019-09-01 21:10 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).