From: Rik van Riel <riel@surriel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Barret Rhoden <brho@google.com>,
Josh Bleecher Snyder <josharian@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/fpu: Don't cache access to fpu_fpregs_owner_ctx
Date: Wed, 27 Nov 2019 10:46:51 -0500 [thread overview]
Message-ID: <8aadfbebed6502f21ba91a823e118770b84e31d2.camel@surriel.com> (raw)
In-Reply-To: <20191127124243.u74osvlkhcmsskng@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Wed, 2019-11-27 at 13:42 +0100, Sebastian Andrzej Siewior wrote:
> There is no Sign-off by here. Could this please be verified by the
> reporter?
Next time this is posted, feel free to add this :)
Reviewed-by: Rik van Riel <riel@surriel.com>
> diff --git a/arch/x86/include/asm/fpu/internal.h
> b/arch/x86/include/asm/fpu/internal.h
> index 4c95c365058aa..44c48e34d7994 100644
> --- a/arch/x86/include/asm/fpu/internal.h
> +++ b/arch/x86/include/asm/fpu/internal.h
> @@ -509,7 +509,7 @@ static inline void
> __fpu_invalidate_fpregs_state(struct fpu *fpu)
>
> static inline int fpregs_state_valid(struct fpu *fpu, unsigned int
> cpu)
> {
> - return fpu == this_cpu_read_stable(fpu_fpregs_owner_ctx) && cpu
> == fpu->last_cpu;
> + return fpu == this_cpu_read(fpu_fpregs_owner_ctx) && cpu ==
> fpu->last_cpu;
> }
>
> /*
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-11-27 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 19:49 AVX register corruption from signal delivery Barret Rhoden
2019-11-26 20:20 ` Sebastian Andrzej Siewior
2019-11-26 21:23 ` Barret Rhoden
2019-11-26 22:13 ` Borislav Petkov
2019-11-26 22:30 ` Andy Lutomirski
2019-11-26 23:00 ` Borislav Petkov
2019-11-27 12:42 ` [PATCH] x86/fpu: Don't cache access to fpu_fpregs_owner_ctx Sebastian Andrzej Siewior
2019-11-27 14:07 ` Borislav Petkov
2019-11-27 18:42 ` Barret Rhoden
2019-11-28 8:53 ` [PATCH v2] " Sebastian Andrzej Siewior
2019-11-28 9:22 ` [tip: x86/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2019-11-29 16:57 ` [PATCH v2] " David Laight
2019-11-29 17:08 ` 'Sebastian Andrzej Siewior'
2019-11-27 15:46 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aadfbebed6502f21ba91a823e118770b84e31d2.camel@surriel.com \
--to=riel@surriel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=brho@google.com \
--cc=josharian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).