* [PATCH 1/3] ARM: dts: vf610: Add PWM second instance
2014-09-17 8:16 [PATCH 0/3] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
@ 2014-09-17 8:16 ` Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2 siblings, 0 replies; 8+ messages in thread
From: Bhuvanchandra DV @ 2014-09-17 8:16 UTC (permalink / raw)
To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index 4d2ec32..fb00f13 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -210,6 +210,19 @@
status = "disabled";
};
+ pwm1: pwm@40039000 {
+ compatible = "fsl,vf610-ftm-pwm";
+ #pwm-cells = <3>;
+ reg = <0x40039000 0x1000>;
+ clock-names = "ftm_sys", "ftm_ext",
+ "ftm_fix", "ftm_cnt_clk_en";
+ clocks = <&clks VF610_CLK_FTM1>,
+ <&clks VF610_CLK_FTM1_EXT_SEL>,
+ <&clks VF610_CLK_FTM1_FIX_SEL>,
+ <&clks VF610_CLK_FTM1_EXT_FIX_EN>;
+ status = "disabled";
+ };
+
adc0: adc@4003b000 {
compatible = "fsl,vf610-adc";
reg = <0x4003b000 0x1000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support
2014-09-17 8:16 [PATCH 0/3] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 1/3] ARM: dts: vf610: Add PWM second instance Bhuvanchandra DV
@ 2014-09-17 8:16 ` Bhuvanchandra DV
2014-09-18 14:12 ` Shawn Guo
2014-09-17 8:16 ` [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2 siblings, 1 reply; 8+ messages in thread
From: Bhuvanchandra DV @ 2014-09-17 8:16 UTC (permalink / raw)
To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV
The Colibri standard defines four pins as PWM outputs, two of them (PWM
A and C) are routed to FTM instance 0 and the other two (PWM B and D)
are routed to FTM instance 1. Hence enable both FTM instances for the
Colibri module and mux the four pins accordingly.
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++
arch/arm/boot/dts/vf610-colibri.dtsi | 25 +++++++++++++++++++++++++
2 files changed, 33 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
index 7fb3066..ba98039 100644
--- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
@@ -44,3 +44,11 @@
&uart2 {
status = "okay";
};
+
+&pwm0 {
+ status = "okay";
+};
+
+&pwm1 {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
index 0cd8343..9bd1415 100644
--- a/arch/arm/boot/dts/vf610-colibri.dtsi
+++ b/arch/arm/boot/dts/vf610-colibri.dtsi
@@ -69,6 +69,16 @@
status = "okay";
};
+&pwm0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0>;
+};
+
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm1>;
+};
+
&iomuxc {
vf610-colibri {
pinctrl_esdhc1: esdhc1grp {
@@ -119,5 +129,20 @@
VF610_PAD_PTD3__UART2_CTS 0x21a1
>;
};
+
+ pinctrl_pwm0: pwm0grp {
+ fsl,pins = <
+ VF610_PAD_PTB0__FTM0_CH0 0x1182
+ VF610_PAD_PTB1__FTM0_CH1 0x1182
+ >;
+ };
+
+ pinctrl_pwm1: pwm1grp {
+ fsl,pins = <
+ VF610_PAD_PTB8__FTM1_CH0 0x1182
+ VF610_PAD_PTB9__FTM1_CH1 0x1182
+ >;
+ };
+
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support
2014-09-17 8:16 ` [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
@ 2014-09-18 14:12 ` Shawn Guo
2014-09-19 10:19 ` Bhuvanchandra DV
0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2014-09-18 14:12 UTC (permalink / raw)
To: Bhuvanchandra DV; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Wed, Sep 17, 2014 at 01:46:29PM +0530, Bhuvanchandra DV wrote:
> The Colibri standard defines four pins as PWM outputs, two of them (PWM
> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
> are routed to FTM instance 1. Hence enable both FTM instances for the
> Colibri module and mux the four pins accordingly.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++
> arch/arm/boot/dts/vf610-colibri.dtsi | 25 +++++++++++++++++++++++++
> 2 files changed, 33 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> index 7fb3066..ba98039 100644
> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> @@ -44,3 +44,11 @@
> &uart2 {
> status = "okay";
> };
> +
> +&pwm0 {
> + status = "okay";
> +};
> +
> +&pwm1 {
> + status = "okay";
> +};
Please sort the node alphabetically, so that we can locate them more
easily.
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 0cd8343..9bd1415 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -69,6 +69,16 @@
> status = "okay";
> };
>
> +&pwm0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm0>;
> +};
> +
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1>;
> +};
> +
Ditto
> &iomuxc {
> vf610-colibri {
> pinctrl_esdhc1: esdhc1grp {
> @@ -119,5 +129,20 @@
> VF610_PAD_PTD3__UART2_CTS 0x21a1
> >;
> };
> +
> + pinctrl_pwm0: pwm0grp {
We also maintain the alphabetic order of pinctrl_* entries under iomuxc
node.
Shawn
> + fsl,pins = <
> + VF610_PAD_PTB0__FTM0_CH0 0x1182
> + VF610_PAD_PTB1__FTM0_CH1 0x1182
> + >;
> + };
> +
> + pinctrl_pwm1: pwm1grp {
> + fsl,pins = <
> + VF610_PAD_PTB8__FTM1_CH0 0x1182
> + VF610_PAD_PTB9__FTM1_CH1 0x1182
> + >;
> + };
> +
> };
> };
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support
2014-09-18 14:12 ` Shawn Guo
@ 2014-09-19 10:19 ` Bhuvanchandra DV
0 siblings, 0 replies; 8+ messages in thread
From: Bhuvanchandra DV @ 2014-09-19 10:19 UTC (permalink / raw)
To: Shawn Guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Thursday 18 September 2014 07:42 PM, Shawn Guo wrote:
> On Wed, Sep 17, 2014 at 01:46:29PM +0530, Bhuvanchandra DV wrote:
>> The Colibri standard defines four pins as PWM outputs, two of them (PWM
>> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
>> are routed to FTM instance 1. Hence enable both FTM instances for the
>> Colibri module and mux the four pins accordingly.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 ++++++++
>> arch/arm/boot/dts/vf610-colibri.dtsi | 25 +++++++++++++++++++++++++
>> 2 files changed, 33 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index 7fb3066..ba98039 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -44,3 +44,11 @@
>> &uart2 {
>> status = "okay";
>> };
>> +
>> +&pwm0 {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
> Please sort the node alphabetically, so that we can locate them more
> easily.
Ok, will sort the nodes alphabetically
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..9bd1415 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -69,6 +69,16 @@
>> status = "okay";
>> };
>>
>> +&pwm0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm0>;
>> +};
>> +
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> +};
>> +
> Ditto
Ok
>> &iomuxc {
>> vf610-colibri {
>> pinctrl_esdhc1: esdhc1grp {
>> @@ -119,5 +129,20 @@
>> VF610_PAD_PTD3__UART2_CTS 0x21a1
>> >;
>> };
>> +
>> + pinctrl_pwm0: pwm0grp {
> We also maintain the alphabetic order of pinctrl_* entries under iomuxc
> node.
>
> Shawn
Ok
>> + fsl,pins = <
>> + VF610_PAD_PTB0__FTM0_CH0 0x1182
>> + VF610_PAD_PTB1__FTM0_CH1 0x1182
>> + >;
>> + };
>> +
>> + pinctrl_pwm1: pwm1grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB8__FTM1_CH0 0x1182
>> + VF610_PAD_PTB9__FTM1_CH1 0x1182
>> + >;
>> + };
>> +
>> };
>> };
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support
2014-09-17 8:16 [PATCH 0/3] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 1/3] ARM: dts: vf610: Add PWM second instance Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
@ 2014-09-17 8:16 ` Bhuvanchandra DV
2014-09-18 14:17 ` Shawn Guo
2 siblings, 1 reply; 8+ messages in thread
From: Bhuvanchandra DV @ 2014-09-17 8:16 UTC (permalink / raw)
To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++
arch/arm/boot/dts/vf610-colibri.dtsi | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
index ba98039..f1988a0 100644
--- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
@@ -52,3 +52,9 @@
&pwm1 {
status = "okay";
};
+
+&backlight {
+ brightness-levels = <0 4 8 16 32 64 128 255>;
+ default-brightness-level = <6>;
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
index 9bd1415..e725306 100644
--- a/arch/arm/boot/dts/vf610-colibri.dtsi
+++ b/arch/arm/boot/dts/vf610-colibri.dtsi
@@ -25,6 +25,13 @@
};
};
+ backlight: bl {
+ compitable = "pwm-backlight";
+ pwms = <&pwm0 0 5000000 0>;
+ pwm-names = " backlight";
+ status = "disabled";
+ };
+
};
&esdhc1 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support
2014-09-17 8:16 ` [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
@ 2014-09-18 14:17 ` Shawn Guo
2014-09-19 10:27 ` Bhuvanchandra DV
0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2014-09-18 14:17 UTC (permalink / raw)
To: Bhuvanchandra DV; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Wed, Sep 17, 2014 at 01:46:30PM +0530, Bhuvanchandra DV wrote:
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++
> arch/arm/boot/dts/vf610-colibri.dtsi | 7 +++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> index ba98039..f1988a0 100644
> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> @@ -52,3 +52,9 @@
> &pwm1 {
> status = "okay";
> };
> +
> +&backlight {
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness-level = <6>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 9bd1415..e725306 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -25,6 +25,13 @@
> };
> };
>
> + backlight: bl {
I would suggest we name the node following the example in
Documentation/devicetree/bindings/pwm/pwm.txt, i.e. bl: backlight.
> + compitable = "pwm-backlight";
> + pwms = <&pwm0 0 5000000 0>;
> + pwm-names = " backlight";
Drop the leading space in the string.
Shawn
> + status = "disabled";
> + };
> +
> };
>
> &esdhc1 {
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support
2014-09-18 14:17 ` Shawn Guo
@ 2014-09-19 10:27 ` Bhuvanchandra DV
0 siblings, 0 replies; 8+ messages in thread
From: Bhuvanchandra DV @ 2014-09-19 10:27 UTC (permalink / raw)
To: Shawn Guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel
On Thursday 18 September 2014 07:47 PM, Shawn Guo wrote:
> On Wed, Sep 17, 2014 at 01:46:30PM +0530, Bhuvanchandra DV wrote:
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++
>> arch/arm/boot/dts/vf610-colibri.dtsi | 7 +++++++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index ba98039..f1988a0 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -52,3 +52,9 @@
>> &pwm1 {
>> status = "okay";
>> };
>> +
>> +&backlight {
>> + brightness-levels = <0 4 8 16 32 64 128 255>;
>> + default-brightness-level = <6>;
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 9bd1415..e725306 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -25,6 +25,13 @@
>> };
>> };
>>
>> + backlight: bl {
> I would suggest we name the node following the example in
> Documentation/devicetree/bindings/pwm/pwm.txt, i.e. bl: backlight.
Will update the node name to bl: backlight
>> + compitable = "pwm-backlight";
>> + pwms = <&pwm0 0 5000000 0>;
>> + pwm-names = " backlight";
> Drop the leading space in the string.
>
> Shawn
Ok
>> + status = "disabled";
>> + };
>> +
>> };
>>
>> &esdhc1 {
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 8+ messages in thread