linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Natarajan, Janakarajan" <Janakarajan.Natarajan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] Support for perf on AMD family17h processors
Date: Wed, 16 Nov 2016 14:49:29 -0600	[thread overview]
Message-ID: <8bd06d95-1d43-934c-4112-016f1c076585@amd.com> (raw)
In-Reply-To: <20161116184726.4rkhsoxx35mr7pdz@pd.tnic>


On 11/16/2016 12:47 PM, Borislav Petkov wrote:
> On Wed, Nov 16, 2016 at 11:01:53AM -0600, Janakarajan Natarajan wrote:
>> This patch enables perf core PMU support for AMD family17h processors.
>> In family17h, there is no PMC-event constraint. All events, irrespective
>> of the type, can be measured using any of the performance counters.
>>
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
>> ---
>>   arch/x86/events/amd/core.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
>> index f5f4b3f..849688d 100644
>> --- a/arch/x86/events/amd/core.c
>> +++ b/arch/x86/events/amd/core.c
>> @@ -652,7 +652,11 @@ static __initconst const struct x86_pmu amd_pmu = {
>>   	.amd_nb_constraints	= 1,
>>   };
>>   
>> -static int __init amd_core_pmu_init(void)
>> +/*
>> + * This function initializes core PMU to enable support
>> + * for AMD Core PMC Extension.
>> + */
>> +static int __init amd_core_pmc_ext_init(void)
>>   {
>>   	if (!boot_cpu_has(X86_FEATURE_PERFCTR_CORE))
>>   		return 0;
> This renaming looks pretty useless to me. So does the comment.
I'll remove the renaming and comment in a v2 patch.
>

  reply	other threads:[~2016-11-16 20:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 17:01 [PATCH] Support for perf on AMD family17h processors Janakarajan Natarajan
2016-11-16 17:30 ` Peter Zijlstra
2016-11-16 20:41   ` Natarajan, Janakarajan
2016-11-16 18:47 ` Borislav Petkov
2016-11-16 20:49   ` Natarajan, Janakarajan [this message]
2016-11-17  6:46 ` Ingo Molnar
2016-11-17 15:50   ` Natarajan, Janakarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd06d95-1d43-934c-4112-016f1c076585@amd.com \
    --to=janakarajan.natarajan@amd.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).