* [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength
2022-09-30 19:20 [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
@ 2022-09-30 19:20 ` Krzysztof Kozlowski
2022-09-30 19:41 ` Konrad Dybcio
2022-09-30 19:20 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-30 19:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski, stable
The pin configuration (done with generic pin controller helpers and
as expressed by bindings) requires children nodes with either:
1. "pins" property and the actual configuration,
2. another set of nodes with above point.
The qup_i2c12_default pin configuration used second method - with a
"pinmux" child.
Fixes: d4b341269efb ("arm64: dts: qcom: Add support for Samsung Galaxy Book2")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
index f954fe5cb61a..d028a7eb364a 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
@@ -415,8 +415,10 @@ pinconf {
};
&qup_i2c12_default {
- drive-strength = <2>;
- bias-disable;
+ pinmux {
+ drive-strength = <2>;
+ bias-disable;
+ };
};
&qup_uart6_default {
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength
2022-09-30 19:20 ` [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: " Krzysztof Kozlowski
@ 2022-09-30 19:41 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2022-09-30 19:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm, devicetree,
linux-kernel
Cc: stable
On 30.09.2022 21:20, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_i2c12_default pin configuration used second method - with a
> "pinmux" child.
>
> Fixes: d4b341269efb ("arm64: dts: qcom: Add support for Samsung Galaxy Book2")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> index f954fe5cb61a..d028a7eb364a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> @@ -415,8 +415,10 @@ pinconf {
> };
>
> &qup_i2c12_default {
> - drive-strength = <2>;
> - bias-disable;
> + pinmux {
> + drive-strength = <2>;
> + bias-disable;
> + };
> };
>
> &qup_uart6_default {
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name
2022-09-30 19:20 [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
2022-09-30 19:20 ` [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: " Krzysztof Kozlowski
@ 2022-09-30 19:20 ` Krzysztof Kozlowski
2022-09-30 19:41 ` Konrad Dybcio
2022-10-01 0:05 ` Molly Sophia
2022-09-30 19:42 ` [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Konrad Dybcio
` (2 subsequent siblings)
4 siblings, 2 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-30 19:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Fix typo in the codec's pin name to be configured. Mismatched name
caused the pin configuration to be ignored.
Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index afc17e4d403f..f98259489679 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -628,7 +628,7 @@ sde_dsi_suspend: sde-dsi-suspend {
};
wcd_intr_default: wcd-intr-default {
- pins = "goui54";
+ pins = "gpio54";
function = "gpio";
input-enable;
bias-pull-down;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name
2022-09-30 19:20 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name Krzysztof Kozlowski
@ 2022-09-30 19:41 ` Konrad Dybcio
2022-10-01 0:05 ` Molly Sophia
1 sibling, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2022-09-30 19:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm, devicetree,
linux-kernel
On 30.09.2022 21:20, Krzysztof Kozlowski wrote:
> Fix typo in the codec's pin name to be configured. Mismatched name
> caused the pin configuration to be ignored.
>
> Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index afc17e4d403f..f98259489679 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -628,7 +628,7 @@ sde_dsi_suspend: sde-dsi-suspend {
> };
>
> wcd_intr_default: wcd-intr-default {
> - pins = "goui54";
> + pins = "gpio54";
> function = "gpio";
> input-enable;
> bias-pull-down;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name
2022-09-30 19:20 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name Krzysztof Kozlowski
2022-09-30 19:41 ` Konrad Dybcio
@ 2022-10-01 0:05 ` Molly Sophia
1 sibling, 0 replies; 9+ messages in thread
From: Molly Sophia @ 2022-10-01 0:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, linux-arm-msm, devicetree, linux-kernel
Tested-by: Molly Sophia <mollysophia379@gmail.com>
On Sat, Oct 1, 2022 at 3:20 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Fix typo in the codec's pin name to be configured. Mismatched name
> caused the pin configuration to be ignored.
>
> Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index afc17e4d403f..f98259489679 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -628,7 +628,7 @@ sde_dsi_suspend: sde-dsi-suspend {
> };
>
> wcd_intr_default: wcd-intr-default {
> - pins = "goui54";
> + pins = "gpio54";
> function = "gpio";
> input-enable;
> bias-pull-down;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength
2022-09-30 19:20 [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
2022-09-30 19:20 ` [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: " Krzysztof Kozlowski
2022-09-30 19:20 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name Krzysztof Kozlowski
@ 2022-09-30 19:42 ` Konrad Dybcio
2022-09-30 19:45 ` Steev Klimaszewski
2022-10-18 3:05 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2022-09-30 19:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Sudeep Holla, Lee Jones, Arnd Bergmann,
Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm, devicetree,
linux-kernel
Cc: stable
On 30.09.2022 21:20, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_i2c12_default pin configuration used second method - with a
> "pinmux" child.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index be59a8ba9c1f..74f43da51fa5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -487,8 +487,10 @@ pinconf {
> };
>
> &qup_i2c12_default {
> - drive-strength = <2>;
> - bias-disable;
> + pinmux {
> + drive-strength = <2>;
> + bias-disable;
> + };
> };
>
> &qup_uart6_default {
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength
2022-09-30 19:20 [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-09-30 19:42 ` [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Konrad Dybcio
@ 2022-09-30 19:45 ` Steev Klimaszewski
2022-10-18 3:05 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Steev Klimaszewski @ 2022-09-30 19:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Sudeep Holla, Lee Jones,
Arnd Bergmann, Vinod Koul, Xilin Wu, Molly Sophia, linux-arm-msm,
devicetree, linux-kernel
Cc: stable
On 9/30/22 2:20 PM, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_i2c12_default pin configuration used second method - with a
> "pinmux" child.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index be59a8ba9c1f..74f43da51fa5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -487,8 +487,10 @@ pinconf {
> };
>
> &qup_i2c12_default {
> - drive-strength = <2>;
> - bias-disable;
> + pinmux {
> + drive-strength = <2>;
> + bias-disable;
> + };
> };
>
> &qup_uart6_default {
Tested-by: Steev Klimaszewski <steev@kali.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength
2022-09-30 19:20 [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-09-30 19:45 ` Steev Klimaszewski
@ 2022-10-18 3:05 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2022-10-18 3:05 UTC (permalink / raw)
To: robh+dt, devicetree, lee.jones, linux-kernel, agross,
sudeep.holla, krzysztof.kozlowski, vkoul, mollysophia379,
wuxilin123, Arnd Bergmann, linux-arm-msm, Krzysztof Kozlowski,
Konrad Dybcio
Cc: stable
On Fri, 30 Sep 2022 21:20:37 +0200, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_i2c12_default pin configuration used second method - with a
> "pinmux" child.
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength
commit: fd49776d8f458bba5499384131eddc0b8bcaf50c
[2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength
commit: 3638ea010c37e1e6d93474c4b3368f403600413f
[3/3] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name
commit: 58c4a0b6f4bdf8c3c2b4aad7f980e4019cc0fc83
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread