From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Timur Tabi <timur@kernel.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Linus <linus.walleij@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning
Date: Tue, 9 Oct 2018 11:14:44 -0600 [thread overview]
Message-ID: <8d8c1aca-c194-c473-3906-c0e7d4a0d0c8@codeaurora.org> (raw)
In-Reply-To: <CAOZdJXU=p0kz0PNhP8KwCQ0o7TuM=z2SvEz4b60_KveCrT7zPA@mail.gmail.com>
On 10/5/2018 10:54 AM, Timur Tabi wrote:
> On 10/05/2018 11:17 AM, Jeffrey Hugo wrote:>
>> Looks like the driver is initing just fine to me. Is setting up the
>> jumpers and running gpio-test warranted?
>
> Well, that test only makes sure that input/output is actually working
> on the hardware level, but it also makes sure that the GPIOs are
> numbered correctly.
>
> If you want, just put a printk(... offset) in msm_gpio_get() and read
> from a GPIO that you know you have access to, and make sure the
> 'offset' is correct.
>
> Then try reading from a GPIO that you don't have access to, and make
> sure you get a failure before msm_gpio_get() is called.
>
Done.
For the series:
Tested-by: Jeffrey Hugo <jhugo@codeaurora.org>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-10-09 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 6:52 [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Ricardo Ribalda Delgado
2018-10-05 6:52 ` [PATCH v5 2/3] pinctrl: msm: Use " Ricardo Ribalda Delgado
2018-10-07 13:03 ` Timur Tabi
2018-10-10 8:30 ` Linus Walleij
2018-10-05 6:53 ` [PATCH v5 3/3] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-10-05 16:17 ` Jeffrey Hugo
2018-10-05 16:54 ` Timur Tabi
2018-10-05 20:44 ` Timur Tabi
2018-10-09 17:14 ` Jeffrey Hugo [this message]
2018-10-10 8:31 ` Linus Walleij
2018-10-11 12:18 ` Vignesh R
2018-10-11 13:42 ` Ricardo Ribalda Delgado
2018-10-12 5:59 ` Vignesh R
2018-10-12 6:03 ` Linus Walleij
2018-10-12 9:00 ` REGRESSION: " Marcel Ziswiler
2018-10-12 9:08 ` Linus Walleij
2018-10-12 9:34 ` Marcel Ziswiler
2018-10-10 7:55 ` [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d8c1aca-c194-c473-3906-c0e7d4a0d0c8@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).