linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: timur@kernel.org, Stephen Boyd <swboyd@chromium.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	jhugo@codeaurora.org,
	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning
Date: Fri, 12 Oct 2018 11:08:50 +0200	[thread overview]
Message-ID: <CACRpkdY89b-hy_aoBiZXX6KqyJrZd0fX9-XCGcF9XjPBy6Lwrw@mail.gmail.com> (raw)
In-Reply-To: <1539334839.30485.9.camel@toradex.com>

On Fri, Oct 12, 2018 at 11:00 AM Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
> On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote:
> > Current code assumes that the direction is input if direction_input
> > function is set.
> > This might not be the case on GPIOs with programmable direction.
>
> Unfortunately, this breaks at least Apalis T30 and Apalis TK1. Enabling
> earlycon reveals the following:

Does this (just applied) patch fix the issue?
https://marc.info/?l=linux-kernel&m=153932470412013&w=2

Yours,
Linus Walleij

  reply	other threads:[~2018-10-12  9:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  6:52 [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Ricardo Ribalda Delgado
2018-10-05  6:52 ` [PATCH v5 2/3] pinctrl: msm: Use " Ricardo Ribalda Delgado
2018-10-07 13:03   ` Timur Tabi
2018-10-10  8:30   ` Linus Walleij
2018-10-05  6:53 ` [PATCH v5 3/3] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-10-05 16:17   ` Jeffrey Hugo
2018-10-05 16:54     ` Timur Tabi
2018-10-05 20:44       ` Timur Tabi
2018-10-09 17:14       ` Jeffrey Hugo
2018-10-10  8:31   ` Linus Walleij
2018-10-11 12:18   ` Vignesh R
2018-10-11 13:42     ` Ricardo Ribalda Delgado
2018-10-12  5:59       ` Vignesh R
2018-10-12  6:03         ` Linus Walleij
2018-10-12  9:00   ` REGRESSION: " Marcel Ziswiler
2018-10-12  9:08     ` Linus Walleij [this message]
2018-10-12  9:34       ` Marcel Ziswiler
2018-10-10  7:55 ` [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdY89b-hy_aoBiZXX6KqyJrZd0fX9-XCGcF9XjPBy6Lwrw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=ricardo.ribalda@gmail.com \
    --cc=swboyd@chromium.org \
    --cc=timur@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).